https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43490 --- Comment #2 from David Cook <dcook@prosentient.com.au> --- Hmm if I do a try/catch... and then get rid of the $m and try to backspace over the widget used by the $2 ddc... it throws the same error... Maybe it's the proximity of the $2 and $c widgets right next to each other... -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43490 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Advanced editor failing to |Advanced editor not |load when 942$2 and 942$m |handling marcWidgetPrefill |missing values |correctly -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43490 --- Comment #3 from David Cook <dcook@prosentient.com.au> --- Created attachment 205401 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=205401&action=edit Problematic MARCXML record -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43490 --- Comment #4 from David Cook <dcook@prosentient.com.au> --- Created attachment 205402 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=205402&action=edit Bug 43490: Fix advanced editor widget marcWidgetPrefill This change fixes the marcWiedgetPrefill in the advanced editor so that it properly stops processing a line when it does a marcWidgetPrefill, so that the updated line gets actioned instead of the original line, which can have the wrong offsets in some situations (e.g. $2 empty gets prefilled to $2ddc which causes an issue for $cBK). Test plan: 0. Don't apply the patch yet 1. Import the attached "Problematic MARCXML record" 2. Enable the "EnableAdvancedCatalogingEditor" system preference 3. Edit the problematic record using the Advanced Editor 4. Note that the editor doesn't finish loading and you get a console error like "Uncaught Error: Inserting collapsed marker partially overlapping an existing one" 5. Apply the patch 6. Refresh the page with the advanced editor 7. Note that it now loads and the 942$2 has a widget that defaults to "Dewey Decimal Classification" and a 942$c widget that defaults to "Books" 8. Time to celebrate! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43490 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43490 --- Comment #5 from David Nind <david@davidnind.com> --- Created attachment 205426 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=205426&action=edit Bug 43490: Fix advanced editor widget marcWidgetPrefill This change fixes the marcWiedgetPrefill in the advanced editor so that it properly stops processing a line when it does a marcWidgetPrefill, so that the updated line gets actioned instead of the original line, which can have the wrong offsets in some situations (e.g. $2 empty gets prefilled to $2ddc which causes an issue for $cBK). Test plan: 0. Don't apply the patch yet 1. Import the attached "Problematic MARCXML record" 2. Enable the "EnableAdvancedCatalogingEditor" system preference 3. Edit the problematic record using the Advanced Editor 4. Note that the editor doesn't finish loading and you get a console error like "Uncaught Error: Inserting collapsed marker partially overlapping an existing one" 5. Apply the patch 6. Refresh the page with the advanced editor 7. Note that it now loads and the 942$2 has a widget that defaults to "Dewey Decimal Classification" and a 942$c widget that defaults to "Books" 8. Time to celebrate! Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43490 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |Main -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43490 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43490 --- Comment #7 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 206155 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206155&action=edit Bug 43490: Fix advanced editor widget marcWidgetPrefill This change fixes the marcWiedgetPrefill in the advanced editor so that it properly stops processing a line when it does a marcWidgetPrefill, so that the updated line gets actioned instead of the original line, which can have the wrong offsets in some situations (e.g. $2 empty gets prefilled to $2ddc which causes an issue for $cBK). Test plan: 0. Don't apply the patch yet 1. Import the attached "Problematic MARCXML record" 2. Enable the "EnableAdvancedCatalogingEditor" system preference 3. Edit the problematic record using the Advanced Editor 4. Note that the editor doesn't finish loading and you get a console error like "Uncaught Error: Inserting collapsed marker partially overlapping an existing one" 5. Apply the patch 6. Refresh the page with the advanced editor 7. Note that it now loads and the 942$2 has a widget that defaults to "Dewey Decimal Classification" and a 942$c widget that defaults to "Books" 8. Time to celebrate! Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43490 --- Comment #9 from David Cook <dcook@prosentient.com.au> --- (In reply to Pedro Amorim (ammopt) from comment #8)

This also drops the '<empty>' fallback for widgets without a makeTemplate, so empty 005 fields no longer get a widget. I've only tested 005, but 001 should be affected the same way. Was this intentional?

Yeah, I remember being intentional but I can't remember why. It might've just been that I couldn't see '<empty>' doing anything, but I clearly just didn't understand the feature well enough. I'll have to take another look at this one. -- You are receiving this mail because: You are watching all bug changes.