[Bug 18685] New: Patron edit/cancel floating toolbar out of place
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18685 Bug ID: 18685 Summary: Patron edit/cancel floating toolbar out of place Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com When editing a patron, the floating toolbar with the save/cancel buttons is out of place on top of the page before scrolling (see attached screenshot) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18685 --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 63755 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63755&action=edit screenshot of toolbar Verified behaviour on 16.11.08 and master. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18685 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron@veron.ch Depends on| |18551 --- Comment #2 from Marc Véron <veron@veron.ch> --- The original position seems to be defined in memberentrygen.tt, line 15: var additional_height = $("#filters").height(); Not sure, but I guess that this is a side effect of Bug 18551, because filters now are collapsed. Setting this bug as dependent of Bug 18551. Please remove dependency if I'm wrong. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18551 [Bug 18551] Hide with CSS dynamic elements in member search -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18685 Lisette <lisetteslatah@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisetteslatah@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18685 --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I have reverted bug 18551 to restore the former behaviour. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18685 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org Status|NEW |ASSIGNED Assignee|koha-bugs@lists.koha-commun |fridolin.somers@biblibre.co |ity.org |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18685 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|fridolin.somers@biblibre.co |jonathan.druart@bugs.koha-c |m |ommunity.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18685 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18685 --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 64205 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64205&action=edit Bug 18685: (bug 18551 follow-up) Fix patron toolbar Bug 18551 moves the way the filters are displayed and so the position of the patron toolbar must be recalculated. Test plan: Edit patron's detail open the filters, scrolldown close the filters, scrolldown => The toolbar must be correctly placed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18685 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18685 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64205|0 |1 is obsolete| | --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 64206 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64206&action=edit [SIGNED-OFF] Bug 18685: (bug 18551 follow-up) Fix patron toolbar Bug 18551 moves the way the filters are displayed and so the position of the patron toolbar must be recalculated. Test plan: Edit patron's detail open the filters, scrolldown close the filters, scrolldown => The toolbar must be correctly placed Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18685 --- Comment #6 from Marc Véron <veron@veron.ch> --- Created attachment 64207 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64207&action=edit Bug 18685: (bug 18551 follow-up) Fix patron toolbar Bug 18551 moves the way the filters are displayed and so the position of the patron toolbar must be recalculated. Test plan: Edit patron's detail open the filters, scrolldown close the filters, scrolldown => The toolbar must be correctly placed Followed test plan, works as expected. Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18685 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64207|0 |1 is obsolete| | --- Comment #7 from Marc Véron <veron@veron.ch> --- Comment on attachment 64207 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64207 Bug 18685: (bug 18551 follow-up) Fix patron toolbar Owen was faster - obsoleting my SO patch :-) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18685 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Skipping QA. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18685 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #9 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18685 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Status|Pushed to Master |Pushed to Stable --- Comment #10 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Pushed to 17.05.x, will be in 17.05.01 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18685 --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Blocked for 16.11.x by 18551 not applying cleanly. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18685 --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This patch has been pushed to 16.11.x and will be in 16.11.11. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18685 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj@kohaaloha.com --- Comment #13 from Mason James <mtj@kohaaloha.com> --- Pushed to 16.05.x, for 16.05.16 release -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org