[Bug 18951] New: Some t/Biblio tests are not database agnostic
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18951 Bug ID: 18951 Summary: Some t/Biblio tests are not database agnostic Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Test Suite Assignee: chris@bigballofwax.co.nz Reporter: m.de.rooy@rijksmuseum.nl QA Contact: testopia@bugs.koha-community.org t/Biblio/Isbd.t SHOULD MOVE to db_dependent Same for TransformKohaToMarc.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18951 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|chris@bigballofwax.co.nz |m.de.rooy@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18951 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Some t/Biblio tests are not |Some t/Biblio tests are |database agnostic |database dependent -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18951 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18951 --- Comment #1 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 65093 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65093&action=edit Bug 18951: Some t/Biblio tests are database dependent (git mv) Move Isbd.t and TransformKohaToMarc.t to db_dependent. Next patch will add a few adjustments too. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18951 --- Comment #2 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 65094 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65094&action=edit Bug 18951: Create data for TransformKohaToMarc.t Adding schema and caching statements. Adjust it so that the Koha to MARC mappings are not assumed to be present, but are created as needed. Remove the mock on marcflavour. It is no longer needed. Resolving a small typo. Test plan: Run t/db_dependent/Biblio/TransformKohaToMarc.t Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18951 --- Comment #3 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 65095 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65095&action=edit Bug 18951: Adjust Isbd.t Add schema calls. Remove an unneeded AddBiblio call. Test plan: Run t/db_dependent/Biblio/Isbd.t Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18951 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |10306 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10306 [Bug 10306] Allow duplicate Koha to Marc mappings (say publication info in MARC21 260 or RDA 264) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18951 Lee Jamison <ldjamison@marywood.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18951 Lee Jamison <ldjamison@marywood.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #65093|0 |1 is obsolete| | --- Comment #4 from Lee Jamison <ldjamison@marywood.edu> --- Created attachment 65096 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65096&action=edit Bug 18951: Some t/Biblio tests are database dependent (git mv) Move Isbd.t and TransformKohaToMarc.t to db_dependent. Next patch will add a few adjustments too. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Lee Jamison <ldjamison@marywood.edu> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18951 Lee Jamison <ldjamison@marywood.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #65094|0 |1 is obsolete| | --- Comment #5 from Lee Jamison <ldjamison@marywood.edu> --- Created attachment 65097 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65097&action=edit Bug 18951: Create data for TransformKohaToMarc.t Adding schema and caching statements. Adjust it so that the Koha to MARC mappings are not assumed to be present, but are created as needed. Remove the mock on marcflavour. It is no longer needed. Resolving a small typo. Test plan: Run t/db_dependent/Biblio/TransformKohaToMarc.t Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Lee Jamison <ldjamison@marywood.edu> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18951 Lee Jamison <ldjamison@marywood.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #65095|0 |1 is obsolete| | --- Comment #6 from Lee Jamison <ldjamison@marywood.edu> --- Created attachment 65098 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65098&action=edit Bug 18951: Adjust Isbd.t Add schema calls. Remove an unneeded AddBiblio call. Test plan: Run t/db_dependent/Biblio/Isbd.t Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Lee Jamison <ldjamison@marywood.edu> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18951 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18951 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #65096|0 |1 is obsolete| | Attachment #65097|0 |1 is obsolete| | Attachment #65098|0 |1 is obsolete| | --- Comment #7 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 65167 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65167&action=edit Bug 18951: Some t/Biblio tests are database dependent (git mv) Move Isbd.t and TransformKohaToMarc.t to db_dependent. Next patch will add a few adjustments too. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Lee Jamison <ldjamison@marywood.edu> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18951 --- Comment #8 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 65168 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65168&action=edit Bug 18951: Create data for TransformKohaToMarc.t Adding schema and caching statements. Adjust it so that the Koha to MARC mappings are not assumed to be present, but are created as needed. Remove the mock on marcflavour. It is no longer needed. Resolving a small typo. Test plan: Run t/db_dependent/Biblio/TransformKohaToMarc.t Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Lee Jamison <ldjamison@marywood.edu> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18951 --- Comment #9 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 65169 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65169&action=edit Bug 18951: Adjust Isbd.t Add schema calls. Remove an unneeded AddBiblio call. Test plan: Run t/db_dependent/Biblio/Isbd.t Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Lee Jamison <ldjamison@marywood.edu> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18951 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #10 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18951 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #11 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Testing on 17.05.x, I get a crash : $ prove t/db_dependent/Biblio/TransformKohaToMarc.t t/db_dependent/Biblio/TransformKohaToMarc.t .. DBIx::Class::ResultSet::find(): find() expects either a column/value hashref, or a list of values corresponding to the columns of the specified unique constraint 'primary' at /home/koha/src/Koha/Objects.pm line 83 # Looks like your test exited with 255 before it could output anything. t/db_dependent/Biblio/TransformKohaToMarc.t .. Dubious, test returned 255 (wstat 65280, 0xff00) Failed 1/1 subtests Test Summary Report ------------------- t/db_dependent/Biblio/TransformKohaToMarc.t (Wstat: 65280 Tests: 0 Failed: 0) Non-zero exit status: 255 Parse errors: Bad plan. You planned 1 tests but ran 0. Files=1, Tests=0, 1 wallclock secs ( 0.02 usr 0.00 sys + 0.71 cusr 0.04 csys = 0.77 CPU) Result: FAIL Looks like Koha::MarcSubfieldStructures->find('','300','b') crashed. May I use Koha::MarcSubfieldStructures->search( { frameworkcode => '', tagfield => '300', tagsubfield => 'a' } ) like in AuthorisedValues.t ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18951 --- Comment #12 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Fridolin SOMERS from comment #11)
Looks like Koha::MarcSubfieldStructures->find('','300','b') crashed. May I use Koha::MarcSubfieldStructures->search( { frameworkcode => '', tagfield => '300', tagsubfield => 'a' } ) like in AuthorisedValues.t ?
Yes, that should do it. You will need an extra ->next or ->first or so. There was an adjustment to Koha::Object's find. Probably not in 17.05. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18951 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |18361 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18361 [Bug 18361] Koha::Objects->find should accept composite primary keys -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18951 --- Comment #13 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- (In reply to Marcel de Rooy from comment #12)
(In reply to Fridolin SOMERS from comment #11)
Looks like Koha::MarcSubfieldStructures->find('','300','b') crashed. May I use Koha::MarcSubfieldStructures->search( { frameworkcode => '', tagfield => '300', tagsubfield => 'a' } ) like in AuthorisedValues.t ?
Yes, that should do it. You will need an extra ->next or ->first or so. There was an adjustment to Koha::Object's find. Probably not in 17.05.
Yes I found it is dependent from Bug 18361 not in 17.05.x. I choose to integrate it. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18951 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #14 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Pushed to 17.05.x, will be in 17.05.03. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18951 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #15 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Blocked by 18361 not applying to 16.11.x. If you want this to be included, please help by rebasing it to the latest 16.11.x. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18951 --- Comment #16 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Katrin Fischer from comment #15)
Blocked by 18361 not applying to 16.11.x. If you want this to be included, please help by rebasing it to the latest 16.11.x.
Try again :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18951 --- Comment #17 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- These patches have been pushed to 16.11.x and will be in 16.11.11. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18951 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj@kohaaloha.com --- Comment #18 from Mason James <mtj@kohaaloha.com> --- Pushed to 16.05.x, for 16.05.16 release -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org