[Bug 39677] New: Add the role presentation to the vertical divider in the navigation.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39677 Bug ID: 39677 Summary: Add the role presentation to the vertical divider in the navigation. Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Accessibility Assignee: koha-bugs@lists.koha-community.org Reporter: nina.martinez@biblibre.com QA Contact: testopia@bugs.koha-community.org CC: martin.renvoize@openfifth.co.uk, matt.blenkinsop@openfifth.co.uk, oleonard@myacpl.org In the OPAC navigation, the vertical dividers are presentational but do not have the role="presentation". It would be great if we could add it to semantic tags that are used only for presentation. This could be helpful for assistive technologies. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39677 Nina Martinez <nina.martinez@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |nina.martinez@biblibre.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39677 Nina Martinez <nina.martinez@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39677 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice@biblibre.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39677 --- Comment #1 from Nina Martinez <nina.martinez@biblibre.com> --- Created attachment 181239 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181239&action=edit Bug 39677: Add the role presentation to the divider vertical tags Test plan: Enable the following system preferences: CookieConsent, EnableOpacSearchHistory, and OpacLangSelectorMode (both top and footer). -Apply the patch. -Go to the Koha OPAC. -Check the vertical dividers in the navigation. -If they are present with a coherent design, the test is successful. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39677 Nina Martinez <nina.martinez@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39677 Nina Martinez <nina.martinez@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |23003 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23003 [Bug 23003] [OMNIBUS] Accessibility improvements -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39677 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39677 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181239|0 |1 is obsolete| | --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 181432 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181432&action=edit Bug 39677: Add the role presentation to the divider vertical tags Test plan: Enable the following system preferences: CookieConsent, EnableOpacSearchHistory, and OpacLangSelectorMode (both top and footer). - Apply the patch. - Go to the Koha OPAC. - Check the vertical dividers in the navigation. - If they are present with a coherent design, the test is successful. Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39677 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181432|0 |1 is obsolete| | --- Comment #3 from David Nind <david@davidnind.com> --- Created attachment 181565 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181565&action=edit Bug 39677: Add the role presentation to the divider vertical tags Test plan: Enable the following system preferences: CookieConsent, EnableOpacSearchHistory, and OpacLangSelectorMode (both top and footer). - Apply the patch. - Go to the Koha OPAC. - Check the vertical dividers in the navigation. - If they are present with a coherent design, the test is successful. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39677 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #4 from David Nind <david@davidnind.com> --- I added my sign off, in case Owen's can count as QA. However, running the QA script generates errors, but that may be because of something wrong my setup: qa testing 1 commit(s) (applied to 9640d5d '38 Bug 38842: (follow-up) Fix TT filt') Processing files before patches |========================>| 2 / 2 (100.00%) Processing files after patches [error] Cannot find package '@koha-community/prettier-plugin-template-toolkit' imported from /kohadevbox/koha/noop.js at misc/devel/tidy.pl line 112. [error] Cannot find package '@koha-community/prettier-plugin-template-toolkit' imported from /kohadevbox/koha/noop.js at misc/devel/tidy.pl line 112. FAIL koha-tmpl/opac-tmpl/bootstrap/en/includes/langmenu.inc FAIL tidiness File is not tidy, please run `perl misc/devel/tidy.pl koha-tmpl/opac-tmpl/bootstrap/en/includes/langmenu.inc` FAIL koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead.inc FAIL tidiness File is not tidy, please run `perl misc/devel/tidy.pl koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead.inc` Processing additional checks OK! * Was this bug sponsored by anyone? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39677 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add the role presentation |Add the role presentation |to the vertical divider in |to the vertical divider in |the navigation. |the navigation -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39677 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Something in main is not right - that will cause the errors you see. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39677 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply CC| |lucas@bywatersolutions.com --- Comment #6 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Needs a rebase -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39677 Nina Martinez <nina.martinez@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181565|0 |1 is obsolete| | --- Comment #7 from Nina Martinez <nina.martinez@biblibre.com> --- Created attachment 182248 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182248&action=edit Bug 39677: Add the role presentation to the divider vertical tags Test plan: Enable the following system preferences: CookieConsent, EnableOpacSearchHistory, and OpacLangSelectorMode (both top and footer). -Apply the patch. -Go to the Koha OPAC. -Check the vertical dividers in the navigation. -If they are present with a coherent design, the test is successful. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39677 Nina Martinez <nina.martinez@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39677 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |Laura.escamilla@bywatersolu | |tions.com Status|Signed Off |Patch doesn't apply --- Comment #8 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Hi! Looks like we might need another rebase -- Applying: Bug 39677: Add the role presentation to the divider vertical tags Using index info to reconstruct a base tree... M koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead.inc Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead.inc CONFLICT (content): Merge conflict in koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead.inc error: Failed to merge in the changes. Patch failed at 0001 Bug 39677: Add the role presentation to the divider vertical tags hint: Use 'git am --show-current-patch=diff' to see the failed patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-39677-Add-the-role-presentation-to-the-divider-q9yymcu4.patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39677 Nina Martinez <nina.martinez@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #182248|0 |1 is obsolete| | --- Comment #9 from Nina Martinez <nina.martinez@biblibre.com> --- Created attachment 184728 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184728&action=edit Bug 39677: Add the role presentation to the divider vertical tags Test plan: Enable the following system preferences: CookieConsent, EnableOpacSearchHistory, and OpacLangSelectorMode (both top and footer). -Apply the patch. -Go to the Koha OPAC. -Check the vertical dividers in the navigation. -If they are present with a coherent design, the test is successful. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39677 Nina Martinez <nina.martinez@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39677 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |Accessibility improvement: release notes| |Vertical dividers in the | |OPAC navigation now include | |role="presentation" to | |ensure they are correctly | |identified as decorative | |elements. This provides | |clearer semantics for | |assistive technologies | |without affecting display | |or design. QA Contact|testopia@bugs.koha-communit |Laura.escamilla@bywatersolu |y.org |tions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39677 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39677 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #184728|0 |1 is obsolete| | --- Comment #10 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Created attachment 187101 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187101&action=edit Bug 39677: Add the role presentation to the divider vertical tags Test plan: Enable the following system preferences: CookieConsent, EnableOpacSearchHistory, and OpacLangSelectorMode (both top and footer). -Apply the patch. -Go to the Koha OPAC. -Check the vertical dividers in the navigation. -If they are present with a coherent design, the test is successful. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Laura_Escamilla <laura.escamilla@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39677 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |25.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39677 --- Comment #11 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 25.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39677 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Needs documenting Version(s)|25.11.00 |25.11.00, 25.05.x released in| | --- Comment #12 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- This change has been backported to the 25.05.x branch for improved accessibility. Thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39677 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Needs documenting |RESOLVED --- Comment #13 from David Nind <david@davidnind.com> --- No changes to the manual required. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39677 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Version(s)|25.11.00, 25.05.x |25.11.00,25.05.07 released in| | -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org