[Bug 38942] New: Item template toolbar is not like other toolbars
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38942 Bug ID: 38942 Summary: Item template toolbar is not like other toolbars Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff interface Assignee: koha-bugs@lists.koha-community.org Reporter: lucas@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com If you look at the item-template-toolbar in Koha, it looks quite different from other toolbars in Koha. TO recreate: -Add an item and 'Save as template' -Notice the toolbar buttons look different from other toolbars in Koha. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38942 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38942 --- Comment #1 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 176885 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176885&action=edit Bug 38942: Fix display issues with item-template-toolbar This patch does the following: -Adds a 'btn' and 'btn-default' class to the buttons in the item-template-toolbar -Removes the btn-group parent containers -Changes the wording of the remember session checkbox to 'Remember for session', just like it is on the check out screen for due dates. -Adds a visual divider after the 'Remember for session' checkbox -Add CSS to addbiblio.css to make the checkbox/label appear a little nicer To test: -Add an item and 'Save as template' -Notice the toolbar buttons look different from other toolbars in Koha. -Apply patch -Look again, the buttons should look better, hopefully! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38942 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |String patch Assignee|koha-bugs@lists.koha-commun |lucas@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38942 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This enhancement improves release notes| |the item-template-toolbar | |in Koha, adding some | |classes to be consistent | |with other toolbars in | |Koha. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38942 PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #176885|0 |1 is obsolete| | --- Comment #2 from PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> --- Created attachment 176923 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176923&action=edit Bug 38942: Fix display issues with item-template-toolbar This patch does the following: -Adds a 'btn' and 'btn-default' class to the buttons in the item-template-toolbar -Removes the btn-group parent containers -Changes the wording of the remember session checkbox to 'Remember for session', just like it is on the check out screen for due dates. -Adds a visual divider after the 'Remember for session' checkbox -Add CSS to addbiblio.css to make the checkbox/label appear a little nicer To test: -Add an item and 'Save as template' -Notice the toolbar buttons look different from other toolbars in Koha. -Apply patch -Look again, the buttons should look better, hopefully! Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38942 Barbara Johnson <barbara.johnson@bedfordtx.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |barbara.johnson@bedfordtx.g | |ov -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38942 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38942 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #176923|0 |1 is obsolete| | --- Comment #3 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 177748 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177748&action=edit Bug 38942: Fix display issues with item-template-toolbar This patch does the following: -Adds a 'btn' and 'btn-default' class to the buttons in the item-template-toolbar -Removes the btn-group parent containers -Changes the wording of the remember session checkbox to 'Remember for session', just like it is on the check out screen for due dates. -Adds a visual divider after the 'Remember for session' checkbox -Add CSS to addbiblio.css to make the checkbox/label appear a little nicer To test: -Add an item and 'Save as template' -Notice the toolbar buttons look different from other toolbars in Koha. -Apply patch -Look again, the buttons should look better, hopefully! Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38942 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38942 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177748|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 177754 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177754&action=edit Bug 38942: Fix display issues with item-template-toolbar This patch does the following: -Adds a 'btn' and 'btn-default' class to the buttons in the item-template-toolbar -Removes the btn-group parent containers -Changes the wording of the remember session checkbox to 'Remember for session', just like it is on the check out screen for due dates. -Adds a visual divider after the 'Remember for session' checkbox -Add CSS to addbiblio.css to make the checkbox/label appear a little nicer To test: -Add an item and 'Save as template' -Notice the toolbar buttons look different from other toolbars in Koha. -Apply patch -Look again, the buttons should look better, hopefully! Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38942 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |baptiste.wojtkowski@biblibr | |e.com --- Comment #5 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- The button "Remember for session" should be aligned with other button -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38942 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |baptiste.wojtkowski@biblibr |y.org |e.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38942 --- Comment #6 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- (In reply to Baptiste Wojtkowski (bwoj) from comment #5)
The button "Remember for session" should be aligned with other button
It's not a button, it's a checkbox with a label. Just let me know what you want here and I'll do it. It does seem aligned to me. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38942 --- Comment #7 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 182267 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182267&action=edit Screenshot showing toolbar appearance The alignment looks good to me -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38942 --- Comment #8 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Created attachment 182579 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182579&action=edit Alignment in the toolbar I feel like the checkbox is not aligned, a little bit too high (see attachment). If it looks well aligned to you all, I cann PQA this. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38942 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38942 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38942 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177754|0 |1 is obsolete| | --- Comment #9 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 187012 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187012&action=edit Bug 38942: Fix display issues with item-template-toolbar This patch does the following: -Adds a 'btn' and 'btn-default' class to the buttons in the item-template-toolbar -Removes the btn-group parent containers -Changes the wording of the remember session checkbox to 'Remember for session', just like it is on the check out screen for due dates. -Adds a visual divider after the 'Remember for session' checkbox -Add CSS to addbiblio.css to make the checkbox/label appear a little nicer To test: -Add an item and 'Save as template' -Notice the toolbar buttons look different from other toolbars in Koha. -Apply patch -Look again, the buttons should look better, hopefully! Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38942 --- Comment #10 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- rebased for current main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38942 Kristi Krueger <kkrueger@cuyahogalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kkrueger@cuyahogalibrary.or | |g -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38942 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #187012|0 |1 is obsolete| | --- Comment #11 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Created attachment 187035 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187035&action=edit Bug 38942: Fix display issues with item-template-toolbar This patch does the following: -Adds a 'btn' and 'btn-default' class to the buttons in the item-template-toolbar -Removes the btn-group parent containers -Changes the wording of the remember session checkbox to 'Remember for session', just like it is on the check out screen for due dates. -Adds a visual divider after the 'Remember for session' checkbox -Add CSS to addbiblio.css to make the checkbox/label appear a little nicer To test: -Add an item and 'Save as template' -Notice the toolbar buttons look different from other toolbars in Koha. -Apply patch -Look again, the buttons should look better, hopefully! Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov> Signed-off-by: Baptiste Wojtkowski <baptiste.wojtkowski@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38942 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38942 Daniel B. <dbarden@cuyahogalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dbarden@cuyahogalibrary.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38942 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |25.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38942 --- Comment #12 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 25.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38942 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |Laura.escamilla@bywatersolu | |tions.com Status|Pushed to main |Needs documenting --- Comment #13 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- This change has been backported to the 25.05.x branch for it's accessibility features. Thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38942 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|25.11.00 |25.11.00, 25.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38942 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|25.11.00, 25.05.00 |25.11.00,25.05.07 released in| | CC| |fridolin.somers@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38942 --- Comment #14 from Fridolin Somers <fridolin.somers@biblibre.com> --- Enhancement not pushed to 24.11.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org