[Bug 17600] New: Standardize the EXPORT
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 Bug ID: 17600 Summary: Standardize the EXPORT Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart@bugs.koha-community.org Reporter: jonathan.druart@bugs.koha-community.org QA Contact: testopia@bugs.koha-community.org On bug 17591 we discovered that there was something weird going on with the way we export and use subroutines/modules. I tried to standardize our EXPORT to use EXPORT_OK only. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 57394 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57394&action=edit Bug 17600: Standardize our EXPORT_OK On bug 17591 we discovered that there was something weird going on with the way we export and use subroutines/modules. This patch tries to standardize our EXPORT to use EXPORT_OK only. That way we will need to explicitely define the subroutine we want to use from a module. There are still a lot of things to do, it would be good to write a script to do what's need to be done. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=17591 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com --- Comment #2 from Kyle M Hall <kyle@bywatersolutions.com> --- I just wanted to comment that I like this idea. Straight from perl.org: If you must export try to use @EXPORT_OK in preference to @EXPORT and avoid short or common symbol names to reduce the risk of name clashes. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl --- Comment #3 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Jonathan Druart from comment #1)
On bug 17591 we discovered that there was something weird going on with the way we export and use subroutines/modules. This patch tries to standardize our EXPORT to use EXPORT_OK only.
Probably Plack related? Would be good to list these things somewhere centrally too. Some saw some things too that you cannot understand perl-wise, but seem to be Plack peculiarities. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Marcel de Rooy from comment #3)
(In reply to Jonathan Druart from comment #1)
On bug 17591 we discovered that there was something weird going on with the way we export and use subroutines/modules. This patch tries to standardize our EXPORT to use EXPORT_OK only.
Probably Plack related? Would be good to list these things somewhere centrally too. Some saw some things too that you cannot understand perl-wise, but seem to be Plack peculiarities.
No it's not Plack related. It comes from tests, see bug 17591. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- +1 from me, this would be a great move forward for Koha :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset@hotmail.com --- Comment #6 from M. Tompsett <mtompset@hotmail.com> --- Those BEGIN blocks of ugliness will get cleaned up quite a bit with this. Plus, standards as per comment #2. Is this still being worked on, or did you forget to change it to needs sign off? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to M. Tompsett from comment #6)
Those BEGIN blocks of ugliness will get cleaned up quite a bit with this. Plus, standards as per comment #2. Is this still being worked on, or did you forget to change it to needs sign off?
Answer in the commit message: (In reply to Jonathan Druart from comment #1)
That way we will need to explicitely define the subroutine we want to use from a module. There are still a lot of things to do, it would be good to write a script to do what's need to be done.
-- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57394|0 |1 is obsolete| | --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 57950 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57950&action=edit Bug 17600: Standardize our EXPORT_OK On bug 17591 we discovered that there was something weird going on with the way we export and use subroutines/modules. This patch tries to standardize our EXPORT to use EXPORT_OK only. That way we will need to explicitely define the subroutine we want to use from a module. There are still a lot of things to do, it would be good to write a script to do what's need to be done. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 --- Comment #9 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 57951 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57951&action=edit Bug 17600: Remove useless extra spaces -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 --- Comment #10 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 57952 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57952&action=edit Bug 17600: continue replace of EXPORT with EXPORT_OK -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 --- Comment #11 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 57953 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57953&action=edit Bug 17600: Explicitly export the subroutines used This patch is generated using the export.pl script -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 --- Comment #12 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 57954 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57954&action=edit [DO NOT PUSH] Script to export the subroutines used This ugly script has been used to generate the last patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #13 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- So, what's next? It won't be feasible to test all the changes. So we need to decide if it worth the try to push these patches as it. At least it would be great to get a review from someone else. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion --- Comment #14 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Ok so, a lot of things is broken with these patches: - from tests: use_ok should be be used since it does not export subroutines - from pm: subroutines are not exported sometimes whereas the script assumes they were things are working when they are expecting not to (get_template_and_user from C4::Auth is not exported by scripts use it and it works). Maybe it would be easier not to export anything and use fully qualified names instead? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |17722 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17722 [Bug 17722] t/db_dependent/PatronLists.t doesn't run inside a transaction -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 --- Comment #15 from M. Tompsett <mtompset@hotmail.com> --- (In reply to Jonathan Druart from comment #14)
Maybe it would be easier not to export anything and use fully qualified names instead?
If someone has "use Foo;" in their code, they probably would rather write Bar() than Foo::Bar(); in their code. I know I would. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 --- Comment #16 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to M. Tompsett from comment #15)
(In reply to Jonathan Druart from comment #14)
Maybe it would be easier not to export anything and use fully qualified names instead?
If someone has "use Foo;" in their code, they probably would rather write Bar() than Foo::Bar(); in their code. I know I would.
It is what is done here, you have to export them explicitly. use Foo qw( bar ); bar(); -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Signed Off --- Comment #17 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Put in QA queue to get feedbacks from QAer. More than 2 signoffs from QA team members would be great. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 --- Comment #18 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Jonathan Druart from comment #17)
Put in QA queue to get feedbacks from QAer. More than 2 signoffs from QA team members would be great.
Will have a look later. But as you state, it needs another signoff too. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj@kohaaloha.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 --- Comment #19 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- This one is also on my list for today :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 --- Comment #20 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- This all looks solid to me, and is another move in the right direction in my opinion. Was about to add my Passed QA mark when I realised I'd need to rebase as the project moved whilst I was testing. Could you rebase Jonathan? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57950|0 |1 is obsolete| | Attachment #57951|0 |1 is obsolete| | Attachment #57952|0 |1 is obsolete| | Attachment #57953|0 |1 is obsolete| | --- Comment #21 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 61994 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61994&action=edit Bug 17600: Standardize our EXPORT_OK On bug 17591 we discovered that there was something weird going on with the way we export and use subroutines/modules. This patch tries to standardize our EXPORT to use EXPORT_OK only. That way we will need to explicitely define the subroutine we want to use from a module. There are still a lot of things to do, it would be good to write a script to do what's need to be done. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 --- Comment #22 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 61995 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61995&action=edit Bug 17600: Remove useless extra spaces -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 --- Comment #23 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 61996 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61996&action=edit Bug 17600: continue replace of EXPORT with EXPORT_OK -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 --- Comment #24 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 61997 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61997&action=edit Bug 17600: Explicitly export the subroutines used This patch is generated using the export.pl script -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 --- Comment #25 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 61998 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61998&action=edit Bug 17600: Rerun the script to update use statements -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #26 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Applying: Bug 17600: Explicitly export the subroutines used fatal: sha1 information is lacking or useless (C4/Auth_with_cas.pm). Repository lacks necessary blobs to fall back on 3-way merge. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61994|0 |1 is obsolete| | Attachment #61995|0 |1 is obsolete| | Attachment #61996|0 |1 is obsolete| | Attachment #61997|0 |1 is obsolete| | Attachment #61998|0 |1 is obsolete| | --- Comment #27 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 62209 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62209&action=edit Bug 17600: Standardize our EXPORT_OK On bug 17591 we discovered that there was something weird going on with the way we export and use subroutines/modules. This patch tries to standardize our EXPORT to use EXPORT_OK only. That way we will need to explicitely define the subroutine we want to use from a module. There are still a lot of things to do, it would be good to write a script to do what's need to be done. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 --- Comment #28 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 62210 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62210&action=edit Bug 17600: Remove useless extra spaces -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 --- Comment #29 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 62211 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62211&action=edit Bug 17600: continue replace of EXPORT with EXPORT_OK -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 --- Comment #30 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 62212 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62212&action=edit Bug 17600: Explicitly export the subroutines used This patch is generated using the export.pl script -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 --- Comment #31 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 62213 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62213&action=edit Bug 17600: Rerun the script to update use statements -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 --- Comment #32 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- So, this is a PQA from me.. Did Marcel also add his PQA.. if so we should do one last rebase and push the bugger ;) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 --- Comment #33 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Martin Renvoize from comment #32)
So, this is a PQA from me.. Did Marcel also add his PQA.. if so we should do one last rebase and push the bugger ;)
Did you add a signoff line? I still have a look this week. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62209|0 |1 is obsolete| | --- Comment #34 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 62940 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62940&action=edit Bug 17600: Standardize our EXPORT_OK On bug 17591 we discovered that there was something weird going on with the way we export and use subroutines/modules. This patch tries to standardize our EXPORT to use EXPORT_OK only. That way we will need to explicitely define the subroutine we want to use from a module. There are still a lot of things to do, it would be good to write a script to do what's need to be done. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62210|0 |1 is obsolete| | --- Comment #35 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 62941 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62941&action=edit Bug 17600: Remove useless extra spaces Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62211|0 |1 is obsolete| | --- Comment #36 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 62942 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62942&action=edit Bug 17600: continue replace of EXPORT with EXPORT_OK Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62212|0 |1 is obsolete| | --- Comment #37 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 62943 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62943&action=edit Bug 17600: Explicitly export the subroutines used This patch is generated using the export.pl script Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 --- Comment #38 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- I have now ;) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 --- Comment #39 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Martin Renvoize from comment #38)
I have now ;)
Great, Martin. Thanks. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #40 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Applying: Bug 17600: Rerun the script to update use statements fatal: sha1 information is lacking or useless (C4/Auth_with_shibboleth.pm). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0001 Bug 17600: Rerun the script to update use statements Somehow I have the feeling that we are running more frequently against these errors. Something to do with different git versions ? I am using git version 2.1.4 on Jessie. (Should be the default version?) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62213|0 |1 is obsolete| | --- Comment #41 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 62958 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62958&action=edit Bug 17600: Rerun the script to update use statements -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 --- Comment #42 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 62959 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62959&action=edit Bug 17600: re-Rerun the script to update use statements -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off --- Comment #43 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Marcel de Rooy from comment #40)
Applying: Bug 17600: Rerun the script to update use statements fatal: sha1 information is lacking or useless (C4/Auth_with_shibboleth.pm). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0001 Bug 17600: Rerun the script to update use statements
Somehow I have the feeling that we are running more frequently against these errors. Something to do with different git versions ? I am using git version 2.1.4 on Jessie. (Should be the default version?)
One patch was not in the correct order. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 --- Comment #44 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Jonathan Druart from comment #43)
(In reply to Marcel de Rooy from comment #40)
Applying: Bug 17600: Rerun the script to update use statements fatal: sha1 information is lacking or useless (C4/Auth_with_shibboleth.pm). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0001 Bug 17600: Rerun the script to update use statements
Somehow I have the feeling that we are running more frequently against these errors. Something to do with different git versions ? I am using git version 2.1.4 on Jessie. (Should be the default version?)
One patch was not in the correct order.
OK. It does apply now. Trying to have a look tomorrow. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 --- Comment #45 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Note that I do not support an inclusion of this patch in 17.05 (too many side-effects possible), but should be pushed at the beginning of the next cycle. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 --- Comment #46 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Jonathan Druart from comment #45)
Note that I do not support an inclusion of this patch in 17.05 (too many side-effects possible), but should be pushed at the beginning of the next cycle.
OK. Postponing QA in that case. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #47 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Applying: Bug 17600: Explicitly export the subroutines used fatal: sha1 information is lacking or useless (C4/Auth_with_cas.pm). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. If it applies Friday morning, I will start with it ;) Just using git 2.1.4 on Jessie.. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62940|0 |1 is obsolete| | Attachment #62941|0 |1 is obsolete| | Attachment #62942|0 |1 is obsolete| | Attachment #62943|0 |1 is obsolete| | Attachment #62958|0 |1 is obsolete| | Attachment #62959|0 |1 is obsolete| | --- Comment #48 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 64387 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64387&action=edit Bug 17600: Standardize our EXPORT_OK On bug 17591 we discovered that there was something weird going on with the way we export and use subroutines/modules. This patch tries to standardize our EXPORT to use EXPORT_OK only. That way we will need to explicitely define the subroutine we want to use from a module. There are still a lot of things to do, it would be good to write a script to do what's need to be done. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 --- Comment #49 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 64388 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64388&action=edit Bug 17600: Remove useless extra spaces Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 --- Comment #50 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 64389 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64389&action=edit Bug 17600: continue replace of EXPORT with EXPORT_OK Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 --- Comment #51 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 64390 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64390&action=edit Bug 17600: Explicitly export the subroutines used This patch is generated using the export.pl script Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 --- Comment #52 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 64391 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64391&action=edit Bug 17600: Rerun the script to update use statements -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 --- Comment #53 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 64392 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64392&action=edit Bug 17600: re-Rerun the script to update use statements -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |ASSIGNED --- Comment #54 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Too many errors "subroutine is not exported by the C4::XXX module" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64387|0 |1 is obsolete| | Attachment #64388|0 |1 is obsolete| | Attachment #64389|0 |1 is obsolete| | Attachment #64390|0 |1 is obsolete| | Attachment #64391|0 |1 is obsolete| | Attachment #64392|0 |1 is obsolete| | --- Comment #55 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 64466 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64466&action=edit Bug 17600: Standardize our EXPORT_OK On bug 17591 we discovered that there was something weird going on with the way we export and use subroutines/modules. This patch tries to standardize our EXPORT to use EXPORT_OK only. That way we will need to explicitely define the subroutine we want to use from a module. There are still a lot of things to do, it would be good to write a script to do what's need to be done. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 --- Comment #56 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 64467 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64467&action=edit Bug 17600: Remove useless extra spaces Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 --- Comment #57 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 64468 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64468&action=edit Bug 17600: continue replace of EXPORT with EXPORT_OK Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 --- Comment #58 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 64469 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64469&action=edit Bug 17600: Explicitly export the subroutines used This patch is generated using the export.pl script Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 --- Comment #59 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 64470 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64470&action=edit Bug 17600: Rerun the script to update use statements -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 --- Comment #60 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 64471 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64471&action=edit Bug 17600: re-Rerun the script to update use statements -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 --- Comment #61 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 64472 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64472&action=edit Bug 17600: Export subroutine from modules -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 --- Comment #62 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 64473 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64473&action=edit Update script to export - export for scripts -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 --- Comment #63 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 64474 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64474&action=edit Bug 17600: Explicitly export the subroutines used - scripts -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 --- Comment #64 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 64475 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64475&action=edit Bug 17600: (follow-up) Explicitly export the subroutines used - scripts manual adjustements -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 --- Comment #65 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 64476 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64476&action=edit Bug 17600: Some more... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #66 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Hard to say if this change is going to bring us more trouble or it is going to help us. I send it to the QA queue to get QAers opinions. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 --- Comment #67 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- - require Exporter; - $debug = $ENV{DEBUG}; - @ISA = qw(Exporter); - @EXPORT_OK = qw(check_api_auth_cas checkpw_cas login_cas logout_cas login_cas_url); -} + require Exporter; + $debug = $ENV{DEBUG}; + @ISA = qw(Exporter); +porter); +RT_OK = qw( +OK = qw( +ultipleAuth +ipleAuth +etMultipleAuth +ipleAuth +ogout_cas +gout_cas Funny things happening here.. It seems that git or qa tools did not like Auth_with_cas ?? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 --- Comment #68 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Auth_with_ldap too btw -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 --- Comment #69 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Well, it seems to be git or git bz that mangles those files. Reapplying patch 0008 triggers the same problem with me. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #70 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Just noting that these patches are in git 2.11.0 and git 2.1.4 apparently does not like them. Too bad :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 --- Comment #71 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Can we rearrange these patches too? All patches that should not be pushed together? 0009? All patches for modules and for scripts or so ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 --- Comment #72 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Marcel de Rooy from comment #71)
Can we rearrange these patches too? All patches that should not be pushed together? 0009? All patches for modules and for scripts or so ?
I am not sure to understand what you mean here. How would you like me to rearrange these patches? Which one is 0009? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off --- Comment #73 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- It is not possible to maintain these patches up-to-date. Here is a remote branch I am not going to rebase every week: https://github.com/joubu/Koha/commits/bug_17600 I will update it when people will be ready to approve this approach. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57954|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64466|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64467|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64468|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64469|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64470|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64471|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64472|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64473|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64474|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64475|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64476|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 --- Comment #74 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Jonathan Druart from comment #72)
(In reply to Marcel de Rooy from comment #71)
Can we rearrange these patches too? All patches that should not be pushed together? 0009? All patches for modules and for scripts or so ?
I am not sure to understand what you mean here. How would you like me to rearrange these patches? Which one is 0009?
That should be the 9th that you obsoleted :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 --- Comment #75 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- I have rebased the branch (tricky!), but I get Undefined subroutine &C4::Items::TransformKohaToMarc called at /home/vagrant/kohaclone/C4/Items.pm line 1491. when I hit /cgi-bin/koha/catalogue/MARCdetail.pl?biblionumber=42 TransformKohaToMarc is exported by C4::Biblio. And it is what we are trying to avoid... Any ideas? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice@biblibre.com --- Comment #76 from Julian Maurice <julian.maurice@biblibre.com> --- (In reply to Jonathan Druart from comment #75)
I have rebased the branch (tricky!), but I get
Undefined subroutine &C4::Items::TransformKohaToMarc called at /home/vagrant/kohaclone/C4/Items.pm line 1491.
when I hit /cgi-bin/koha/catalogue/MARCdetail.pl?biblionumber=42
TransformKohaToMarc is exported by C4::Biblio. And it is what we are trying to avoid...
Any ideas?
Circular dependencies. C4::Biblio use C4::Items which use C4::Biblio; If I comment 'use C4::Items ...' in C4::Biblio, MARCdetail.pl works fine. It seems that this 'use' is not even needed. C4::Items is 'require'd each time it's needed in C4::Biblio. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #77 from Kyle M Hall <kyle@bywatersolutions.com> --- Not sure what's going on here -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off Depends on| |18927 --- Comment #78 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Jonathan Druart from comment #75)
Undefined subroutine &C4::Items::TransformKohaToMarc called at /home/vagrant/kohaclone/C4/Items.pm line 1491.
when I hit /cgi-bin/koha/catalogue/MARCdetail.pl?biblionumber=42
Bug 18927 fixes this issue. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18927 [Bug 18927] koha-rebuild-zebra is failing with "error retrieving biblio" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #79 from Kyle M Hall <kyle@bywatersolutions.com> --- Where did the patches go? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #80 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Kyle M Hall from comment #79)
Where did the patches go?
See comment 73: Here is a remote branch I am not going to rebase every week: https://github.com/joubu/Koha/commits/bug_17600 It is here to get feedback. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply CC| |katrin.fischer@bsz-bw.de --- Comment #81 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Jonathan, could you please rebase your branch on current master? Thx! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |In Discussion --- Comment #82 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Katrin Fischer from comment #81)
Hi Jonathan, could you please rebase your branch on current master? Thx!
See my previous comment, I do not plan to maintain this branch up-to-date. As I did not get the expected feedback it is not longer on my priority list. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=21133 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=8244 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au --- Comment #83 from David Cook <dcook@prosentient.com.au> --- (In reply to Jonathan Druart from comment #75)
See my previous comment, I do not plan to maintain this branch up-to-date. As I did not get the expected feedback it is not longer on my priority list.
I know this is no longer on your priority list, but I'm happy to provide some feedback now that I know this bug exists. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 --- Comment #84 from David Cook <dcook@prosentient.com.au> --- (In reply to Jonathan Druart from comment #75)
I have rebased the branch (tricky!), but I get
Undefined subroutine &C4::Items::TransformKohaToMarc called at /home/vagrant/kohaclone/C4/Items.pm line 1491.
when I hit /cgi-bin/koha/catalogue/MARCdetail.pl?biblionumber=42
TransformKohaToMarc is exported by C4::Biblio. And it is what we are trying to avoid...
Any ideas?
I don't really understand the question here. Based on https://github.com/joubu/Koha/commit/9bbab48f740f1ebcb4c08549622d750b34fe14c..., I'm guessing that you're explicitly importing "TransformKohaToMarc" from C4::Biblio at the top of C4::Items, but you're still getting "Undefined subroutine &C4::Items::TransformKohaToMarc called at
/home/vagrant/kohaclone/C4/Items.pm line 1491."?
I'd need to be able to poke around on the system to know exactly what's going on and I'd have to do some experiments (like dumping %INC and looking at functions by namespace to see what is declared at what time), but... ...wouldn't a solution be just to write C4::Biblio::TransformKohaToMarc? Personally, I think we overuse Exporter.pm. I think moving from EXPORT to EXPORT_OK is a great improvement, but I'm not sure why we export so many functions either. Perhaps because it makes things easier to write, but it makes things harder to read and understand, and it creates issues like these... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |colin.campbell@ptfs-europe. | |com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- URL| |https://gitlab.com/joubu/Ko | |ha/-/tree/bug_17600_new --- Comment #85 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- After Martin's suggestion to have a look at https://metacpan.org/pod/perlimports I had another go at this one. And it seems to work better than my previous attempt. There is a remote branch: https://gitlab.com/joubu/Koha/-/tree/bug_17600_new I am going to attach the patches here but I won't keep them up-to-date. The remote branch must be tested instead. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 --- Comment #86 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 121309 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121309&action=edit Bug 17600: Standardize our EXPORT_OK On bug 17591 we discovered that there was something weird going on with the way we export and use subroutines/modules. This patch tries to standardize our EXPORT to use EXPORT_OK only. That way we will need to explicitely define the subroutine we want to use from a module. There are still a lot of things to do, it would be good to write a script to do what's need to be done. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 --- Comment #87 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 121310 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121310&action=edit Bug 17600: After export.pl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 --- Comment #88 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 121311 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121311&action=edit Bug 17600: After perlimports find . -name '*.pm' -o -name '*.pl' -exec perl App-perlimports/script/perlimports --inplace-edit --no-preserve-unused --filename {} \; -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 --- Comment #89 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 121312 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121312&action=edit Bug 17600: Manual changes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 --- Comment #90 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 121313 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121313&action=edit Bug 17600: after perlimports pm Was missing the pm find . \( -name "*.pl" -o -name "*.pm" \) -exec perl App-perlimports/script/perlimports --inplace-edit --no-preserve-unused --filename {} \; TODO: Restore permissions -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 --- Comment #91 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 121314 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121314&action=edit Bug 17600: Other manual changes after second perlimports run -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_21_11_candidate, | |RM_priority -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121309|0 |1 is obsolete| | Attachment #121310|0 |1 is obsolete| | Attachment #121311|0 |1 is obsolete| | Attachment #121312|0 |1 is obsolete| | Attachment #121313|0 |1 is obsolete| | Attachment #121314|0 |1 is obsolete| | --- Comment #92 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 122360 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122360&action=edit Bug 17600: Standardize our EXPORT_OK On bug 17591 we discovered that there was something weird going on with the way we export and use subroutines/modules. This patch tries to standardize our EXPORT to use EXPORT_OK only. That way we will need to explicitely define the subroutine we want to use from a module. There are still a lot of things to do, it would be good to write a script to do what's need to be done. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 --- Comment #93 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 122361 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122361&action=edit Bug 17600: After export.pl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 --- Comment #94 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 122362 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122362&action=edit Bug 17600: After perlimports find . -name '*.pm' -o -name '*.pl' -exec perl App-perlimports/script/perlimports --inplace-edit --no-preserve-unused --filename {} \; -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 --- Comment #95 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 122363 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122363&action=edit Bug 17600: Manual changes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 --- Comment #96 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 122364 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122364&action=edit Bug 17600: after perlimports pm Was missing the pm find . \( -name "*.pl" -o -name "*.pm" \) -exec perl App-perlimports/script/perlimports --inplace-edit --no-preserve-unused --filename {} \; TODO: Restore permissions -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 --- Comment #97 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 122365 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122365&action=edit Bug 17600: Other manual changes after second perlimports run -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122360|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122361|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122362|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122363|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122364|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122365|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 --- Comment #98 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Please test the remote branch - https://gitlab.com/joubu/Koha/-/tree/bug_17600_new -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 --- Comment #99 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- This remote branch is looking great to me.. it just 'feels cleaner' as a whole. I'm just running the test suit against it locally and playing around a bit to see if I spot any obvious issues now.. Thanks for all the hard work Jonathan! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 --- Comment #100 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- We have the compile test failing at the moment.. I'll try to find a moment to dig further into this.. but I'm not sure when that will happen :( -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 --- Comment #101 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Martin Renvoize from comment #100)
We have the compile test failing at the moment.. I'll try to find a moment to dig further into this.. but I'm not sure when that will happen :(
Fixed! Remote branch updated. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #102 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Joubu> Asking again for the Xth times "Do we need bug 17600 (Standardize the EXPORT) or not?" ashimema> I like it ashimema> and have tested... Joubu> It's now or never, basically ashimema> I'd go for it ashimema> personally Joubu> I don't need stamps on it, only a "go for it" is enough :) Joubu> "I will push it at the beginning of July, regardless of its status, if there is no objection before." Joubu> this is what I actually sent to the QA team a couple of weeks ago Joubu> but I am feeling a bit ashamed to push such big changes with a NSO status Joubu> marcelr, kidclamp, khall, jajm, tcohen, you all agree with that, right? ^ marcelr> Joubu you promised it marcelr> wait and begin of July takes another year khall> go for it marcelr> we have 4 months for cleanup haha Joubu> Thanks, I didn't need more. A short "go" is better than silence ;) jajm> Joubu, go go go! Joubu> I will quote you all on the bug :D ashimema> go :) ashimema> I did do a chunk of testing so take my SO tcohen> Joubu add my stamp tcohen> I tested it in the early ages tcohen> and am sure we can fix whatever arises -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 --- Comment #103 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 122869 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122869&action=edit Bug 17600: Standardize our EXPORT_OK On bug 17591 we discovered that there was something weird going on with the way we export and use subroutines/modules. This patch tries to standardize our EXPORT to use EXPORT_OK only. That way we will need to explicitely define the subroutine we want to use from a module. This patch is a squashed version of: Bug 17600: After export.pl Bug 17600: After perlimport Bug 17600: Manual changes Bug 17600: Other manual changes after second perlimports run Bug 17600: Fix tests And a lot of other manual changes. export.pl is a dirty script that can be found on bug 17600. "perlimport" is: git clone https://github.com/oalders/App-perlimports.git cd App-perlimports/ cpanm --installdeps . export PERL5LIB="$PERL5LIB:/kohadevbox/koha/App-perlimports/lib" find . \( -name "*.pl" -o -name "*.pm" \) -exec perl App-perlimports/script/perlimports --inplace-edit --no-preserve-unused --filename {} \; The ideas of this patch are to: * use EXPORT_OK instead of EXPORT * perltidy the EXPORT_OK list * remove '&' before the subroutine names * remove some uneeded use statements * explicitely import the subroutines we need within the controllers or modules Note that the private subroutines (starting with _) should not be exported (and not used from outside of the module except from tests). EXPORT vs EXPORT_OK (from https://www.thegeekstuff.com/2010/06/perl-exporter-examples/) """ Export allows to export the functions and variables of modules to user’s namespace using the standard import method. This way, we don’t need to create the objects for the modules to access it’s members. @EXPORT and @EXPORT_OK are the two main variables used during export operation. @EXPORT contains list of symbols (subroutines and variables) of the module to be exported into the caller namespace. @EXPORT_OK does export of symbols on demand basis. """ If this patch caused a conflict with a patch you wrote prior to its push: * Make sure you are not reintroducing a "use" statement that has been removed * "$subroutine" is not exported by the C4::$MODULE module means that you need to add the subroutine to the @EXPORT_OK list * Bareword "$subroutine" not allowed while "strict subs" means that you didn't imported the subroutine from the module: - use $MODULE qw( $subroutine list ); You can also use the fully qualified namespace: C4::$MODULE::$subroutine Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.11.00 released in| | Status|Passed QA |Pushed to master --- Comment #104 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Patch pushed to master for 21.11.00 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 --- Comment #105 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 122884 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122884&action=edit Bug 17600: Fix tests No idea why UpdateStats in C4::Circulation needs the fully qualified namespace! I kept getting Undefined subroutine &C4::Circulation::UpdateStats called at /kohadevbox/koha/C4/Circulation.pm line 1643. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to master |CLOSED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 --- Comment #106 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 122945 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122945&action=edit Bug 17600: Fix batchMod.pl Undefined subroutine &CGI::Compile::ROOT::kohadevbox_koha_tools_batchMod_2epl::haspermission called at /kohadevbox/koha/tools/batchMod.pl line 89 Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 --- Comment #107 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Follow-ups have been pushed to master. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28722 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28722 [Bug 28722] tools/batchMod.pl needs to import C4::Ath::haspermission -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28731 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28731 [Bug 28731] Subroutines not explicitly imported in reports svc (opac and staff) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 --- Comment #108 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Just wondering about the implications of this as I did some easy rebases today. Should we ask for new use statements always having the methods used added with qw? Should there be a coding guideline/QA test? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 --- Comment #109 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- [WARN] Prototype mismatch: sub Koha::I18N::LC_MESSAGES: none vs () at /usr/share/koha/Koha/I18N.pm line 36. Locale::Messages exports a sub LC_MESSAGES without prototype. And after we do 'use POSIX;' with a default import that probably includes LC_MESSAGES from locale_h ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28758 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28758 [Bug 28758] Undefined subroutines in C4/ImportBatch.pm (bug 17600) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28750 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28750 [Bug 28750] Undefined subroutines in svc/cataloguing/framework (caused by bug 17600) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 --- Comment #110 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 123194 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123194&action=edit Bug 17600: Fix other occurrences in svc -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 --- Comment #111 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Jonathan Druart from comment #110)
Created attachment 123194 [details] [review] Bug 17600: Fix other occurrences in svc
Patch pushed to master. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 --- Comment #112 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 123195 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123195&action=edit Bug 17600: Fix wrong import in Koha::I18N - LC_MESSAGES $ perl -wc Koha/I18N.pm Subroutine Koha::I18N::LC_MESSAGES redefined at Koha/I18N.pm line 36. Prototype mismatch: sub Koha::I18N::LC_MESSAGES: none vs () at Koha/I18N.pm line 36. Koha/I18N.pm syntax OK -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 --- Comment #113 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Jonathan Druart from comment #112)
Created attachment 123195 [details] [review] Bug 17600: Fix wrong import in Koha::I18N - LC_MESSAGES
$ perl -wc Koha/I18N.pm Subroutine Koha::I18N::LC_MESSAGES redefined at Koha/I18N.pm line 36. Prototype mismatch: sub Koha::I18N::LC_MESSAGES: none vs () at Koha/I18N.pm line 36. Koha/I18N.pm syntax OK
Patch pushed to master. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 --- Comment #114 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Katrin Fischer from comment #108)
Just wondering about the implications of this as I did some easy rebases today. Should we ask for new use statements always having the methods used added with qw? Should there be a coding guideline/QA test?
I've tried to explain in the commit message. Basically you need to 1. Use EXPORT_OK instead of EXPORT in modules 2. either use Module qw( method_1 method_2 ); method_1(); or use Module; Module::method_1(); Ideally we should pick one version and stick to that. But there is still a mix of both everywhere in the codebase. We don't really need a guideline because: - We must not add new modules to C4 - The EXPORT_OK should be there now, so you have to write the imports/calls correctly of the execution will explode. (In reply to Marcel de Rooy from comment #109)
[WARN] Prototype mismatch: sub Koha::I18N::LC_MESSAGES: none vs () at /usr/share/koha/Koha/I18N.pm line 36.
Locale::Messages exports a sub LC_MESSAGES without prototype. And after we do 'use POSIX;' with a default import that probably includes LC_MESSAGES from locale_h ?
Last patch fixes that. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 --- Comment #115 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Jonathan Druart from comment #113)
(In reply to Jonathan Druart from comment #112)
Created attachment 123195 [details] [review] [review] Bug 17600: Fix wrong import in Koha::I18N - LC_MESSAGES
$ perl -wc Koha/I18N.pm Subroutine Koha::I18N::LC_MESSAGES redefined at Koha/I18N.pm line 36. Prototype mismatch: sub Koha::I18N::LC_MESSAGES: none vs () at Koha/I18N.pm line 36. Koha/I18N.pm syntax OK
Patch pushed to master.
This is totally wrong, we do want to import LC_MESSAGES from Locale::Messages. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 --- Comment #116 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 123196 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123196&action=edit Bug 17600: (follow-up) Fix wrong import in Koha::I18N - LC_MESSAGES -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 --- Comment #117 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Jonathan Druart from comment #116)
Created attachment 123196 [details] [review] Bug 17600: (follow-up) Fix wrong import in Koha::I18N - LC_MESSAGES
Can I get a review on that patch please, before I push it and continue to mess up with things. I think this fixes a problem we had prior to this patch (to confirm!). Both Locale::Messages and POSIX are exporting LC_MESSAGES. As we explicitly imported LC_MESSAGES from Locale::Messages I guess it's what we wanted to do, but POSIX exported it as well and it's the one we got (it's after Locale::Messages in the use sequence). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 --- Comment #118 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 123200 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123200&action=edit Bug 17600: Fix t/db_dependent/Members.t Was failing after "Bug 17600: Fix other occurrences in svc" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 --- Comment #119 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Jonathan Druart from comment #114)
(In reply to Katrin Fischer from comment #108)
Just wondering about the implications of this as I did some easy rebases today. Should we ask for new use statements always having the methods used added with qw? Should there be a coding guideline/QA test?
I've tried to explain in the commit message. Basically you need to 1. Use EXPORT_OK instead of EXPORT in modules 2. either use Module qw( method_1 method_2 ); method_1();
or use Module; Module::method_1();
Probably you still need to differentiate between Koha modules and external CPAN stuff? The use Module statement does still try to import names. If you do 'use Module ()' with empty list, you do NOT import anymore. Actually, you only 'require'. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 --- Comment #120 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Jonathan Druart from comment #117)
(In reply to Jonathan Druart from comment #116)
Created attachment 123196 [details] [review] [review] Bug 17600: (follow-up) Fix wrong import in Koha::I18N - LC_MESSAGES
Can I get a review on that patch please, before I push it and continue to mess up with things.
I think this fixes a problem we had prior to this patch (to confirm!). Both Locale::Messages and POSIX are exporting LC_MESSAGES. As we explicitly imported LC_MESSAGES from Locale::Messages I guess it's what we wanted to do, but POSIX exported it as well and it's the one we got (it's after Locale::Messages in the use sequence).
I will try. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28763 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28763 [Bug 28763] Undefined subroutine XSLTParse4Display when viewing lists (bug 17600) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123196|0 |1 is obsolete| | --- Comment #121 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 123210 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123210&action=edit Bug 17600: (follow-up) Fix wrong import in Koha::I18N - LC_MESSAGES Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 --- Comment #122 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Jonathan Druart from comment #117)
(In reply to Jonathan Druart from comment #116)
Created attachment 123196 [details] [review] [review] Bug 17600: (follow-up) Fix wrong import in Koha::I18N - LC_MESSAGES
Can I get a review on that patch please, before I push it and continue to mess up with things.
I think this fixes a problem we had prior to this patch (to confirm!). Both Locale::Messages and POSIX are exporting LC_MESSAGES. As we explicitly imported LC_MESSAGES from Locale::Messages I guess it's what we wanted to do, but POSIX exported it as well and it's the one we got (it's after Locale::Messages in the use sequence).
Looks good to me now. Have the impression that both constants return the same for me.. But when you look at Locale::Messages, this is the way it should be. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 --- Comment #123 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Marcel de Rooy from comment #121)
Created attachment 123210 [details] [review] Bug 17600: (follow-up) Fix wrong import in Koha::I18N - LC_MESSAGES
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Patch pushed to master. Thanks, Marcel! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 --- Comment #124 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 123281 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123281&action=edit Bug 17600: Fix POSIX imports it fixes xgettext and (maybe) friends [12:22:29] Error: Command failed: misc/translator/xgettext.pl --charset=UTF-8 -s -o /tmp/koha-Jaa9rf/Koha-marc-NORMARC.pot -f /tmp/koha-Jaa9rf/files /tmp/koha-Jaa9rf/Koha-marc-NORMARC.pot at misc/translator/xgettext.pl line 387. Use of uninitialized value in subroutine entry at misc/translator/xgettext.pl line 388. Argument ">:encoding(utf-8)" isn't numeric in subroutine entry at misc/translator/xgettext.pl line 388. Argument "/tmp/koha-Jaa9rf/Koha-marc-NORMARC.pot" isn't numeric in subroutine entry at misc/translator/xgettext.pl line 388. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 --- Comment #125 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Last patch pushed to master. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 --- Comment #126 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 123283 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123283&action=edit Bug 17600: (follow-up) Import GetAuthority in rebuild_zebra -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 --- Comment #127 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 123284 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123284&action=edit Bug 17600: Fix missing C4::AuthoritiesMARC import -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 --- Comment #128 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Last 2 patches pushed to master. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 --- Comment #129 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 123325 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123325&action=edit Bug 17600: (follow-up) Fully qualify routine in cancel_expired_holds.pl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 --- Comment #130 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Patch pushed to master, thanks Nick! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 --- Comment #131 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 123417 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123417&action=edit Bug 17600: Fix GetTagsLabels imports -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 --- Comment #132 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Last patch pushed to master. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 --- Comment #133 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 123418 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123418&action=edit Bug 17600: Add missing imports in authorities/ -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123418|0 |1 is obsolete| | --- Comment #134 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 123419 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123419&action=edit Bug 17600: Add missing imports in authorities/ -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123419|0 |1 is obsolete| | --- Comment #135 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 123420 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123420&action=edit Bug 17600: Add missing imports in authorities/ Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 --- Comment #136 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Nick Clemens from comment #135)
Created attachment 123420 [details] [review] Bug 17600: Add missing imports in authorities/
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Pushed to master. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 --- Comment #137 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 123565 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123565&action=edit Bug 17600: Fix missing imports from mappings.pl Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 --- Comment #138 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Jonathan Druart from comment #137)
Created attachment 123565 [details] [review] Bug 17600: Fix missing imports from mappings.pl
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Pushed to master. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28931 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28931 [Bug 28931] use EXPORT_OK in Koha::DateUtils -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 --- Comment #139 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 124866 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124866&action=edit Bug 17600: Fix opac/svc/overdrive -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 --- Comment #140 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Jonathan Druart from comment #139)
Created attachment 124866 [details] [review] Bug 17600: Fix opac/svc/overdrive
Pushed to master. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 --- Comment #141 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 125059 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125059&action=edit Bug 17600: Remove wrong C4::Context imports -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 --- Comment #142 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Jonathan Druart from comment #141)
Created attachment 125059 [details] [review] Bug 17600: Remove wrong C4::Context imports
Pushed to master. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 --- Comment #143 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 125063 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125063&action=edit Bug 17600: (follow-up) Fix overdrive proxy -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125063|0 |1 is obsolete| | --- Comment #144 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 125064 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125064&action=edit Bug 17600: (follow-up) Fix overdrive_proxy recordedbooks -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125064|0 |1 is obsolete| | --- Comment #145 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 125066 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125066&action=edit Bug 17600: Fix overdrive_proxy and recordedbooks -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_21_11_candidate, | |RM_priority | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29197 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29197 [Bug 29197] commit_file.pl missing import -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 Peter Vashchuk <stalkernoid@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=29207 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29207 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29207 [Bug 29207] Restore Getopt::Long config to not ignore cases -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 --- Comment #146 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 126640 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126640&action=edit Bug 17600: Fix imports for svc/letters/preview -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 --- Comment #147 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Last patches pushed to master. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 --- Comment #148 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 127056 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127056&action=edit Bug 17600: Fix imports for GetClassSources in guided_reports.pl This will fix the broken option to use cn_source as a runtime parameter, e.g. <<Call no. source|cn_source>> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29351 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29351 [Bug 29351] Add missing cn_source parameter to reports parameter menu -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|FIXED |--- Status|CLOSED |REOPENED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed | --- Comment #149 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Owen Leonard from comment #148)
Created attachment 127056 [details] [review] Bug 17600: Fix imports for GetClassSources in guided_reports.pl
This will fix the broken option to use cn_source as a runtime parameter, e.g. <<Call no. source|cn_source>>
Pushed to master, thanks Owen! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|REOPENED |RESOLVED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29395 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29395 [Bug 29395] Use EXPORT_OK in Koha::Patron::Debarments -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 Joonas Kylmälä <joonas.kylmala@iki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29429 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29429 [Bug 29429] Cannot close budgets -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29435 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29435 [Bug 29435] OPAC authority details page broken when AuthDisplayHierarchy is enabled -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29469 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29469 [Bug 29469] Error when approving and rejecting tags -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |We favored the use of release notes| |EXPORT_OK over EXPORT, to | |prevent name clashes and | |make the import explicit. Keywords|release-notes-needed | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 --- Comment #150 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 127918 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127918&action=edit Bug 17600: Fix opac/unapi -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 --- Comment #151 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Jonathan Druart from comment #150)
Created attachment 127918 [details] [review] Bug 17600: Fix opac/unapi
Pushed to master. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29865 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29865 [Bug 29865] Wrong includes in circ/returns.pl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |30426 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30426 [Bug 30426] suggestion service missing Auth and Output imports -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |30461 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30461 [Bug 30461] Batch authority tool is broken -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |30402 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30402 [Bug 30402] Authority import hanging when replacing matched record -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |30926 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30926 [Bug 30926] Remove unnecessary use statements -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31058 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31058 [Bug 31058] Bug 17600 follow-up - fix import in auto_unsuspend_holds -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |30939 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30939 [Bug 30939] remove_unused_authorities.pl is broken -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29951 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29951 [Bug 29951] Cannot add splitting rule to classification sources -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33937 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33937 [Bug 33937] Incorrect export in C4::Members -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |36787 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36787 [Bug 36787] staticfines.pl missing use Koha::DateUtils::output_pref -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |38000 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38000 [Bug 38000] Redundant code import in search.pl -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org