https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21487 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=10326 --- Comment #1 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Same has Bug 10326 for bulkmarcimport.pl -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21487 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21487 --- Comment #2 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Created attachment 79949 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79949&action=edit Bug 21487: Disable CataloguingLog syspref in UNIMARC_sync_date_created_with_marc_biblio.pl Script UNIMARC_sync_date_created_with_marc_biblio.pl edits MARC record to define 099 $c and $d. This should not be registered as a cataloguing change in action_logs table. So script must disable CataloguingLog syspref (if enabled) during its process. Test plan : 1) Don't apply the patch yet 2) Have the CataloguingLog system preference set to 'Log' 3) Create a new record 4) Count entries in action_logs table 5) Run : UNIMARC_sync_date_created_with_marc_biblio.pl --run -v 6) Check the CataloguingLog system preference is still 'Log' 7) Count entries in action_logs table => there are more 8) Apply the patch 9) Repeate from 3) to 6) 10) Count entries in action_logs table => there are the same -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21487 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #79949|0 |1 is obsolete| | --- Comment #3 from David Nind <david@davidnind.com> --- Created attachment 80156 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80156&action=edit Bug 21487: Disable CataloguingLog syspref in UNIMARC_sync_date_created_with_marc_biblio.pl Script UNIMARC_sync_date_created_with_marc_biblio.pl edits MARC record to define 099 $c and $d. This should not be registered as a cataloguing change in action_logs table. So script must disable CataloguingLog syspref (if enabled) during its process. Test plan : 1) Don't apply the patch yet 2) Have the CataloguingLog system preference set to 'Log' 3) Create a new record 4) Count entries in action_logs table 5) Run : UNIMARC_sync_date_created_with_marc_biblio.pl --run -v 6) Check the CataloguingLog system preference is still 'Log' 7) Count entries in action_logs table => there are more 8) Apply the patch 9) Repeate from 3) to 6) 10) Count entries in action_logs table => there are the same Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21487 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80156|0 |1 is obsolete| | --- Comment #4 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 80241 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80241&action=edit Bug 21487: Disable CataloguingLog syspref in UNIMARC_sync_date_created_with_marc_biblio.pl Script UNIMARC_sync_date_created_with_marc_biblio.pl edits MARC record to define 099 $c and $d. This should not be registered as a cataloguing change in action_logs table. So script must disable CataloguingLog syspref (if enabled) during its process. Test plan : 1) Don't apply the patch yet 2) Have the CataloguingLog system preference set to 'Log' 3) Create a new record 4) Count entries in action_logs table 5) Run : UNIMARC_sync_date_created_with_marc_biblio.pl --run -v 6) Check the CataloguingLog system preference is still 'Log' 7) Count entries in action_logs table => there are more 8) Apply the patch 9) Repeate from 3) to 6) 10) Count entries in action_logs table => there are the same Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21487 --- Comment #6 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- (In reply to Nick Clemens from comment #5)

This follows the same pattern as batchRebuildItemsTables, however, we have found this can cause problems if the script is disrupted or errors halfway through (DB and cache have differing values and they aren't fixed until a cache is restarted)

I would prefer to see something like bug 18816 - add a parameter to the functions that are logged to allow preventing that, rather than altering sysprefs

I agree, I'll try to find time for that. Any help is welcomed. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21487 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Disable CataloguingLog |Add option to disable |syspref in |CataloguingLog syspref in |UNIMARC_sync_date_created_w |UNIMARC_sync_date_created_w |ith_marc_biblio.pl |ith_marc_biblio.pl Status|In Discussion |ASSIGNED CC| |katrin.fischer@bsz-bw.de --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Changing out of discussion - I think agreement to add a parameter was reached. -- You are receiving this mail because: You are watching all bug changes.