https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26268 --- Comment #1 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 108797 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108797&action=edit Bug 26268: Remove items.paidfor from the database In bug 19919 we removed all references to setting, unsettling and referring to the paidfor field but we neglected to actually drop the field from the database (I think I intended to do this, but was asking for feedback on the approach before adding the actual db change.. then completely forgot when it went through SO/QA quickly). In bug 23463 we inadvertently re-introduced some of the setting code during a rebase. In bug 18501 we then moved that inadvertently re-introduced setter into Koha::Item->store. We should kill it off once and for all! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26268 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26268 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org, | |nick@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26268 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26268 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #108797|0 |1 is obsolete| | --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 108808 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108808&action=edit Bug 26268: Remove items.paidfor from the database In bug 19919 we removed all references to setting, unsettling and referring to the paidfor field but we neglected to actually drop the field from the database (I think I intended to do this, but was asking for feedback on the approach before adding the actual db change.. then completely forgot when it went through SO/QA quickly). In bug 23463 we inadvertently re-introduced some of the setting code during a rebase. In bug 18501 we then moved that inadvertently re-introduced setter into Koha::Item->store. We should kill it off once and for all! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26268 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #108807|0 |1 is obsolete| | --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 108810 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108810&action=edit Bug 26268: Remove marc framework mappings to items.paidfor Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26268 --- Comment #8 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- (In reply to Kyle M Hall from comment #3)

if( !column_exists( 'biblio', 'biblionumber' ) ) {

Doh! Fixed now -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26268 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #108808|0 |1 is obsolete| | Attachment #108809|0 |1 is obsolete| | Attachment #108810|0 |1 is obsolete| | --- Comment #9 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 108812 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108812&action=edit Bug 26268: Remove items.paidfor from the database In bug 19919 we removed all references to setting, unsettling and referring to the paidfor field but we neglected to actually drop the field from the database (I think I intended to do this, but was asking for feedback on the approach before adding the actual db change.. then completely forgot when it went through SO/QA quickly). In bug 23463 we inadvertently re-introduced some of the setting code during a rebase. In bug 18501 we then moved that inadvertently re-introduced setter into Koha::Item->store. We should kill it off once and for all! Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26268 --- Comment #11 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 108814 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108814&action=edit Bug 26268: Remove marc framework mappings to items.paidfor Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26268 --- Comment #13 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- (In reply to Katrin Fischer from comment #12)

I see that there is a lot of history here, but I am not quite following yet.

1) Before dropping the column: Did we move the information stored there in previous developments?

Nope, we didn't drop the data.. we just started using the fields it used to be populated by inconsistently to construct the display on on the fly. The data in the field is no longer maintained and historically wasn't accurate so I think we should be OK to drop it regardless.

If we didn't, we might just want to print a warning if there is any content to be found in the db and ask people to drop themselves. It has been done in the past with some of the columns in borrowers (ethnicity?) I think. If there is no data, we can drop it in the update.

2) Looking for "paidfor" I found some more references this patch is not taking care of:

As noted above, this is where we now construct the data on the fly. `$item->{paidfor} = { patron => $patron, created_on => $payment_offset->created_on }` is an assignment for the template rather than a getter or setter for the DB data.

catalogue/moredetail.pl: # Add paidfor info catalogue/moredetail.pl: $item->{paidfor} = { patron => $patron, created_on => $payment_offset->created_on };

koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/moredetail.tt: [% IF ( ITEM_DAT.paidfor ) %]<li><span class="label">Paid for?:</span> [% INCLUDE 'patron-title.inc' patron=ITEM_DAT.paidfor.patron hide_patron_infos_if_needed=1 %] on [% ITEM_DAT.paidfor.created_on | $KohaDates %]</li>[% END %]

-- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26268 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #108812|0 |1 is obsolete| | --- Comment #15 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 109674 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109674&action=edit Bug 26268: Remove items.paidfor from the database In bug 19919 we removed all references to setting, unsettling and referring to the paidfor field but we neglected to actually drop the field from the database (I think I intended to do this, but was asking for feedback on the approach before adding the actual db change.. then completely forgot when it went through SO/QA quickly). In bug 23463 we inadvertently re-introduced some of the setting code during a rebase. In bug 18501 we then moved that inadvertently re-introduced setter into Koha::Item->store. We should kill it off once and for all! Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26268 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #108814|0 |1 is obsolete| | --- Comment #17 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 109676 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109676&action=edit Bug 26268: Remove marc framework mappings to items.paidfor Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26268 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #19 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Good catch, corrected in the followup (which should probably be merged on push, but kept it separate to keep it clear the work has been done). -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26268 --- Comment #21 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Julian Maurice from comment #20)

Sorry, but I think there is still one thing missing : the updatedatabase should take care of removing any remaining reference to 'items.paidfor' in marc_subfield_structure

Hm, I think that could be an issue we haven't thought about yet. For a long time there was not column for internal note in items and the default mapping we shipped Koha with mapped 952$x to items.paidfor. I think this is another reason not to drop the data if the column still contains information and to only output a note. And we shoudl not remove the mapping. If people have not actively remapped (which requires server action etc.) they might still store the internal note there. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26268 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109674|0 |1 is obsolete| | --- Comment #23 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 109930 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109930&action=edit Bug 26268: Remove items.paidfor from the database In bug 19919 we removed all references to setting, unsettling and referring to the paidfor field but we neglected to actually drop the field from the database (I think I intended to do this, but was asking for feedback on the approach before adding the actual db change.. then completely forgot when it went through SO/QA quickly). In bug 23463 we inadvertently re-introduced some of the setting code during a rebase. In bug 18501 we then moved that inadvertently re-introduced setter into Koha::Item->store. We should kill it off once and for all! Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26268 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109676|0 |1 is obsolete| | --- Comment #25 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 109932 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109932&action=edit Bug 26268: Remove marc framework mappings to items.paidfor Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26268 --- Comment #27 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 109934 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109934&action=edit Bug 26268: (QA follow-up) Conditionally remove This patch adds conditions to prevent the removal of items.paidfor if it is populated and also adds the removal fo the marc_subfield_structure row if it exists. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26268 --- Comment #28 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Follow-up added, back to NQA -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26268 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109931|0 |1 is obsolete| | --- Comment #30 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 110802 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110802&action=edit Bug 26268: Remove final references to paidfor db field Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26268 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109934|0 |1 is obsolete| | --- Comment #32 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 110804 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110804&action=edit Bug 26268: (QA follow-up) Conditionally remove This patch adds conditions to prevent the removal of items.paidfor if it is populated and also adds the removal fo the marc_subfield_structure row if it exists. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26268 --- Comment #34 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 110806 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110806&action=edit Bug 26268: Remove invalid mappings from MARC frameworks when items.paidfor is removed Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26268 --- Comment #35 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Martin, 952$x is the internal note field that was mapped to items.paidfor in the past before we added a proper column for it: itemsnotes_nonpublic. In some frameworks the old mappings had survived, but we only want to correct the mapping, not remove the subfield leaving these languages with no internal note field in their items. So I made some changes: - I killed your patch changing the framework files as you deleted the 952$x lines instead of just correcting the mapping. I replaced it by a follow-up patch - it was just a little easier this way. - I changed your database update. If the column items.paidfor is successfully removed, we don't care which field was mapped to it - we want to reset it as it's now an invalid mapping. Can you please have a look at my follow-ups and sign-off/PQA if you agree? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26268 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #110802|0 |1 is obsolete| | --- Comment #37 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 110837 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110837&action=edit Bug 26268: Remove final references to paidfor db field Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26268 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #110804|0 |1 is obsolete| | --- Comment #39 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 110839 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110839&action=edit Bug 26268: (QA follow-up) Conditionally remove This patch adds conditions to prevent the removal of items.paidfor if it is populated and also adds the removal fo the marc_subfield_structure row if it exists. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26268 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #110806|0 |1 is obsolete| | --- Comment #41 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 110841 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110841&action=edit Bug 26268: Remove invalid mappings from MARC frameworks when items.paidfor is removed Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26268 --- Comment #43 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 110935 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110935&action=edit Bug 26268: Fix deleteditems query in DB rev -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26268 --- Comment #44 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26268 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |The `paid` field in the release notes| |`items` table is removed | |with this patch to prevent | |accidental re-introduction | |of syncing code and | |overhead. The only place | |where the value is surfaced | |in the UI has been replaced | |with an on-demand | |calculated value. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26268 Rebecca Coert <rcoert@arlingtonva.us> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rcoert@arlingtonva.us -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26268 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |34063 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34063 [Bug 34063] items.paidfor haunting beyond the grave -- You are receiving this mail because: You are watching all bug changes.