[Bug 34954] New: Typo: datexpiry
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34954 Bug ID: 34954 Summary: Typo: datexpiry Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: magnus@libriotech.no QA Contact: testopia@bugs.koha-community.org $ grep -rn --exclude=*.po "datexpiry" * grep: how-to.pl: No such file or directory koha-tmpl/intranet-tmpl/prog/en/modules/tools/import_borrowers.tt:321: <option value="">using the datexpiry value in the file, if present</option> koha-tmpl/intranet-tmpl/prog/nb-NO/modules/tools/import_borrowers.tt:312: <option value="">using the datexpiry value in the file, if present</option> misc/release_notes/release_notes_18_05_00.html:792:<li><a href="http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20145">[20145]</a> borrowers.datexpiry eq '0000-00-00' means expired?</li> misc/release_notes/release_notes_18_05_00.md:629:- [[20145]](http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20145) borrowers.datexpiry eq '0000-00-00' means expired? t/db_dependent/Koha/Patrons/Import.t:1204: "Expiration date is correct with update_dateexpiry = true no dateexpiry in file and update_datexpiryfromtoday false (i.e. use passed dateenrolled) " t/db_dependent/Koha/Patrons/Import.t:1217: "Expiration date is correct with update_dateexpiry = true no dateexpiry in file and update_datexpiryfromtoday true " t/db_dependent/Koha/Patrons/Import.t:1231: "Expiration date is correct with update_dateexpiry = true no dateexpiry in file and update_datexpiryfromtoday false but no dateenrolled in file (today is used) " "dateexpiry" is used everywhere else. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34954 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34954 --- Comment #1 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Created attachment 157476 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157476&action=edit Bug 34954: Fixed typo to 'dateexpiry' To test: 1. In KTD use grep -rn --exclude=*.po "datexpiry" * 2. Notice that the four locations below are showing the typo: 1. git add koha-tmpl/intranet-tmpl/prog/en/modules/tools/import_borrowers.tt 2. git add misc/release_notes/release_notes_18_05_00.html 3. git add misc/release_notes/release_notes_18_05_00.md 4. git add t/db_dependent/Koha/Patrons/Import.t 3. Apply patch. Repeat step 1. 4. Notice that no results show. All instances of the typo have been fixed to dateexpiry. 5. Sign off and have a great day :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34954 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff CC| |Laura.escamilla@bywatersolu | |tions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34954 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |Laura.escamilla@bywatersolu | |tions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34954 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34954 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #157476|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 157556 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157556&action=edit Bug 34954: Fixed typo to 'dateexpiry' To test: 1. In KTD use grep -rn --exclude=*.po "datexpiry" * 2. Notice that the four locations below are showing the typo: 1. git add koha-tmpl/intranet-tmpl/prog/en/modules/tools/import_borrowers.tt 2. git add misc/release_notes/release_notes_18_05_00.html 3. git add misc/release_notes/release_notes_18_05_00.md 4. git add t/db_dependent/Koha/Patrons/Import.t 3. Apply patch. Repeat step 1. 4. Notice that no results show. All instances of the typo have been fixed to dateexpiry. 5. Sign off and have a great day :) Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34954 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Severity|enhancement |trivial -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34954 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34954 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34954 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #157556|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 157568 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157568&action=edit Bug 34954: Fixed typo to 'dateexpiry' To test: 1. In KTD use grep -rn --exclude=*.po "datexpiry" * 2. Notice that the four locations below are showing the typo: 1. git add koha-tmpl/intranet-tmpl/prog/en/modules/tools/import_borrowers.tt 2. git add misc/release_notes/release_notes_18_05_00.html 3. git add misc/release_notes/release_notes_18_05_00.md 4. git add t/db_dependent/Koha/Patrons/Import.t 3. Apply patch. Repeat step 1. 4. Notice that no results show. All instances of the typo have been fixed to dateexpiry. 5. Sign off and have a great day :) Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34954 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34954 --- Comment #4 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34954 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Status|Pushed to master |Pushed to stable Version(s)|23.11.00 |23.11.00,23.05.06 released in| | --- Comment #5 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 23.05.x for 23.05.06 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34954 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable Version(s)|23.11.00,23.05.06 |23.11.00,23.05.06,22.11.12 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34954 --- Comment #6 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Nice work everyone! Pushed to oldstable for 22.11.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org