[Bug 34966] New: Terminology: Item add form - "Add & duplicate" should be "Add and duplicate"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34966 Bug ID: 34966 Summary: Terminology: Item add form - "Add & duplicate" should be "Add and duplicate" Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Cataloging Assignee: koha-bugs@lists.koha-community.org Reporter: david@davidnind.com QA Contact: testopia@bugs.koha-community.org CC: m.de.rooy@rijksmuseum.nl In our terminology guide, & should only be used when it is part of a proper noun or a common abbreviation: https://wiki.koha-community.org/wiki/Terminology The add item form in the staff interface incorrectly use "Add & duplicate" (New
New item).
To replicate: 1. In the staff interface, search for and select a record. 2. Select New > New item. 3. Note that "Add & duplicate" is one of the action buttons at the bottom of the add item form. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34966 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy Assignee|koha-bugs@lists.koha-commun |david@davidnind.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34966 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34966 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34966 --- Comment #1 from David Nind <david@davidnind.com> --- Created attachment 156435 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156435&action=edit Bug 34966: Terminology - fix add item form (& to and) This patch updates the add item form in the staff interface to change the 'Add & duplicate' button to 'Add and duplicate'. In our terminology guide, & should only be used when it is part of a proper noun or a common abbreviation: https://wiki.koha-community.org/wiki/Terminology Test plan: 1. In the staff interface, search for and select a record. 2. Select New > New item. 3. Note that "Add & duplicate" is one of the action buttons at the bottom of the add item form. 4. Apply the patch. 5. Refresh the page. 6. Note that the action button is now labelled 'Add and duplicate'. 7. Sign off! 8-) Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34966 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This updates the add item release notes| |form in the staff interface | |to | |change the 'Add & | |duplicate' button to 'Add | |and duplicate'. (As per the | |terminology guidelines | |https://wiki.koha-community | |.org/wiki/Terminology) Summary|Terminology: Item add form |Terminology: Add item form |- "Add & duplicate" should |- "Add & duplicate" should |be "Add and duplicate" |be "Add and duplicate" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34966 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #156435|0 |1 is obsolete| | --- Comment #2 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 157063 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157063&action=edit Bug 34966: Terminology - fix add item form (& to and) This patch updates the add item form in the staff interface to change the 'Add & duplicate' button to 'Add and duplicate'. In our terminology guide, & should only be used when it is part of a proper noun or a common abbreviation: https://wiki.koha-community.org/wiki/Terminology Test plan: 1. In the staff interface, search for and select a record. 2. Select New > New item. 3. Note that "Add & duplicate" is one of the action buttons at the bottom of the add item form. 4. Apply the patch. 5. Refresh the page. 6. Note that the action button is now labelled 'Add and duplicate'. 7. Sign off! 8-) Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katariina Hanhisalo <katariina.hanhisalo@xamk.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34966 Katariina Hanhisalo <katariina.hanhisalo@xamk.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katariina.hanhisalo@xamk.fi Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34966 Biblibre Sandboxes <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #157063|0 |1 is obsolete| | --- Comment #3 from Biblibre Sandboxes <sandboxes@biblibre.com> --- Created attachment 157066 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157066&action=edit Bug 34966: Terminology - fix add item form (& to and) This patch updates the add item form in the staff interface to change the 'Add & duplicate' button to 'Add and duplicate'. In our terminology guide, & should only be used when it is part of a proper noun or a common abbreviation: https://wiki.koha-community.org/wiki/Terminology Test plan: 1. In the staff interface, search for and select a record. 2. Select New > New item. 3. Note that "Add & duplicate" is one of the action buttons at the bottom of the add item form. 4. Apply the patch. 5. Refresh the page. 6. Note that the action button is now labelled 'Add and duplicate'. 7. Sign off! 8-) Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katariina Hanhisalo <katariina.hanhisalo@xamk.fi> Signed-off-by: Reetta Pihlaja <reetta.pihlaja@siilinjarvi.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34966 --- Comment #4 from David Nind <david@davidnind.com> --- Thanks Katariina and Reetta for signing off! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34966 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34966 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34966 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #157066|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 157152 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157152&action=edit Bug 34966: Terminology - fix add item form (& to and) This patch updates the add item form in the staff interface to change the 'Add & duplicate' button to 'Add and duplicate'. In our terminology guide, & should only be used when it is part of a proper noun or a common abbreviation: https://wiki.koha-community.org/wiki/Terminology Test plan: 1. In the staff interface, search for and select a record. 2. Select New > New item. 3. Note that "Add & duplicate" is one of the action buttons at the bottom of the add item form. 4. Apply the patch. 5. Refresh the page. 6. Note that the action button is now labelled 'Add and duplicate'. 7. Sign off! 8-) Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katariina Hanhisalo <katariina.hanhisalo@xamk.fi> Signed-off-by: Reetta Pihlaja <reetta.pihlaja@siilinjarvi.fi> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34966 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to David Nind from comment #4)
Thanks Katariina and Reetta for signing off!
Thanks from me too :) Keep going! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34966 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34966 --- Comment #7 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34966 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.11.00 |23.11.00,23.05.06 released in| | CC| |fridolin.somers@biblibre.co | |m --- Comment #8 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 23.05.x for 23.05.06 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34966 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.11.00,23.05.06 |23.11.00,23.05.06,22.11.12 released in| | Status|Pushed to stable |Pushed to oldstable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34966 --- Comment #9 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Nice work everyone! Pushed to oldstable for 22.11.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org