[Bug 42665] New: Patron expiration date for hold should be mutable from staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42665 Bug ID: 42665 Summary: Patron expiration date for hold should be mutable from staff interface Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs@lists.koha-community.org Reporter: emmi.takkinen@koha-suomi.fi QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, lisette@bywatersolutions.com, tomascohen@gmail.com Currently when hold is created columns expirationdate and patron_expiration_date receive a same date value. After creating the hold the value in column patron_expiration_date is immutable both in OPAC and staff interface. It's also not displayed in neither of the interfaces unlike value in expirationdate column. Changing expiration date from staff interface only affects to the expirationdate column giving staff and patrons impression that this is the date when the hold will expire. However holds expire when date in patron_expiration_date is hit. This can be very confusing for staff and customers especially if patron_expiration_date is earlier than the expirationdate. To reproduce: 1. Create a hold for patron and set expiration date for it. 2. Find the hold from your database SELECT * from reserves where borrowernumber = [borrowernumber]. => Take a note of the values in expirationdate and patron_expiration_date columns, there should be same value in both of them. 3. Change holds expiration date from biblios Holds page. 4. Query your database again. => Note that only expirationdate value was changed. 5. Check expiration date value from biblios Hold page and patron Hold tab in staff interface and OPAC. => All have same expiration date as in expirationdate column. I suggest that we: 1. Display patron_expiration_date in biblios Hold page. 2. Display patron_expiration_date in patrons Hold tab in staff interface. 3. Display patron_expiration_date in patrons Hold tab in OPAC. 4. Create a new permission which allows staff to change patron_expiration_date in biblios Hold page. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42665 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |emmi.takkinen@koha-suomi.fi |ity.org | Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42665 --- Comment #1 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- Created attachment 201424 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201424&action=edit Bug 42665: Add new permission modify_holds_patron_expiration_date This patch adds new user permission modify_holds_patron_expiration_date which allows users to modify holds expiration date set by patron. To test: 1. Apply this patch. 2. Update database. 3. Check permissions page. => Confirm that new permission modify_holds_patron_expiration_date was added. Also prove t/Koha/Auth/Permissions.t Sponsored-by: Koha-Suomi Oy -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42665 --- Comment #2 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- Created attachment 201425 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201425&action=edit Bug 42665: Add new API endpoint for modifying holds patron_expiration_date column This patch adds new API endpoint for modifying holds patron_expiration_date column. To test: 1. Apply this patch. 2. Run yarn api:bundle in console. 3. Prove t/db_dependent/api/v1/holds.t. Sponsored-by: Koha-Suomi Oy -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42665 --- Comment #3 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- Created attachment 201426 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201426&action=edit Bug 42665: Add new column for holds patron expiration date in biblios holds table Currently holds expiration date set by patron is only viewable from database and it can't be modified by staff users. Only holds expiration date is displayed and can be modified from staff interface, giving users and patrons impression that this is the date when hold expires. This patch adds new column "Expiration date set by patron" to biblios holds table. Column can be modified if patrons has new permission modify_holds_patron_expiration_date. Otherwise expiration date is just displayed as text. To test: 1. Apply this patch and restart services. 2. Log in as superlibrarian. 3. Find a biblio with holds and navigate to the biblios holds page. => Note that there is a new column "Expiration date set by patron" in table. 5. Change the value of the new column. => Confirm that the value was saved succesfully for the hold. 6. Find a staff user. 7. Make sure they have permission to view holds but not the permission to modify holds patron expiration date. 8. Log in as this staff user. 9. Navigate to the biblios holds page. => Note that now column "Expiration date set by patron" can't be modified. 10. Add permission modify_holds_patron_expiration_date to the staff user. => Note that column can now be modified. Sponsored-by: Koha-Suomi Oy -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42665 --- Comment #4 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- Created attachment 201427 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201427&action=edit Bug 42665: Add new column for holds patron expiration date in patrons holds table This patch adds new column "Expiration date set by patron" to holds table in patrons details page. To test: 1. Apply this patch and restart services. 2. Find a patron wih hold and navigate to their details page. 3. Open Holds tab. => Confirm that new column "Expiration date set by patron" is displayed and it has correct date value in it. Sponsored-by: Koha-Suomi Oy -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42665 --- Comment #5 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- Created attachment 201428 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201428&action=edit Bug 42665: Add new column for holds patron expiration date in patrons holds table in OPAC This patch adds new column "Expiration date set by you" to patrons holds table in OPAC. To test: 1. Apply this patch and restart services. 2. Log in to OPAC as a patron with holds. 3. Open their Holds tab. => Confirm that new column "Expiration date set by you" is displayed and it has correct value in it. Sponsored-by: Koha-Suomi Oy -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42665 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org