[Bug 36346] New: CheckReserves sometimes lead to bad behavior
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36346 Bug ID: 36346 Summary: CheckReserves sometimes lead to bad behavior Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: thibaud.guillot@biblibre.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com Hi @ll, Some options in the circulation rules may lead to incorrect returns from CheckReserves. When you enabled AllowHoldPolicyOverride, you can forcing a hold, even when it is not authorized in the "Default holds policy by item type" rule table. Let me explain: when a hold is forced on an item whose itemtype has a holdallowed rule set to "not_allowed", if you return the item, the hold will not be detected. Similarly, when you perform a checkout, the pop-up indicating that a hold has been placed is not displayed. It's possible that in other places in the code this would cause other inconveniences, but I haven't counted them all. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36346 Thibaud Guillot <thibaud.guillot@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |thibaud.guillot@biblibre.co |ity.org |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36346 Thibaud Guillot <thibaud.guillot@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36346 --- Comment #1 from Thibaud Guillot <thibaud.guillot@biblibre.com> --- Created attachment 163339 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163339&action=edit Bug 36346 : Prevent moving to the next object on 'not_allowed' rule Test plan: 1) Enable AllowHoldPolicyOverride 2) Set a new circulation rule on "Default holds policy by item type": For example, an item type called "Comics" with Hold policy set on "No holds allowed" 3) Go to an item related to this item type and force a hold :) 4) Try to perform a check-in on this item, no pop up 5) Try to perform a check out for another patron, no pop up again 6) Apply this patch 7) Repeat step 4 and 4, normally now there is a pop up with hold information Sponsored by : BibLibre -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36346 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com Status|Needs Signoff |In Discussion --- Comment #2 from Nick Clemens <nick@bywatersolutions.com> --- I am not sure this is a bug - librarians sometimes want to be able to force a hold that will only fill later - for example a book on the display shelves might not fill holds, but it can fill holds after it moves, and they could use an itemtype for this control - new books are a similar example -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36346 --- Comment #3 from Thibaud Guillot <thibaud.guillot@biblibre.com> --- I was thinking that if we have the possibility of forcing a hold even if it is not authorized in the rules, the hold should still be found if it exists in certain cases (those I list in the test plan). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36346 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I think this would just fix one case of forced holds, but the problem is a wider one. There are some bugs around this that could be interesting to have a look at. Entry point is: Bug 31169 - [OMNIBUS] Problems with forced holds (AllowHoldPolicyOverride) I think Nick is right in that some libraries expect this behavior, but it would be nice if we could work out a way that we can make this a bit more flexible for libraries which would like things to work differently. But as it is with holds, things tend to be complex :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36346 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #5 from Fridolin Somers <fridolin.somers@biblibre.com> --- Overriding rules is baaaaad ;) -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org