[Bug 14707] New: Change UsageStatsCountry and UsageStatsLibraryType from free text to a dropdown list
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14707 Bug ID: 14707 Summary: Change UsageStatsCountry and UsageStatsLibraryType from free text to a dropdown list Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: trivial Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: julian.fiol@biblibre.com Reporter: julian.fiol@biblibre.com QA Contact: testopia@bugs.koha-community.org This patch avoid issues with Hea. With Bug 14608 we add UsageStatsCountry and UsageStatsLibraryType in the stats for Hea (http://hea.koha-community.org/). But if this 2 syspref are free text, we could have some syntax issues. (ex : US / United States / USA will be count in 3 different country) This patch is supposed to normalize the country and type possibilities. The default choice for UsageStatsLibraryType and UsageStatsCountry is 'empty' Test Plan --------- 1. Create a new Koha install 2. Go to the 'Administration' page 3. Go to 'Global system preferences' 4. Go to 'Administration' 5. At the end of this page you should see a dropdown menu for - UsageStatsCountry with all countries - UsageStatsLibraryType with all type of library They both should be empty by default. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14707 Julian FIOL <julian.fiol@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14707 --- Comment #1 from Julian FIOL <julian.fiol@biblibre.com> --- Created attachment 41789 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41789&action=edit Bug 14707 : Replace UsageStatsCountry and UsageStatsLibraryType syspref from free text to a dropdown list. This will avoid syntax problems with Hea when a user will fill this 2 sysprefs The default choice for UsageStatsLibraryType and UsageStatsCountry is 'empty' Test Plan --------- 1. Create a new Koha install 2. Go to the 'Administration' page 3. Go to 'Global system preferences' 4. Go to 'Administration' 5. At the end of this page you should see a dropdown menu for - UsageStatsCountry with all countries - UsageStatsLibraryType with all type of library They both should be empty by default. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14707 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com --- Comment #2 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Is it a good idea to have a country dropdown? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14707 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice@biblibre.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14707 --- Comment #3 from Julian FIOL <julian.fiol@biblibre.com> --- Hi Tomás, We need to standardize users answers for 'country' and 'type' to avoid Hea issues. Why do you think a country dropdown would be a bad idea ? Do you have another solution in mind ? Thanks -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14707 Zeno Tajoli <z.tajoli@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |z.tajoli@cineca.it Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14707 Zeno Tajoli <z.tajoli@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|z.tajoli@cineca.it | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14707 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hm, UsageStatsLibraryType already is a drop down, without this patch for me? I am also a bit worried about the country, because how complete of a list can we get and where? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14707 --- Comment #5 from Julian Maurice <julian.maurice@biblibre.com> --- (In reply to Katrin Fischer from comment #4)
Hm, UsageStatsLibraryType already is a drop down, without this patch for me?
Probably an error in the commit message, the patch only adds en empty choice for UsageStatsLibraryType
I am also a bit worried about the country, because how complete of a list can we get and where?
Even if we can't be sure we have the exhaustive list of countries, I think it is still better than having all possible forms of USA counted as different countries, not to mention spelling mistakes. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14707 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I have to admit... I don't see a better solution :) Translating all those countries is a bit of a scary thought tho... -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14707 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset@hotmail.com --- Comment #7 from M. Tompsett <mtompset@hotmail.com> --- There is no atomic update perl script which attempts to match the list to ensure it is in the drop down data set, because an upgrade won't necessarily be in the list. Isn't this a problem? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14707 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|julian.fiol@biblibre.com |julian.maurice@biblibre.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14707 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14707 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41789|0 |1 is obsolete| | --- Comment #8 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 44929 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44929&action=edit [SIGNED-OFF] Bug 14707 : Replace UsageStatsCountry and UsageStatsLibraryType syspref from free text to a dropdown list. This will avoid syntax problems with Hea when a user will fill this 2 sysprefs The default choice for UsageStatsLibraryType and UsageStatsCountry is 'empty' Test Plan --------- 1. Create a new Koha install 2. Go to the 'Administration' page 3. Go to 'Global system preferences' 4. Go to 'Administration' 5. At the end of this page you should see a dropdown menu for - UsageStatsCountry with all countries - UsageStatsLibraryType with all type of library They both should be empty by default. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Not a complete list but is a start Lots of new strings to translate :) No errors -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14707 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hm, wondering: 1) The changes for the library type don't match up: societyAssoc: "society or association" vs societyAssociation 2) How can we handle installations that already have the preference set up, but the setting doesn't match one of the provided countries? 3) Please correct bug title and commit message - UsageStatsLibraryType already is a pull down on master. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org