http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8236 --- Comment #1 from Adrien SAURAT <adrien.saurat@biblibre.com> --- Created attachment 10230 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10230&action=edit proposed patch #1 Rebased a patch made by the Lyon3 team. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8236 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Under what circumstances does this bug appear? I assume the "if an item is overdue" is contingent on the OverduesBlockCirc preference? I'm already blocked from renewing an item on circulation.pl by scanning the barcode. With our without the patch I am not prevented from renewing an overdue item via the table of checkouts on the page ("Renew or Return checked items"). Please provide more information and a clear test plan. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8236 Koha Team Lyon 3 <koha@univ-lyon3.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10230|0 |1 is obsolete| | --- Comment #4 from Koha Team Lyon 3 <koha@univ-lyon3.fr> --- Created attachment 11958 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11958&action=edit Block renewal if any checked out book is late I corrected the error that caused the renewal was not blocked clicking the renew buttons. This patch doesn't really correct a bug but propose a new feature. It is independant from OverduesBlockCirc syspref. The logic is that a patron can't renew whatever of his checked out books if any of them is late or if he's restricted. The renewal remains nevertheless possible for the librarian checking the Override renewal limit case. Plan test : Set the OverduesBlockCirc syspref to "Ask for confirmation" Go to a patron account and checkout a book Force a second checkout specifying an outdated due date to make it late You'll see that every checked out books are marked as Not Renewable (Overdue) in the Renew column. As suggested by Nicole C. Engard, I suppose that this should be rather tight to a syspref. I will try to make it within a few days if I can find the time and understand the proper way to do it. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8236 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz --- Comment #6 from Chris Cormack <chris@bigballofwax.co.nz> --- (In reply to comment #5)

This appears to work as described in comment 4, but adding this to master without a system preference to turn it on and off would be an unwanted revision of circulation procedures for a lot of libraries (mine included).

http://www.quickmeme.com/meme/3qgz25/ -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8236 --- Comment #8 from Nicole C. Engard <nengard@gmail.com> --- I agree with Owen - sys prefs are the strength of Koha! -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8236 --- Comment #10 from Chris Cormack <chris@bigballofwax.co.nz> --- Hehe auto correct turns don't even into contravene. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8236 Koha Team Lyon 3 <koha@univ-lyon3.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11958|0 |1 is obsolete| | --- Comment #12 from Koha Team Lyon 3 <koha@univ-lyon3.fr> --- Created attachment 12362 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12362&action=edit Block renewal for overdue documents I reworked entirely the initial patch, added some parts that were obviously missing (Detail circulation tab was forgotten had different behaviour from Checkout one) and tight all with a new syspref (RenewIfOverdue). As for the updatedatabase.pl part and specially the version number I doubt it would be correct, cause I don't know the way to set it, I just increment the last version number present in our updatedatabase.pl file. The syspref offers a triple choice when any of a patron's document is late : => allow renewal anyhow (if the document has renewable type of course) which is today the default action. => block only the overdue items => block all patron's checked out documents (the big punishment...). In the circulation interface, the renewal remains possible through the Override renewal button. the Renew all one is hidden if blocking options are choosen. In the patron's interfaces (Patron's file and the Webservice apis), the same logic is working. Beside the object of this patch, I also noted 2 things that would diserve to have a look : 1) the comments of the IsMemberBlocked routine announces a control on the fines status of the borrower, but the control is done on his restriction status. 2) In case of restriction, the patron's file is frozen (so renewal is not possible but through the webservice interface (RenewLoan in Services.pm) it is. The present patch will correct that last point if validated (an other story) but I think it should be corrected anyhow. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8236 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron@veron.ch --- Comment #13 from Marc Véron <veron@veron.ch> --- Patch does not apply, sorry: error: patch failed: koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt:865 error: koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt: patch does not apply error: patch failed: koha-tmpl/opac-tmpl/prog/en/modules/opac-user.tt:247 error: koha-tmpl/opac-tmpl/prog/en/modules/opac-user.tt: patch does not apply Regarding updatedatabase.pl: You can set the version to "XXXX", i.e.: $DBversion = "XXXX"; Marc -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8236 Koha Team Lyon 3 <koha@univ-lyon3.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12362|0 |1 is obsolete| | --- Comment #15 from Koha Team Lyon 3 <koha@univ-lyon3.fr> --- Created attachment 12619 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12619&action=edit Block renewal when overdues documents patch redone on master. I just change again the name of syspref to "OverduesBlockRenew" in order to make easier the comparision (and distinction) with the other syspref OverduesBlockCirc -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8236 Koha Team Lyon 3 <koha@univ-lyon3.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12619|0 |1 is obsolete| | --- Comment #17 from Koha Team Lyon 3 <koha@univ-lyon3.fr> --- Created attachment 12727 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12727&action=edit Block renewal for overdue documents it has been redone on top of master. it's applying successfully today. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8236 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12727|0 |1 is obsolete| | --- Comment #18 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 12790 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12790&action=edit [SIGNED-OFF] Block renewal for overdue documents If any of patron's document is late, renewal can be allowed, blocked on every checked out items or only on overdue ones. The renewal remains nevertheless possible for the librarian checking the Override renewal limit Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8236 --- Comment #19 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 12791 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12791&action=edit Bug 8236 - Prevent renewing if overdue or restriction - Followup - Fix up preference language. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8236 --- Comment #21 from Koha Team Lyon 3 <koha@univ-lyon3.fr> --- QA says "forbidden patterns The patch introduces a forbidden pattern: tabulation character (188)" in opac-user.pl There's actually a bunch of tabulations that were still there before my patch (lines 157-220) and that are still there in master. I saw them but thought that was discounselled but not forbidden. May I remove them in this patch or has it to be done in a separate patch ? -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8236 Koha Team Lyon 3 <koha@univ-lyon3.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12790|0 |1 is obsolete| | Attachment #12791|0 |1 is obsolete| | --- Comment #23 from Koha Team Lyon 3 <koha@univ-lyon3.fr> --- Created attachment 13510 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13510&action=edit Bug 8236 Block renewing for overdue items As for the tabulations pointed out by QA, I made a separate patch (bug 9098). It's assumed that 9098 had been previously applied before this one. Reminder of test plan : Plan test : Set the OverduesBlockCirc syspref to "Ask for confirmation" Set the OverduesBlockRenew syspref to "blockall" Go to a patron account and checkout a book Force a second checkout specifying an outdated due date to make it late You'll see that every checked out books are marked as Not Renewable (Overdue) in the Renew column. Redo same process setting "blockitem" option in the syspref You'll see that only the late item had been marked as Not Renewable (Overdue). -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8236 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #24 from Kyle M Hall <kyle@bywatersolutions.com> --- Merge conflict in opac/opac-user.pl -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8236 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff Patch complexity|--- |Small patch --- Comment #26 from Kyle M Hall <kyle@bywatersolutions.com> --- Probably an error on my part then. Resetting status to "Needs Signoff". -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8236 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8236 Koha Team Lyon 3 <koha@univ-lyon3.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |koha@univ-lyon3.fr --- Comment #29 from Koha Team Lyon 3 <koha@univ-lyon3.fr> --- (En réponse au commentaire 28)

Hi Koha Team Lyon 3,

I'm under the impression that some duplicated code could be factorized into the CanBookBeRenewed routine. Is there a reason for this code not being in it?

As you suggest it, I first considered putting the following block in CanBookBeRenewed : # Check if any of patron's documents is late my ($memberblocked) = C4::Members::IsMemberBlocked($borrowernumber); # and if renewal is allowed in that case my $overduesblockrenew = C4::Context->preference('OverduesBlockRenew'); my $norenewal = 1 if $overduesblockrenew eq 'blockall' and $memberblocked == -1; But as this block is there to check if no renewal at all is allowed, one checking by borrower is enough and it would be redundant checking again for each item. So I choose to put it outside the @$issueslist loop (sub build_issue_data) and keep the result in $norenewal variable. So when $norenewal is true, I have not to call for CanBookBeRenewed, I can straightly affect the value to $renewokay and $renewerror : my ( $renewokay, $renewerror ) = $norenewal ? (0, 'overdue') : CanBookBeRenewed( $borrowernumber, $issue->{itemnumber}... At the end, I am not sure that it's a great economy but that's the reason why. May be I could make a function out of this block and put it in Circulation.pm : sub CanOverduesBlockRenewal { my $borrowernumber = shift; # Check if any of patron's documents is late my ($memberblocked) = C4::Members::IsMemberBlocked($borrowernumber); # the option selected for the syspref my $overduesblockrenew = C4::Context->preference('OverduesBlockRenew'); # and if renewal is blocked for all the patron's documents on loan my $norenewal = 1 if $overduesblockrenew eq 'blockall' and $memberblocked == -1; return ($norenewal,$overduesblockrenew); } Olivier Crouzet -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8236 Fridolyn SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolyn.somers@biblibre.co | |m See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=6739 -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8236 --- Comment #31 from David Cook <dcook@prosentient.com.au> --- I think this patch is also missing the "opac-renew.pl" file... -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8236 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=10089 --- Comment #32 from David Cook <dcook@prosentient.com.au> --- Given the complexity of this patch, I think it would be a good idea to split this into a "block renewing for overdue items" and "prevent renewing for restricted patrons". I've created a new bug with a patch for "preventing renewing for restricted patrons": http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10089 -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8236 Koha Team Lyon 3 <koha@univ-lyon3.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14433|0 |1 is obsolete| | --- Comment #34 from Koha Team Lyon 3 <koha@univ-lyon3.fr> --- Created attachment 17926 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17926&action=edit Bug 8236 Block renewing for overdue items At the end , I found more convenient to deal with the restriction case in same patch. I keep what seems to be the existing logic - a patron can't renew when he's restricted (his opac file is freezen) - making it more consistent. Any renewal for a restricted patron is now also blocked from webservice and clearly not possible from the pro interface unless by checking 'override_limit'. If someone would like to allowed renewal for restricted patrons, I think it would be not very complicated to add a syspref ( a line of code in HasWhateverRenewalToBeBlocked and some addings in opac-user.tt) As for the main object of the patch - blocking for late document - I made some ajustements you pointed out and one change in the logic : rather than hiding the 'Renew all' button, I move the checking in renewscript.pl. So, this button is always available in case of big list of checkouts items. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8236 --- Comment #35 from Koha Team AMU <koha.aixmarseille@gmail.com> --- So sad. It seems we can't test it on a sandbox : Something went wrong ! Applying: Bug 8236 Block renewing for overdue items Using index info to reconstruct a base tree... Falling back to patching base and 3-way merge... Auto-merging C4/Circulation.pm Auto-merging circ/circulation.pl Auto-merging installer/data/mysql/sysprefs.sql CONFLICT (content): Merge conflict in installer/data/mysql/sysprefs.sql Auto-merging installer/data/mysql/updatedatabase.pl CONFLICT (content): Merge conflict in installer/data/mysql/updatedatabase.pl Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt Auto-merging koha-tmpl/opac-tmpl/prog/en/modules/opac-user.tt Auto-merging opac/opac-renew.pl CONFLICT (content): Merge conflict in opac/opac-renew.pl Auto-merging opac/opac-user.pl Auto-merging reserve/renewscript.pl Failed to merge in the changes. Patch failed at 0001 Bug 8236 Block renewing for overdue items -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8236 --- Comment #37 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to comment #36)

Yes, I think it's not possible, on the sandbox because of the versioning in updatedatabase.pl file.

Yes it is possible, but you should provide a patch rebased against master. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8236 --- Comment #39 from David Cook <dcook@prosentient.com.au> --- (In reply to comment #34)

Created attachment 17926 [details] [review] Bug 8236 Block renewing for overdue items

At the end , I found more convenient to deal with the restriction case in same patch. I keep what seems to be the existing logic - a patron can't renew when he's restricted (his opac file is freezen) - making it more consistent. Any renewal for a restricted patron is now also blocked from webservice and clearly not possible from the pro interface unless by checking 'override_limit'. If someone would like to allowed renewal for restricted patrons, I think it would be not very complicated to add a syspref ( a line of code in HasWhateverRenewalToBeBlocked and some addings in opac-user.tt) As for the main object of the patch - blocking for late document - I made some ajustements you pointed out and one change in the logic : rather than hiding the 'Renew all' button, I move the checking in renewscript.pl. So, this button is always available in case of big list of checkouts items.

Olivier, I'm not sure that I completely understand what you are saying, but I think it's quite important to not allow any renewals for restricted patrons at all and that the button should not be visible for a restricted patron, as Owen mentioned in bug 10089. In Comment 33, you mention that we should leave renewals for restricted patrons up to the discretion of the librarian, but I don't think this is a good idea. First, we block all check outs for restricted patrons. Renewals really are just another type of check out, so logically it makes sense to block these too. Second, even though there is red text saying the patron is blocked, I have reported cases where library staff have accidentally ignored this and renewed patrons away (much to the chagrin of their co-workers/supervisors). I think it's necessary to enforce the prevention of renewals for restricted patrons. In any case, I think these are still conceptually two different issues that should probably be handled by different patches. That said, I haven't looked at your newest code. If you prevent all renewals for restricted patrons in all cases and hide the renew buttons, as Owen suggested in bug 10089, then I would have no problem using your patch instead of mine. In all honesty, another reason I separated the patches is because I wanted the "prevent renewals for restricted patrons" behaviour to be introduced as quickly as possible. The more atomic the patch, the easier it is to test/QA, and the faster it gets into the codebase. Rant aside, once you rebase this patch, I'd be more than happy to test it. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8236 Koha Team Lyon 3 <koha@univ-lyon3.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18071|0 |1 is obsolete| | --- Comment #41 from Koha Team Lyon 3 <koha@univ-lyon3.fr> --- Created attachment 18073 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18073&action=edit Bug 8236 Block renewing for overdue items -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8236 Pierre Angot <tredok.pierre@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |tredok.pierre@gmail.com --- Comment #43 from Pierre Angot <tredok.pierre@gmail.com> --- Sandbox setup by tredok.pierre@gmail.com with database 2 and bug 8236 on Thu Jun 6 08:57:09 2013 Something went wrong ! Applying: Bug 8236 Block renewing for overdue items Using index info to reconstruct a base tree... Falling back to patching base and 3-way merge... Auto-merging C4/Circulation.pm CONFLICT (content): Merge conflict in C4/Circulation.pm Auto-merging circ/circulation.pl Auto-merging installer/data/mysql/sysprefs.sql CONFLICT (content): Merge conflict in installer/data/mysql/sysprefs.sql Auto-merging installer/data/mysql/updatedatabase.pl CONFLICT (content): Merge conflict in installer/data/mysql/updatedatabase.pl Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt Auto-merging koha-tmpl/opac-tmpl/prog/en/modules/opac-user.tt Auto-merging members/moremember.pl Auto-merging opac/opac-user.pl Failed to merge in the changes. Patch failed at 0001 Bug 8236 Block renewing for overdue items When you have resolved this problem run "git am --resolved". If you would prefer to skip this patch, instead run "git am --skip". To restore the original branch and stop patching run "git am --abort". Bug 8236 - Prevent renewing if overdue or restriction Bug-8236-Block-renewing-for-overdue-items.patch Apply? [yn] Patch left in /tmp/Bug-8236-Block-renewing-for-overdue-itemspatch-qFvBtT.patch -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8236 --- Comment #45 from Pierre Angot <tredok.pierre@gmail.com> --- We have tested : 1) Allow renewing all items : ok if overdue or restriction 2) Block renewing all itms : ok if overdue or restriction 3) Block only overdue items : a patron with 2 check out : only one is overdue. We have a message for this one (Renewal not allowed (overdue)). We can't renew the other one and we have no message. If we check "Override renewal limit" we can't renew the item which is not overdue. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8236 Koha Team Lyon 3 <koha@univ-lyon3.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18507|0 |1 is obsolete| | --- Comment #46 from Koha Team Lyon 3 <koha@univ-lyon3.fr> --- Created attachment 18729 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18729&action=edit Bug 8236 Block renewing for overdue items oups, squeezed some lines that had to be kept; Problem corrected -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8236 Bob Birchall <bob@calyx.net.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bob@calyx.net.au -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8236 --- Comment #48 from Koha Team Lyon 3 <koha@univ-lyon3.fr> --- Hello Fridolyn, I'm not sure that the patch of bug 6739 has the same goal : - with this patch we want to prevent renewing if patrons have overdues or restriction. - with bug 6739, it wants to prevent renewing if patrons who have a card no more valid. It's not the same behaviour. Can you confirm that I have understood well and switch back this patch "need signoff" ? Sonia -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8236 Fridolyn SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff --- Comment #50 from Fridolyn SOMERS <fridolyn.somers@biblibre.com> --- Indeed, this patch does not provide the same behavior. I set back to "Needs Signoff" -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8236 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8236 Fridolyn SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20716|0 |1 is obsolete| | Status|Failed QA |Needs Signoff Assignee|koha@univ-lyon3.fr |fridolyn.somers@biblibre.co | |m --- Comment #55 from Fridolyn SOMERS <fridolyn.somers@biblibre.com> --- Created attachment 20719 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20719&action=edit Bug 8236 - Prevent renewing if overdue or restriction I revised the patch. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8236 Fridolyn SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20719|0 |1 is obsolete| | --- Comment #57 from Fridolyn SOMERS <fridolyn.somers@biblibre.com> --- Created attachment 21163 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21163&action=edit Bug 8236 Block renewing for overdue items Rebased master -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8236 Pierre Angot <tredok.pierre@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #58 from Pierre Angot <tredok.pierre@gmail.com> --- Hello, Test on sandbox : Something went wrong ! Applying: Bug 8236 Block renewing for overdue items\nUsing index info to reconstruct a base tree...\nFalling back to patching base and 3-way merge...\nAuto-merging C4/Circulation.pm Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt\nFailed to merge in the changes.\nPatch failed at 0001 Bug 8236 Block renewing for overdue items When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort".\nBug 8236 - Prevent renewing if overdue or restriction 21163 - Bug 8236 Block renewing for overdue items -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8236 Fridolyn SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8236 Aurélie Fichot <aurelie.fichot@iepg.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aurelie.fichot@iepg.fr --- Comment #61 from Aurélie Fichot <aurelie.fichot@iepg.fr> --- The sandbox you've requested is not ready. Some problems occurred applying patches from bug 8236: <h1>Something went wrong !</h1>Applying: Bug 8236 Block renewing for overdue items Using index info to reconstruct a base tree... Falling back to patching base and 3-way merge... Auto-merging C4/Circulation.pm Auto-merging circ/circulation.pl Auto-merging installer/data/mysql/sysprefs.sql Auto-merging installer/data/mysql/updatedatabase.pl CONFLICT (content): Merge conflict in installer/data/mysql/updatedatabase.pl Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt Auto-merging members/moremember.pl Failed to merge in the changes. Patch failed at 0001 Bug 8236 Block renewing for overdue items When you have resolved this problem run git bz apply --continue. If you would prefer to skip this patch, instead run git bz apply --skip. To restore the original branch and stop patching run git bz apply --abort. Bug 8236 - Prevent renewing if overdue or restriction 21223 - Bug 8236 Block renewing for overdue items Apply? [(y)es, (n)o, (i)nteractive] Patch left in /tmp/Bug-8236-Block-renewing-for-overdue-items-RX74cM.patch . -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8236 --- Comment #63 from Aurélie Fichot <aurelie.fichot@iepg.fr> --- I installed the patch and I receive a message saying to me : sandbox is not ready! But no text of error in the body of the message -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8236 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22264|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8236 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22275|0 |1 is obsolete| | --- Comment #66 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 22280 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22280&action=edit Bug 8236 Block renewing for overdue items Bug 8236 Block renewing for overdue items If any of patron's document is late, renewal can be allowed, blocked on every checked out items or only on overdue ones. The renewal remains nevertheless possible for the librarian checking the Override renewal limit. Signed-off-by: Aurélie Fichot <aurelie.fichot@iepg.fr> (I reupload the patch in order to fix the encoding issue caused by the sandbox) -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8236 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #68 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hm, it looks like the patch is from "Koha Team Lyon 3", but the bug is assigned to Fridolin - got a bit confused here :) -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8236 Fridolin SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|fridolyn.somers@biblibre.co |koha@univ-lyon3.fr |m | -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8236 Suzanne Fayle <sfayle@roseman.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sfayle@roseman.edu -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8236 Koha Team Lyon 3 <koha@univ-lyon3.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8236 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34234|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8236 Levast <juliette.levast@iepg.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |juliette.levast@iepg.fr --- Comment #73 from Levast <juliette.levast@iepg.fr> --- This patch works perfectly. He answers all our needs and it is essential for our users. Hoping it quickly pushed master. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8236 --- Comment #75 from Koha Team Lyon 3 <koha@univ-lyon3.fr> --- (In reply to Kyle M Hall from comment #74)

If I choose only this item for OverduesBlockRenewing, all my items are blocked from renewal.

I tested again and it's still OK. I can't see why you could have this result. Could you be more precise ? is it on the personnal file, on the pro interface ? some other clue ? -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8236 Marjorie Barry-Vila <marjorie.barry-vila@ccsr.qc.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila@ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8236 Aurélie Fichot <aurelie.fichot@iepg.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #77 from Aurélie Fichot <aurelie.fichot@iepg.fr> --- The sandbox you've requested is not ready. Some problems occurred applying patches from bug 8236: <h1>Something went wrong !</h1>Applying: Bug 8236 Renewing policy in overdue or restriction case Using index info to reconstruct a base tree... Falling back to patching base and 3-way merge... Auto-merging installer/data/mysql/updatedatabase.pl CONFLICT (content): Merge conflict in installer/data/mysql/updatedatabase.pl Auto-merging installer/data/mysql/sysprefs.sql Auto-merging C4/Circulation.pm Failed to merge in the changes. Patch failed at 0001 Bug 8236 Renewing policy in overdue or restriction case When you have resolved this problem run git bz apply --continue. If you would prefer to skip this patch, instead run git bz apply --skip. To restore the original branch and stop patching run git bz apply --abort. Bug 8236 - Prevent renewing if overdue or restriction 35372 - Bug 8236 Renewing policy in overdue or restriction case Apply? [(y)es, (n)o, (i)nteractive] Patch left in /tmp/Bug-8236-Renewing-policy-in-overdue-or-restriction-Gwo9FG.patch . -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8236 Koha Team Lyon 3 <koha@univ-lyon3.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8236 Koha Team Lyon 3 <koha@univ-lyon3.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36674|0 |1 is obsolete| | --- Comment #80 from Koha Team Lyon 3 <koha@univ-lyon3.fr> --- Created attachment 36743 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36743&action=edit Bug 8236 Renewing policy in overdue or restriction case grrrmmffff... silly error on calling HasOverdues function. patch redone -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8236 --- Comment #82 from Matthias Meusburger <matthias.meusburger@biblibre.com> --- Created attachment 37407 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37407&action=edit [SIGNED-OFF] Bug 8236 Renewing policy in overdue or restriction case This patch introduces 2 sysprefs : RestrictionBlockRenewing to allow/block renewal of items when patron is restricted. OverduesBlockRenewing to allow, block only the late ones or block all checked out items Default is "allow" in both case. Signed-off-by: Matthias Meusburger <matthias.meusburger@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8236 Matthias Meusburger <matthias.meusburger@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8236 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8236 --- Comment #85 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 37458 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37458&action=edit [PASSED QA] Bug 8236: Tests for Renewing policy in overdue or restriction case - Add tests in t/db_dependent/Circulation.t Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8236 Tom Misilo <misilot@fit.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |misilot@fit.edu -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8236 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37457|0 |1 is obsolete| | Attachment #37458|0 |1 is obsolete| | Attachment #37459|0 |1 is obsolete| | --- Comment #88 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 41992 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41992&action=edit Bug 8236 Renewing policy in overdue or restriction case This patch introduces 2 sysprefs : RestrictionBlockRenewing to allow/block renewal of items when patron is restricted. OverduesBlockRenewing to allow, block only the late ones or block all checked out items Default is "allow" in both case. Signed-off-by: Matthias Meusburger <matthias.meusburger@biblibre.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8236 --- Comment #90 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 41994 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41994&action=edit Bug 8236 [QA Followup] - Tweak language, fix whitespace error -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8236 Joonas Kylmälä <j.kylmala@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8236 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8236 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #94 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patches pushed to master. Thanks Lyon3 team! -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8236 Jenny Dallas <limbozel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |limbozel@gmail.com --- Comment #96 from Jenny Dallas <limbozel@gmail.com> --- I love it! Excellent article. I need help with this too! If you ever need to fill out a form, here is or <a href="http://www.tax.ny.gov/pdf/2003/et/tt86_5_103.pdf" >www.tax.ny.gov</a> a really useful tool. Very easy to navigate and use. -- You are receiving this mail because: You are watching all bug changes.