[Bug 42420] New: Strings from data-placeholder attributes not translated
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42420 Bug ID: 42420 Summary: Strings from data-placeholder attributes not translated Initiative type: --- Sponsorship --- status: Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: translate.koha-community.org Assignee: koha-bugs@lists.koha-community.org Reporter: januszop@gmail.com QA Contact: testopia@bugs.koha-community.org CC: jonathan.druart@gmail.com It seems that strings from data-placeholder attributes are not translated in Koha, and they are absent from Pootle. Examples include all "Search by..." placeholders in koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-advsearch.tt. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42420 Janusz Kaczmarek <januszop@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch Assignee|koha-bugs@lists.koha-commun |januszop@gmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42420 --- Comment #1 from Janusz Kaczmarek <januszop@gmail.com> --- Created attachment 197779 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=197779&action=edit Bug 42420: Strings from data-placeholder attributes not translated It seems that strings from data-placeholder attributes are not translated in Koha, and they are absent from Pootle. Test plan ========= 1. E.g. in OPAC advanced search there are placeholders "Search by ...": "Search by keyword etc". 2. Verify that the strings are absent from <lang>-opac-bootstrap.po file. 3. Apply the patch, run gulp po:update 4. Verify that the strings from 'data-placeholder' are now present in <lang>-opac-bootstrap.po file and can be translated. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42420 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42420 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #197779|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42420 --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 197823 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=197823&action=edit Bug 42420: Strings from data-placeholder attributes not translated It seems that strings from data-placeholder attributes are not translated in Koha, and they are absent from Weblate. Test plan ========= 1. E.g. in OPAC advanced search there are placeholders "Search by ...": "Search by keyword etc". 2. Verify that the strings are absent from <lang>-opac-bootstrap.po file. 3. Apply the patch, run gulp po:update 4. Verify that the strings from 'data-placeholder' are now present in <lang>-opac-bootstrap.po file and can be translated. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42420 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #3 from David Nind <david@davidnind.com> --- Testing notes (using KTD): 1. I used fr-FR-opac-bootstrap.po and searched the file for "Search by", there were no results, such as: - Search by keyword phrase - Search by subject phrase - Search by conference name - Search curriculum ... (The "Search by..." words can be found in koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-advsearch.tt and the data-placeholder element for option tags.) 2. Before the patch, you can't find any "Search by ..." in misc/translator/po/fr-FR-opac-bootstrap.po 3. After the patch, you can find several, for example: #. OPTION #: koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-advsearch.tt:81 #, fuzzy msgid "Search by keyword phrase" msgstr "Recherche dans le catalogue par mot-clé dans %s" Note: I edited the commit message, as we now use Weblate, not Pootle. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42420 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #4 from Jonathan Druart <jonathan.druart@gmail.com> --- Hum this is not quite right it seems: git checkout origin/main gulp po:update --lang fr-FR cd misc/translator/po git commit -a -m"wip" cd - git checkout bug_42420 (main + this patch) gulp po:update --lang fr-FR cd - git diff +#: koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead.inc:241 +#: koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead.inc:243 +#: koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead.inc:246 +#: koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead.inc:248 +#: koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead.inc:251 +#: koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead.inc:253 +#: koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead.inc:256 +#: koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead.inc:258 +#: koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead.inc:261 +#: koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead.inc:263 +#: koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead.inc:266 +#: koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead.inc:268 +#: koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead.inc:271 +#: koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead.inc:273 +#: koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead.inc:277 +#: koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead.inc:279 +#: koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead.inc:283 +#: koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead.inc:285 +msgid "[% t(" +msgstr "" The other changes in fr-FR-opac-bootstrap.po look correct. However, in fr-FR-staff-prog.po: +#. H1 +#: koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt:2731 +#, fuzzy +msgid "title" +msgstr "Titre" +#. TEXTAREA +#: koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt:2734 +#, fuzzy +msgid "code" +msgstr "ccode" +#. A +#: koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt:2736 +msgid "edit-href" +msgstr "" +#. A +#: koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt:2737 +#, fuzzy +msgid "duplicate-href" +msgstr "Dupliquer" +#. A +#: koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt:2738 +#, fuzzy +msgid "schedule-href" +msgstr "Planificateur de tâches" +#. A +#: koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt:2739 +#, fuzzy +msgid "delete-attrs" +msgstr "Supprimer les adhérents" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42420 --- Comment #5 from Jonathan Druart <jonathan.druart@gmail.com> --- I can have a deeper look later, but I won't have time soon unfortunately. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42420 --- Comment #6 from Janusz Kaczmarek <januszop@gmail.com> --- (In reply to Jonathan Druart from comment #5)
I can have a deeper look later, but I won't have time soon unfortunately.
Jonathan, could you please have maybe another look at this issue. Thank you :) -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org