[Bug 32589] New: Improve heading on results table for 'checkouts with no items' report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32589 Bug ID: 32589 Summary: Improve heading on results table for 'checkouts with no items' report Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: minor Priority: P5 - low Component: Reports Assignee: katrin.fischer@bsz-bw.de Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org Depends on: 32586 When no group criteria is selected, the table heading above the results will read NULL on the 'checkouts with no items' report. This is not nice. If item type or library are selected, it will show the codes instead of the descriptions. This isn't nice either. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32586 [Bug 32586] Reindent items with no checkouts reports template -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32589 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|32586 |32587 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32586 [Bug 32586] Reindent items with no checkouts reports template https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32587 [Bug 32587] Add page-section to items with no checkouts report -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32589 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Improve heading on results |Improve headings on results |table for 'checkouts with |table for 'checkouts with |no items' report |no items' report -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32589 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Improve headings on results |Improve headings on result |table for 'checkouts with |tables for 'checkouts with |no items' report |no items' report -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32589 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32589 --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 145123 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145123&action=edit Bug 32589: Improve headings on result tables for 'Items with no checkouts' When no filter was selected on the search form, the heading on the results table showed as NULL. When library or item type were selected the codes instead of the descriptions showed. To test: * Without patch: * Run the 'items with no checkouts' report with different settings for 'By:'. Verify the headings on the tables are not nice. * Apply patch * Rerun reports * Headings should be "Ungrouped, item type or library descriptions * Summary table also shows item type and library descriptions -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32589 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |32588 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32588 [Bug 32588] Filters on top of 'Items with no checkouts' report are untranslatable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32589 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32589 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145123|0 |1 is obsolete| | --- Comment #2 from Frédéric Demians <frederic@tamil.fr> --- Created attachment 145129 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145129&action=edit Bug 32589: Improve headings on result tables for 'Items with no checkouts' When no filter was selected on the search form, the heading on the results table showed as NULL. When library or item type were selected the codes instead of the descriptions showed. To test: * Without patch: * Run the 'items with no checkouts' report with different settings for 'By:'. Verify the headings on the tables are not nice. * Apply patch * Rerun reports * Headings should be "Ungrouped, item type or library descriptions * Summary table also shows item type and library descriptions Signed-off-by: Frédéric Demians <f.demians@tamil.fr> → OK. Would be nice to have decoding also in 'Filtered on' top section -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32589 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic@tamil.fr --- Comment #3 from Frédéric Demians <frederic@tamil.fr> --- Forget my comment about decoding top section: solved by bug 32588 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32589 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Frédéric Demians from comment #3)
Forget my comment about decoding top section: solved by bug 32588
Yes, I tried to break it up into smaller steps - thx for working through the tree :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32589 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145129|0 |1 is obsolete| | --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 145860 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145860&action=edit Bug 32589: Improve headings on result tables for 'Items with no checkouts' When no filter was selected on the search form, the heading on the results table showed as NULL. When library or item type were selected the codes instead of the descriptions showed. To test: * Without patch: * Run the 'items with no checkouts' report with different settings for 'By:'. Verify the headings on the tables are not nice. * Apply patch * Rerun reports * Headings should be "Ungrouped, item type or library descriptions * Summary table also shows item type and library descriptions Signed-off-by: Frédéric Demians <f.demians@tamil.fr> → OK. Would be nice to have decoding also in 'Filtered on' top section Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32589 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com Status|Signed Off |Passed QA CC| |martin.renvoize@ptfs-europe | |.com --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Another nice little improvement, Passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32589 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32589 --- Comment #7 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32589 Jacob O'Mara <jacob.omara@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.05.00 |23.05.00,22.11.03 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32589 --- Comment #8 from Jacob O'Mara <jacob.omara@ptfs-europe.com> --- Nice work, thanks everyone! Pushed to 22.11.x for the next release. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32589 Bug 32589 depends on bug 32587, which changed state. Bug 32587 Summary: Add page-section to items with no checkouts report https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32587 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32589 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |lucas@bywatersolutions.com Status|Pushed to stable |RESOLVED --- Comment #9 from Lucas Gass <lucas@bywatersolutions.com> --- Missing dependencies for 22.05.x, no backport -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org