[Bug 20473] New: "Item information" tab should not appear if item is not created upon placing an order
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20473 Bug ID: 20473 Summary: "Item information" tab should not appear if item is not created upon placing an order Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: caroline.cyr-la-rose@inlibro.com QA Contact: testopia@bugs.koha-community.org When ordering from a staged file, and when items are NOT created at that time, the "item information" tab appears even though it is useless in this case. To reproduce : - Make sure system preference acqcreateitem is "cataloguing the record" or "receiving an order". - Make sure you have everything needed to place an order (currency, budget, vendor) 1. Stage a MARC file from Tools > Stage MARC records for import 2. Go to Acquisitions and create a basket for a vendor 3. Add to basket from staged file 4. Note that the "item information" tab is present, if you click on it, not that it is not useful -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20473 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrewfh@dubcolib.org --- Comment #1 from Nick Clemens <nick@bywatersolutions.com> --- *** Bug 23585 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20473 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20473 --- Comment #2 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 144676 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144676&action=edit Bug 20473: Don't display 'Item information' tab when adding to basket from a file and not creating items This patch adds a conditional, and moves another up one level to remove the tab when it will have no content/effect To test: 1. Stage a MARC file from Tools > Stage MARC records for import 2. Go to Acquisitions and create a basket for a vendor 3. Add to basket from staged file 4. Note that the "item information" tab is present, if you click on it, not that it is not useful 5. Cancel adding to basket 6. Apply patch 7. Add to basket from the staged file again 8. Confirm there is no item information tab 9. Confirm orders are added on 'Save' -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20473 --- Comment #3 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 144677 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144677&action=edit Bug 20473: Whitespace -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20473 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |nick@bywatersolutions.com |ity.org | CC| |nick@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20473 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144676|0 |1 is obsolete| | --- Comment #4 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 144678 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144678&action=edit Bug 20473: Don't display 'Item information' tab when adding to basket from a file and not creating items This patch adds a conditional, and moves another up one level to remove the tab when it will have no content/effect To test: 1. Stage a MARC file from Tools > Stage MARC records for import 2. Go to Acquisitions and create a basket for a vendor 3. Add to basket from staged file 4. Note that the "item information" tab is present, if you click on it, not that it is not useful 5. Cancel adding to basket 6. Apply patch 7. Add to basket from the staged file again 8. Confirm there is no item information tab 9. Confirm orders are added on 'Save' -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20473 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144677|0 |1 is obsolete| | --- Comment #5 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 144679 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144679&action=edit Bug 20473: Whitespace -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20473 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20473 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144678|0 |1 is obsolete| | --- Comment #6 from David Nind <david@davidnind.com> --- Created attachment 144729 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144729&action=edit Bug 20473: Don't display 'Item information' tab when adding to basket from a file and not creating items This patch adds a conditional, and moves another up one level to remove the tab when it will have no content/effect To test: 1. Stage a MARC file from Tools > Stage MARC records for import 2. Go to Acquisitions and create a basket for a vendor 3. Add to basket from staged file 4. Note that the "item information" tab is present, if you click on it, not that it is not useful 5. Cancel adding to basket 6. Apply patch 7. Add to basket from the staged file again 8. Confirm there is no item information tab 9. Confirm orders are added on 'Save' Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20473 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144679|0 |1 is obsolete| | --- Comment #7 from David Nind <david@davidnind.com> --- Created attachment 144730 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144730&action=edit Bug 20473: Whitespace Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20473 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This updates adding an release notes| |order to a basket from a | |staged file (when the | |setting for the basket is | |to not create items until | |the order is received or | |catalogued) so that the | |'Item information' tab | |doesn't appear, as it is | |not used. CC| |david@davidnind.com --- Comment #8 from David Nind <david@davidnind.com> --- Testing notes (using KTD): 1. For step 2: When adding a basket to a vendor, for 'Create items when' select either 'receiving an order' or 'cataloging the record'. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20473 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|trivial |normal Text to go in the|This updates adding an | release notes|order to a basket from a | |staged file (when the | |setting for the basket is | |to not create items until | |the order is received or | |catalogued) so that the | |'Item information' tab | |doesn't appear, as it is | |not used. | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20473 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20473 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20473 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144729|0 |1 is obsolete| | --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 145824 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145824&action=edit Bug 20473: Don't display 'Item information' tab when adding to basket from a file and not creating items This patch adds a conditional, and moves another up one level to remove the tab when it will have no content/effect To test: 1. Stage a MARC file from Tools > Stage MARC records for import 2. Go to Acquisitions and create a basket for a vendor 3. Add to basket from staged file 4. Note that the "item information" tab is present, if you click on it, not that it is not useful 5. Cancel adding to basket 6. Apply patch 7. Add to basket from the staged file again 8. Confirm there is no item information tab 9. Confirm orders are added on 'Save' Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20473 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144730|0 |1 is obsolete| | --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 145825 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145825&action=edit Bug 20473: Whitespace Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20473 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20473 --- Comment #11 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20473 Jacob O'Mara <jacob.omara@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.05.00 |23.05.00,22.11.03 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20473 --- Comment #12 from Jacob O'Mara <jacob.omara@ptfs-europe.com> --- Nice work, thanks everyone! Pushed to 22.11.x for the next release. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20473 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED CC| |lucas@bywatersolutions.com Resolution|--- |FIXED --- Comment #13 from Lucas Gass <lucas@bywatersolutions.com> --- Doesn't apply cleanly to 22.05.x, no backport. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org