[Bug 11459] New: OrderPdfFormat pref description could be more verbose
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11459 Bug ID: 11459 Summary: OrderPdfFormat pref description could be more verbose Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: mathsabypro@gmail.com QA Contact: testopia@bugs.koha-community.org The description is: " Use when printing basket groups. " The list of possible templates should be precised. M. Saby -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11459 --- Comment #1 from mathieu saby <mathsabypro@gmail.com> --- There are only 3 valid values for OrderPdfFormat : pdfformat::layout2pages pdfformat::layout3pages in french:pdfformat::layout3pagesfr We should improve syspref description, and the manual. M. Saby -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11459 mathieu saby <mathsabypro@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |mathsabypro@gmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11459 --- Comment #2 from mathieu saby <mathsabypro@gmail.com> --- Created attachment 24735 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24735&action=edit Bug 11459: Make OrderPdfFormat syspref description more verbose This patch adds precisions to OrderPdfFormat syspref. To test: in staff interface, check the syspref is now presented that way: Use ___ layout when printing basket groups (in the form pdfformat::layoutname). Two english layouts are available: pdfformat::layout2pages and pdfformat::layout3pages ; one french layout is available: pdfformat::layout3pagesfr. M. Saby -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11459 mathieu saby <mathsabypro@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11459 mathieu saby <mathsabypro@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24735|0 |1 is obsolete| | --- Comment #3 from mathieu saby <mathsabypro@gmail.com> --- Created attachment 24787 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24787&action=edit [PATCH] Bug 11459: Make OrderPdfFormat syspref description more verbose -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11459 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Depends on| |10746 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11459 --- Comment #4 from Marc Véron <veron@veron.ch> --- Created attachment 25351 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25351&action=edit Bug 11459: Make OrderPdfFormat syspref description more verbose This patch adds precisions to OrderPdfFormat syspref. To test: in staff interface, check the syspref is now presented that way: Use ___ layout when printing basket groups (in the form pdfformat::layoutname). Two english layouts are available: pdfformat::layout2pages and pdfformat::layout3pages ; one french layout is available: pdfformat::layout3pagesfr. Patch behaves as expected. Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11459 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24787|0 |1 is obsolete| | CC| |veron@veron.ch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11459 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |String patch Summary|OrderPdfFormat pref |[Signed-Off] OrderPdfFormat |description could be more |pref description could be |verbose |more verbose -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11459 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 25569 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25569&action=edit [PASSED QA] Bug 11459: Make OrderPdfFormat syspref description more verbose This patch adds precisions to OrderPdfFormat syspref. To test: in staff interface, check the syspref is now presented that way: Use ___ layout when printing basket groups (in the form pdfformat::layoutname). Two english layouts are available: pdfformat::layout2pages and pdfformat::layout3pages ; one french layout is available: pdfformat::layout3pagesfr. Patch behaves as expected. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Fixed English/French. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11459 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11459 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25351|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11459 --- Comment #6 from Galen Charlton <gmcharlt@gmail.com> --- Created attachment 25670 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25670&action=edit [COUNTER PATCH] Bug 11459: use drop-down to set OrderPdfFormat syspref This patch converts the OrderPdfFormat to a choice. To test: [1] Look at OrderPdfFormat in the system preferences editor. Verify that there is a drop-down giving a choice among the three PDF basketgroup printing formats. [2] Change the OrderPdfFormat setting and print a basketgroup. Verify that the chosen template is used. Signed-off-by: Galen Charlton <gmc@esilibrary.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11459 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |In Discussion CC| |gmcharlt@gmail.com --- Comment #7 from Galen Charlton <gmcharlt@gmail.com> --- The system preferences editor lets one specify a set of choice for a syspref. A drop-down makes more sense than asking the user to copy and paste their chosen value from the system preference, and also makes it less error-prone. Consequently, I've attached a counter-patch. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11459 --- Comment #8 from Marc Véron <veron@veron.ch> --- 11828 will introduce a German translation. IHO, Mathieus patch would be more flexible for new translations. Marc -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11459 --- Comment #9 from Galen Charlton <gmcharlt@gmail.com> --- (In reply to Marc Véron from comment #8)
11828 will introduce a German translation.
IHO, Mathieus patch would be more flexible for new translations.
Can you say why you think that? In both cases, the list of options is subject to exactly the same translation tools, but my patch makes the display both more concise and less likely for a user to make an error that would break basketgroup printing. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11459 --- Comment #10 from Marc Véron <veron@veron.ch> --- I agree that the drop down list would be more user friendly. What I wanted to say is that without the drop down list it would be easier to add other templates by just adding the files. And imagine that each and every of the Koha languages would have it's own template(s). That would give a very long drop down list. BTW I tested an non-existing template (pdfformat::layout2pagesxx). It simply leads to an error message while printing: "Invalid PDF Format set - Please go to the systempreferences and set a valid pdfformat" -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11459 --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Adding the files is not enough - for security reasons the valid pdf formats are currently hardcoded into basketgroup.pl. So touching the code is always needed in some way to add another template currently. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11459 --- Comment #12 from Galen Charlton <gmcharlt@gmail.com> --- (In reply to Marc Véron from comment #10)
I agree that the drop down list would be more user friendly.
OK
What I wanted to say is that without the drop down list it would be easier to add other templates by just adding the files.
Katrin has addressed this point.
And imagine that each and every of the Koha languages would have it's own template(s). That would give a very long drop down list.
I am very dubious whether that is a real possibility, considering that it's been more more than four years since the feature was originally introduced, and only now is somebody adding support for a third language. In fact, I really hope that we have a better templating system in place long before somebody contemplates adding a fourth language, as requiring a user to change Perl code and binary files to customize their printed purchase orders is, to put it mildly, less than ideal.
BTW I tested an non-existing template (pdfformat::layout2pagesxx). It simply leads to an error message while printing: "Invalid PDF Format set - Please go to the systempreferences and set a valid pdfformat"
That still counts as broken. Better to constrain the user to options that are guaranteed to work. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11459 --- Comment #13 from Marc Véron <veron@veron.ch> --- I was not aware of the hard coding in basketgroup.pl So let's go ahead - Sign off follows. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11459 --- Comment #14 from mathieu saby <mathsabypro@gmail.com> --- Hello I wrote something for allowing customized basketgroup. It failed: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10135 By the way, the current system (using perl for the pdf, and not a html template) is a nightmare. This bug was only to make the description of the syspref a bit more understandable for the average librarian ;-) Mathieu -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11459 --- Comment #15 from mathieu saby <mathsabypro@gmail.com> --- (in my library we made our own template - this was before a french template was available - so, we had to write a local patch for allowing koha to use a non-standard template) Mathieu -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11459 --- Comment #16 from Marc Véron <veron@veron.ch> --- Created attachment 25713 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25713&action=edit [Signed-off] Bug 11459: use drop-down to set OrderPdfFormat syspref This patch converts the OrderPdfFormat to a choice. To test: [1] Look at OrderPdfFormat in the system preferences editor. Verify that there is a drop-down giving a choice among the three PDF basketgroup printing formats. [2] Change the OrderPdfFormat setting and print a basketgroup. Verify that the chosen template is used. Signed-off-by: Galen Charlton <gmc@esilibrary.com> I followed the test plan. Patch behaves as expected. Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11459 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Signed Off --- Comment #17 from Galen Charlton <gmcharlt@gmail.com> --- Sounds like we have an agreement, so I'm setting this to signed-off. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11459 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25670|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11459 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25569|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11459 --- Comment #18 from Marc Véron <veron@veron.ch> --- Thanks, Galen. I did not set it to "Signed off" because it was "In Discussion". Marc -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11459 --- Comment #19 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 26205 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26205&action=edit [PASSED QA] Bug 11459: use drop-down to set OrderPdfFormat syspref This patch converts the OrderPdfFormat to a choice. To test: [1] Look at OrderPdfFormat in the system preferences editor. Verify that there is a drop-down giving a choice among the three PDF basketgroup printing formats. [2] Change the OrderPdfFormat setting and print a basketgroup. Verify that the chosen template is used. Signed-off-by: Galen Charlton <gmc@esilibrary.com> I followed the test plan. Patch behaves as expected. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Improves usability of the OrderPdfFormat system preference. Works as described, only changes YAML file. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11459 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|String patch |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11459 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25713|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11459 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #20 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11459 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@biblibre.co | |m --- Comment #21 from Jonathan Druart <jonathan.druart@biblibre.com> --- This change is quite confusing if you have a customized pdf, the selected value is the first one of the dropdown list. Which is different from the value in the DB. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11459 --- Comment #22 from Jonathan Druart <jonathan.druart@biblibre.com> --- I should have read the discussion before raising something already discussed. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11459 Fridolin SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |fridolyn.somers@biblibre.co | |m --- Comment #23 from Fridolin SOMERS <fridolyn.somers@biblibre.com> --- Pushed to 3.14.x, will be in 3.14.08 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11459 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com --- Comment #24 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to 3.12.x will be in 3.12.13 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org