http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11832 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 25590 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25590&action=edit Bug 11832 - JavaScript error on staff client place hold screen if record has no items If a hold operation is blocked because the title has no items attached the patron search autocomplete JavaScript triggers an error. This patch modifies the template so that the JS is loaded only when items are present. To test, find a title which has no items attached. View the holds page for that title. There should be no JavaScript error. Patron search autocomplete should still work correctly for titles which have items attached. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11832 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25590|0 |1 is obsolete| | --- Comment #2 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 25719 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25719&action=edit [SIGNED OFF] Bug 11832 - JavaScript error on staff client place hold screen if record has no items If a hold operation is blocked because the title has no items attached the patron search autocomplete JavaScript triggers an error. This patch modifies the template so that the JS is loaded only when items are present. To test, find a title which has no items attached. View the holds page for that title. There should be no JavaScript error. Patron search autocomplete should still work correctly for titles which have items attached. Deleted all items from a biblio record. Clicked the holds tab and confirmed using firebug Javascript error occurs. Applied patch, confirmed that the Javascript error described in comment 1 no longer happens. Went to another biblio with items, and confirmed patron auto-complete still functions. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11832 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25719|0 |1 is obsolete| | --- Comment #3 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 26183 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26183&action=edit Bug 11832 - JavaScript error on staff client place hold screen if record has no items If a hold operation is blocked because the title has no items attached the patron search autocomplete JavaScript triggers an error. This patch modifies the template so that the JS is loaded only when items are present. To test, find a title which has no items attached. View the holds page for that title. There should be no JavaScript error. Patron search autocomplete should still work correctly for titles which have items attached. Deleted all items from a biblio record. Clicked the holds tab and confirmed using firebug Javascript error occurs. Applied patch, confirmed that the Javascript error described in comment 1 no longer happens. Went to another biblio with items, and confirmed patron auto-complete still functions. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11832 --- Comment #4 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Indentation in reserve.tt is horrible; so checking this by glancing through template and script is not trivial. At the same time item refers to a patron in autocomplete to make the obscurity complete too :) Verified that it works. Passed QA -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11832 Fridolin SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |fridolyn.somers@biblibre.co | |m --- Comment #6 from Fridolin SOMERS <fridolyn.somers@biblibre.com> --- Pushed to 3.14.x, will be in 3.14.08 -- You are receiving this mail because: You are watching all bug changes.