[Bug 38350] New: Fix style of sidebar form clear buttons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38350 Bug ID: 38350 Summary: Fix style of sidebar form clear buttons Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Keywords: Academy Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: testopia@bugs.koha-community.org In cases where sidebar forms have a submit button alongside a clear button, the submit button is supposed to be larger than the clear button. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38350 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38350 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38350 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 173938 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173938&action=edit Bug 38350: Fix style of sidebar form clear buttons This patch fixes markup and CSS for sidebar form which contain a submit button and a clear button. The submit button is supposed to be wider than the clear button for visual emphasis. To test, apply the patch and rebuild the staff interface CSS. - Go to Patrons and confirm that the sidebar filter form looks correct. If necessary, resize your browser window to confirm that the "Search" button expands as the page gets wider. Confirm that the clear button works as expected. - Perform the same tests on these pages: - Acquisitions -> Vendor -> Receive shipments - ILL requests - Guided reports -> Saved reports Sponsored-by: Athens County Public Libraries -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38350 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |Laura.escamilla@bywatersolu | |tions.com --- Comment #2 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Ran into some merge issues Bug 38350 - Fix style of sidebar form clear buttons 173938 - Bug 38350: Fix style of sidebar form clear buttons Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 38350: Fix style of sidebar form clear buttons Using index info to reconstruct a base tree... M koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss M koha-tmpl/intranet-tmpl/prog/en/includes/patron-search.inc M koha-tmpl/intranet-tmpl/prog/en/modules/acqui/parcels.tt M koha-tmpl/intranet-tmpl/prog/en/modules/ill/ill-requests.tt M koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt M koha-tmpl/intranet-tmpl/prog/js/ill-list-table.js Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/js/ill-list-table.js Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/ill/ill-requests.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/acqui/parcels.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/includes/patron-search.inc Auto-merging koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38350 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38350 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #173938|0 |1 is obsolete| | --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 175092 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175092&action=edit Bug 38350: Fix style of sidebar form clear buttons This patch fixes markup and CSS for sidebar form which contain a submit button and a clear button. The submit button is supposed to be wider than the clear button for visual emphasis. To test, apply the patch and rebuild the staff interface CSS. - Go to Patrons and confirm that the sidebar filter form looks correct. If necessary, resize your browser window to confirm that the "Search" button expands as the page gets wider. Confirm that the clear button works as expected. - Perform the same tests on these pages: - Acquisitions -> Vendor -> Receive shipments - ILL requests - Guided reports -> Saved reports Sponsored-by: Athens County Public Libraries -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38350 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38350 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175092|0 |1 is obsolete| | --- Comment #4 from David Nind <david@davidnind.com> --- Created attachment 175236 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175236&action=edit Bug 38350: Fix style of sidebar form clear buttons This patch fixes markup and CSS for sidebar form which contain a submit button and a clear button. The submit button is supposed to be wider than the clear button for visual emphasis. To test, apply the patch and rebuild the staff interface CSS. - Go to Patrons and confirm that the sidebar filter form looks correct. If necessary, resize your browser window to confirm that the "Search" button expands as the page gets wider. Confirm that the clear button works as expected. - Perform the same tests on these pages: - Acquisitions -> Vendor -> Receive shipments - ILL requests - Guided reports -> Saved reports Sponsored-by: Athens County Public Libraries Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38350 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This fixes the markup and release notes| |CSS for sidebar forms that | |contain a submit button and | |a clear button (for | |example, the patrons and | |ILL requests sidebars). The | |submit button is now wider | |than the clear button for | |visual emphasis. CC| |david@davidnind.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38350 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38350 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175236|0 |1 is obsolete| | --- Comment #5 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 175445 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175445&action=edit Bug 38350: Fix style of sidebar form clear buttons This patch fixes markup and CSS for sidebar form which contain a submit button and a clear button. The submit button is supposed to be wider than the clear button for visual emphasis. To test, apply the patch and rebuild the staff interface CSS. - Go to Patrons and confirm that the sidebar filter form looks correct. If necessary, resize your browser window to confirm that the "Search" button expands as the page gets wider. Confirm that the clear button works as expected. - Perform the same tests on these pages: - Acquisitions -> Vendor -> Receive shipments - ILL requests - Guided reports -> Saved reports Sponsored-by: Athens County Public Libraries Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38350 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38350 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |25.05.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38350 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 25.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38350 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wainuiwitikapark@catalyst.n | |et.nz --- Comment #7 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- This is in the commit log for 24.11, though not noted here yet. Not backporting to 24.05.x unless requested -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38350 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@openfifth.c | |o.uk Version(s)|25.05.00 |25.05.00, 24.11.02 released in| | Status|Pushed to main |Pushed to stable --- Comment #8 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- This was pushed for 24.11.02 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38350 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Needs documenting --- Comment #9 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 22.11.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org