[Bug 38367] New: offset is wrong on plugins-disabled.tt page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38367 Bug ID: 38367 Summary: offset is wrong on plugins-disabled.tt page Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff interface Assignee: koha-bugs@lists.koha-community.org Reporter: lucas@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com To recreate: 1. Go to your koha-conf.xml and turn plugins off: <enable_plugins>0</enable_plugins> 2. Go to Administration -> Plugins 3. The text is not correctly offset. ( Bootstrap class is col-sm-offset-3 and should be offset-sm-3 in Bootstrap 5 ) ` -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38367 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |trivial Patch complexity|--- |Trivial patch Assignee|koha-bugs@lists.koha-commun |lucas@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38367 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38367 --- Comment #1 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 174055 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174055&action=edit Bug 38367: Fix offset on plugin-dsiabled.tt To test: 1. Go to your koha-conf.xml and turn plugins off: <enable_plugins>0</enable_plugins> 2. Go to Administration -> Plugins 3. The text is not correctly offset. ( Bootstrap class is col-sm-offset-3 and should be offset-sm-3 in Bootstrap 5 ) 4. APPLY PATCH 5. Try again, the offset should look right. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38367 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38367 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- The updated markup has "col-sm-6 offset-sm-3 col-md-6 col-md-offset-3", which still includes the old "col-md-offset-3" class. The previous markup was redundant, because it's the same width and the same offset for both the sm and md breakpoint. We could make it simply "col-sm-6 offset-sm-3" or include a different breakpoint for md, e.g. "col-sm-6 offset-sm-3 col-md-10 offset-md-1" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38367 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38367 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174055|0 |1 is obsolete| | --- Comment #3 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 174085 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174085&action=edit Bug 38367: Fix offset on plugin-dsiabled.tt To test: 1. Go to your koha-conf.xml and turn plugins off: <enable_plugins>0</enable_plugins> 2. Go to Administration -> Plugins 3. The text is not correctly offset. ( Bootstrap class is col-sm-offset-3 and should be offset-sm-3 in Bootstrap 5 ) 4. APPLY PATCH 5. Try again, the offset should look right. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38367 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #4 from David Nind <david@davidnind.com> --- I had a go at testing, but I can't get this to work. If you set <enable_plugins>0</enable_plugins>, then there is no Administration
Plugins.
Could you please update the test plan to reflect how to replicate/demonstrate the issue? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38367 --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- You have to navigate directly to http://127.0.0.1:8081/cgi-bin/koha/plugins/plugins-home.pl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38367 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38367 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174085|0 |1 is obsolete| | --- Comment #6 from David Nind <david@davidnind.com> --- Created attachment 175033 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175033&action=edit Bug 38367: Fix offset on plugin-dsiabled.tt To test: 1. Go to your koha-conf.xml and turn plugins off: <enable_plugins>0</enable_plugins> 2. Go to Administration -> Plugins 3. The text is not correctly offset. ( Bootstrap class is col-sm-offset-3 and should be offset-sm-3 in Bootstrap 5 ) 4. APPLY PATCH 5. Try again, the offset should look right. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38367 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This fixes the display of release notes| |the plugins page, when | |plugins are disabled in | |koha-conf.xml and the page | |is accessed directly. The | |message that plugins are | |disabled is now indented, | |instead of aligned to the | |far left. --- Comment #7 from David Nind <david@davidnind.com> --- (In reply to Owen Leonard from comment #5)
You have to navigate directly to http://127.0.0.1:8081/cgi-bin/koha/plugins/plugins-home.pl
Thanks Owen! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38367 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38367 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175033|0 |1 is obsolete| | --- Comment #8 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 175439 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175439&action=edit Bug 38367: Fix offset on plugin-dsiabled.tt To test: 1. Go to your koha-conf.xml and turn plugins off: <enable_plugins>0</enable_plugins> 2. Go to Administration -> Plugins 3. The text is not correctly offset. ( Bootstrap class is col-sm-offset-3 and should be offset-sm-3 in Bootstrap 5 ) 4. APPLY PATCH 5. Try again, the offset should look right. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38367 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38367 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |25.05.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38367 --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 25.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38367 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wainuiwitikapark@catalyst.n | |et.nz --- Comment #10 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- This is in the commit log for 24.11, though not noted here yet. Not backporting to 24.05.x unless requested -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38367 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|25.05.00 |25.05.00, 24.11.02 released in| | Status|Pushed to main |Pushed to stable CC| |martin.renvoize@openfifth.c | |o.uk --- Comment #11 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- This was pushed for 24.11.02 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38367 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Needs documenting --- Comment #12 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 22.11. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org