[Bug 9877] New: Use DataTables on funds administration page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9877 Bug ID: 9877 Summary: Use DataTables on funds administration page Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All URL: /cgi-bin/koha/admin/aqbudgets.pl OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org The funds administration page uses the old tablesorter plugin. It should use the DataTables plugin instead. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9877 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9877 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 16557 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16557&action=edit Bug 9877 - Use DataTables on funds administration page Replace the tablesorter plugin with the DataTables plugin on the funds administration page. To test, open the funds administration page (Administration -> Funds). Confirm that table sorting, paging, and searching works correctly. Note that the table is sorted only when hierarchical display of parent and child funds is not enabled. When the hierarchicial display is enabled the table sorter is not triggered. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9877 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |paul.poulain@biblibre.com --- Comment #2 from Paul Poulain <paul.poulain@biblibre.com> --- Patch tested with a sandbox, by Pierre Angot <tredok.pierre@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9877 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16557|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9877 --- Comment #3 from Paul Poulain <paul.poulain@biblibre.com> --- Created attachment 16575 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16575&action=edit Bug 9877 - Use DataTables on funds administration page Replace the tablesorter plugin with the DataTables plugin on the funds administration page. To test, open the funds administration page (Administration -> Funds). Confirm that table sorting, paging, and searching works correctly. Note that the table is sorted only when hierarchical display of parent and child funds is not enabled. When the hierarchicial display is enabled the table sorter is not triggered. Signed-off-by: Pierre Angot <tredok.pierre@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9877 --- Comment #4 from Paul Poulain <paul.poulain@biblibre.com> --- Patch tested with a sandbox, by Pierre Angot <tredok.pierre@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9877 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16575|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9877 --- Comment #5 from Paul Poulain <paul.poulain@biblibre.com> --- Created attachment 16581 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16581&action=edit Bug 9877 - Use DataTables on funds administration page Replace the tablesorter plugin with the DataTables plugin on the funds administration page. To test, open the funds administration page (Administration -> Funds). Confirm that table sorting, paging, and searching works correctly. Note that the table is sorted only when hierarchical display of parent and child funds is not enabled. When the hierarchicial display is enabled the table sorter is not triggered. Signed-off-by: Pierre Angot <tredok.pierre@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9877 --- Comment #6 from Paul Poulain <paul.poulain@biblibre.com> --- Patch tested with a sandbox, by Pierre Angot <tredok.pierre@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9877 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16581|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9877 --- Comment #7 from Paul Poulain <paul.poulain@biblibre.com> --- Created attachment 16582 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16582&action=edit Bug 5342: Followup Delete tags for letters which are not html Signed-off-by: Pierre Angot <tredok.pierre@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9877 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16582|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9877 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16581|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9877 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |jonathan.druart@biblibre.co | |m --- Comment #8 from Jonathan Druart <jonathan.druart@biblibre.com> --- QA comment: If I use the filter "Library" on the left and there is no result in the table, I got a DT error: "DataTables warning (table id = 'budgeth'): Requested unknown parameter '1' from the data source for row 0" Marked as Failed QA. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9877 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9877 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9877 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16581|0 |1 is obsolete| | --- Comment #9 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 16818 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16818&action=edit [SIGNED-OFF] Bug 9877 - Use DataTables on funds administration page Replace the tablesorter plugin with the DataTables plugin on the funds administration page. To test, open the funds administration page (Administration -> Funds). Confirm that table sorting, paging, and searching works correctly. Note that the table is sorted only when hierarchical display of parent and child funds is not enabled. When the hierarchicial display is enabled the table sorter is not triggered. Signed-off-by: Pierre Angot <tredok.pierre@gmail.com> Post-QA revision adds handling for empty table: "No funds" row must have same number of cells as the rest of the table (including hidden cell); -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9877 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #10 from Owen Leonard <oleonard@myacpl.org> --- Returning to 'signed off' after minor correction. QA please set to 'needs signoff' if you disagree. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9877 --- Comment #11 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 16936 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16936&action=edit Bug 9877: Followup: FIX if the table is empty. If there is no data, we don't display the table. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9877 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff --- Comment #12 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to comment #9)
Created attachment 16818 [details] [review] ... Post-QA revision adds handling for empty table: "No funds" row must have same number of cells as the rest of the table (including hidden cell);
I think we don't want to display the table if there is no data. Please sign-off my followup if you agree with that. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9877 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9877 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16936|0 |1 is obsolete| | --- Comment #13 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 17148 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17148&action=edit [SIGNED-OFF] Bug 9877: Followup: FIX if the table is empty. If there is no data, we don't display the table. Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9877 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Trivial patch QA Contact| |jonathan.druart@biblibre.co | |m --- Comment #14 from Jonathan Druart <jonathan.druart@biblibre.com> --- QA comment: Replace tablesorter with datatables on the funds admin page. Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9877 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16818|0 |1 is obsolete| | Attachment #17148|0 |1 is obsolete| | --- Comment #15 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 17155 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17155&action=edit Bug 9877 - Use DataTables on funds administration page Replace the tablesorter plugin with the DataTables plugin on the funds administration page. To test, open the funds administration page (Administration -> Funds). Confirm that table sorting, paging, and searching works correctly. Note that the table is sorted only when hierarchical display of parent and child funds is not enabled. When the hierarchicial display is enabled the table sorter is not triggered. Signed-off-by: Pierre Angot <tredok.pierre@gmail.com> Post-QA revision adds handling for empty table: "No funds" row must have same number of cells as the rest of the table (including hidden cell); Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9877 --- Comment #16 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 17156 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17156&action=edit Bug 9877: Followup: FIX if the table is empty. If there is no data, we don't display the table. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9877 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #17 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This patch has been pushed to master. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org