[Bug 5432] New: Duplicate patron feature
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5432 Summary: Duplicate patron feature Change sponsored?: Sponsored Product: Koha Version: rel_3_4 Platform: All URL: http://wiki.koha-community.org/wiki/Duplicate_card_but ton OS/Version: All Status: NEW Severity: enhancement Priority: P5 Component: Patrons AssignedTo: kyle.m.hall@gmail.com ReportedBy: paul.poulain@biblibre.com QAContact: koha-bugs@lists.koha-community.org CC: gmcharlt@gmail.com Estimated Hours: 0.0 New button to duplicate patron card. A new form with the duplicated values will open up and when the librarian will put his cursor on a field, the value will be erased so that he can write what he wants. Then the librarian save the new card. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5432 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz Blocks| |5575 -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5432 --- Comment #1 from Chris Cormack <chris@bigballofwax.co.nz> 2011-02-14 02:07:51 UTC --- Created attachment 3142 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=3142 Proposed Patch -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5432 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 |PATCH-Sent Patch Status|--- |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5432 --- Comment #2 from Nicole C. Engard <nengard@gmail.com> 2011-02-14 13:43:17 UTC --- Created attachment 3146 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=3146 duplicated patron I tested this patch, but I can't sign off on it. There are two issues that I see in the attached file. In the top left there is 'tast' string. Also the first name isn't carried over - which might be on purpose. Also there were a few whitespace errors: Apply? [y]es/[n]o/[e]dit/[v]iew patch/[a]ccept all y Applying Bug 5432 : (MT #4584b)Add duplicate support for borrowers .dotest/patch:124: trailing whitespace. <input type="text" id="initials" name="initials" size="20" value="<!-- TMPL_VAR NAME="initials" -->"<!--TMPL_IF NAME="opduplicate"--> onclick="this.value=''"<!-- /TMPL_IF --> /> .dotest/patch:252: trailing whitespace. <input type="text" id="email" name="email" size="45" value="<!-- TMPL_VAR NAME="email" -->"<!--TMPL_IF NAME="opduplicate"--> onclick="this.value=''"<!-- /TMPL_IF --> /> warning: 2 lines add whitespace errors. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5432 --- Comment #3 from Owen Leonard <oleonard@myacpl.org> 2011-02-14 15:32:15 UTC --- This patch modifies members-toolbar.inc but not circ-toolbar.inc. If we want to cover all patron-related pages we need to add the same modification to both (although the reasons for maintaining two includes my no longer be valid, something for another bug). -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5432 --- Comment #4 from Owen Leonard <oleonard@myacpl.org> 2011-02-14 15:36:48 UTC --- I think not carrying over the first name is correct behavior: You're duplicating the patron because you're creating a variation on that record, not a straight duplicate. For that reason, however, I think initials and other name should not carry over either--unless I misunderstand how these fields are used? -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5432 dev_patches@biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dev_patches@biblibre.com --- Comment #5 from dev_patches@biblibre.com 2011-02-14 16:18:45 UTC --- Use case is adding a member of the same family the same day.... Not wanting to re-enter all the fields. So have some kind of Help. Remeber other names and initials are not really used in France. So maybe this was not seen as a problem for us. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5432 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard@gmail.com Patch Status|Needs Signoff |Failed QA -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5432 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #3146|0 |1 is obsolete| | --- Comment #6 from Paul Poulain <paul.poulain@biblibre.com> 2011-03-01 21:08:53 UTC --- Created attachment 3232 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=3232 follow-up patch, removing test string -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5432 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Patch Status|Failed QA |Needs Signoff AssignedTo|kyle.m.hall@gmail.com |paul.poulain@biblibre.com --- Comment #7 from Paul Poulain <paul.poulain@biblibre.com> 2011-03-01 21:09:43 UTC --- pls sign-off -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5432 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Needs Signoff |Signed Off -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5432 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Signed Off |Patch Pushed --- Comment #8 from Chris Cormack <chris@bigballofwax.co.nz> 2011-03-05 07:26:27 UTC --- Pushed please test -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5432 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution| |FIXED --- Comment #9 from MJ Ray (software.coop) <mjr@ttllp.co.uk> 2011-03-06 12:09:55 UTC --- This bug is mentioned in: Bug 5432 : (MT #4584b)Add duplicate support for borrowers http://lists.koha-community.org/pipermail/koha-patches/2011-February/013846.... Bug 5432 : (MT #4584b)Add duplicate support for borrowers http://lists.koha-community.org/pipermail/koha-patches/2011-February/013959.... --- Comment #10 from Nicole C. Engard <nengard@gmail.com> 2011-03-06 14:04:15 UTC --- works lovely! -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5432 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jwagner@ptfs.com --- Comment #11 from Nicole C. Engard <nengard@gmail.com> 2011-03-07 18:21:01 UTC --- *** Bug 3475 has been marked as a duplicate of this bug. *** -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5432 --- Comment #12 from Owen Leonard <oleonard@myacpl.org> 2011-03-28 17:08:09 UTC --- *** Bug 2602 has been marked as a duplicate of this bug. *** -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5432 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|PATCH-Sent |P5 Status|RESOLVED |REOPENED Resolution|FIXED | --- Comment #13 from Owen Leonard <oleonard@myacpl.org> 2011-03-28 17:19:21 UTC --- circ-toolbar.inc should include the same modification so that all patron-related pages have the 'duplicate' button. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5432 --- Comment #14 from Owen Leonard <oleonard@myacpl.org> 2011-03-28 17:19:50 UTC --- Created attachment 3472 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=3472 Follow-up fix -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5432 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 |PATCH-Sent Patch Status|Patch Pushed |Signed Off -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5432 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Signed Off |Patch Pushed --- Comment #15 from Chris Cormack <chris@bigballofwax.co.nz> 2011-04-01 17:09:24 UTC --- Follow up pushed, please test -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5432 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice@biblibre.com --- Comment #16 from MJ Ray (software.coop) <mjr@ttllp.co.uk> 2011-04-04 08:09:57 UTC --- This bug is mentioned in: Follow-up fix for Bug 5432 - Duplicate patron feature http://lists.koha-community.org/pipermail/koha-patches/2011-March/014291.htm... Follow-up fix for Bug 5432 - Duplicate patron feature http://lists.koha-community.org/pipermail/koha-patches/2011-March/014286.htm... --- Comment #17 from Julian Maurice <julian.maurice@biblibre.com> 2011-04-05 12:01:51 UTC --- The 'Sort 1' field value is not erased when I put my cursor on it. Is this behavior normal? -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5432 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|PATCH-Sent |P5 CC| |katrin.fischer@bsz-bw.de Patch Status|Patch Pushed |--- Severity|enhancement |trivial --- Comment #18 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-08-05 18:36:17 UTC --- I can confirm the problem with the sort1 field on current master. I mark this reopened so this little bug doesn't get lost and can be addressed. The feature itself works. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5432 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #3142|0 |1 is obsolete| | -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5432 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #3232|0 |1 is obsolete| | -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5432 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #3472|0 |1 is obsolete| | -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5432 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|paul.poulain@biblibre.com |christophe.croullebois@bibl | |ibre.com --- Comment #19 from Paul Poulain <paul.poulain@biblibre.com> 2012-02-15 16:16:00 UTC --- Christophe, you've been randomly choosen to check if the problem is still here and provide a fix (see comment 17 and comment 18) -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5432 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.4 |master --- Comment #20 from Owen Leonard <oleonard@myacpl.org> --- The bug described in comment 17 still exists in master as of 3.12 beta1 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5432 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |Needs Signoff -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5432 --- Comment #21 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 16894 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16894&action=edit Bug 5432 [Follow-up] Duplicate patron feature It is noted in Bug 5432 that during a duplicate operation one field, 'Sort1' does not automatically clear when the cursor moves into it. This patch corrects this. Edit a patron record to have data in the Sort1 and Sort2 fields. Perform a duplicate operation on this patron and confirm that the Sort1 and Sort2 fields show the information from the original patron record. When you click on each field the contents should disappear. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5432 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16894|0 |1 is obsolete| | --- Comment #22 from David Cook <dcook@prosentient.com.au> --- Created attachment 17153 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17153&action=edit [SIGNED-OFF] Bug 5432 [Follow-up] Duplicate patron feature It is noted in Bug 5432 that during a duplicate operation one field, 'Sort1' does not automatically clear when the cursor moves into it. This patch corrects this. Edit a patron record to have data in the Sort1 and Sort2 fields. Perform a duplicate operation on this patron and confirm that the Sort1 and Sort2 fields show the information from the original patron record. When you click on each field the contents should disappear. Signed-off-by: David Cook <dcook@prosentient.com.au> Works as described. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5432 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |dcook@prosentient.com.au -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5432 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |jonathan.druart@biblibre.co | |m --- Comment #23 from Jonathan Druart <jonathan.druart@biblibre.com> --- Add the behavior for sort2 Marked as Passed QA. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5432 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17153|0 |1 is obsolete| | --- Comment #24 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 17154 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17154&action=edit Bug 5432 [Follow-up] Duplicate patron feature It is noted in Bug 5432 that during a duplicate operation one field, 'Sort1' does not automatically clear when the cursor moves into it. This patch corrects this. Edit a patron record to have data in the Sort1 and Sort2 fields. Perform a duplicate operation on this patron and confirm that the Sort1 and Sort2 fields show the information from the original patron record. When you click on each field the contents should disappear. Signed-off-by: David Cook <dcook@prosentient.com.au> Works as described. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5432 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |RESOLVED Resolution|--- |FIXED --- Comment #25 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- The latest patch has been moved onto bug 9981, and I am closing this bug. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org