[Bug 41516] New: Terminology: Change cardnumber to card number for system preference descriptions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41516 Bug ID: 41516 Summary: Terminology: Change cardnumber to card number for system preference descriptions Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Staff interface Assignee: koha-bugs@lists.koha-community.org Reporter: david@davidnind.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com Unless specifically referring to a database field, card number should be used (see the terminology guidelines (https://wiki.koha-community.org/wiki/Terminology#C). The descriptions for these three system preferences need updating to reflect this: - AutoSwitchPatron - CardnumberLog - SelfCheckoutByLogin -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41516 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy Patch complexity|--- |String patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41516 --- Comment #1 from Tom Yates <tom@hire-tom.co.uk> --- Created attachment 197985 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=197985&action=edit Bug 41516: Terminology: Change cardnumber to card number for system preference descriptions Following the terminology guidelines, the descriptions for AutoSwitchPatron, CardnumberLog and SelfCheckoutByLogin have been updated to use 'card number' with a space. Signed-off-by: Tom Yates <tom@hire-tom.co.uk> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41516 Tom Yates <tom@hire-tom.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff CC| |tom@hire-tom.co.uk -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41516 Andrew Auld <andrew.auld@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |tom@hire-tom.co.uk |ity.org | CC| |andrew.auld@openfifth.co.uk -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41516 OpenFifth Sandboxes <sandboxes@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #197985|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41516 --- Comment #2 from OpenFifth Sandboxes <sandboxes@openfifth.co.uk> --- Created attachment 198035 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198035&action=edit Bug 41516: Terminology: Change cardnumber to card number for system preference descriptions Following the terminology guidelines, the descriptions for AutoSwitchPatron, CardnumberLog and SelfCheckoutByLogin have been updated to use 'card number' with a space. Signed-off-by: Tom Yates <tom@hire-tom.co.uk> Signed-off-by: Andrew Auld <andrew.auld@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41516 Andrew Auld <andrew.auld@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #3 from Andrew Auld <andrew.auld@openfifth.co.uk> --- Nice work. Thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41516 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41516 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #198035|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41516 --- Comment #4 from David Nind <david@davidnind.com> --- Created attachment 198039 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198039&action=edit Bug 41516: Terminology: Change cardnumber to card number for system preference descriptions Following the terminology guidelines, the descriptions for AutoSwitchPatron, CardnumberLog and SelfCheckoutByLogin have been updated to use 'card number' with a space. Test plan: 1. Review the descriptions for the system preferences and note that 'cardnumber' is used, instead of 'card number' for: - AutoSwitchPatron - CardnumberLog - SelfCheckoutByLogin 2. Apply the patch. 3. Repeat step 1, and note that the system preferences now use 'card number'. Signed-off-by: Tom Yates <tom@hire-tom.co.uk> Signed-off-by: Andrew Auld <andrew.auld@openfifth.co.uk> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41516 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This fixes the system release notes| |preference descriptions for | |AutoSwitchPatron, | |CardnumberLog, and | |SelfCheckoutByLogin so that | |they use "card number" | |instead of "cardnumber" (as | |per the terminology | |guidelines). QA Contact|testopia@bugs.koha-communit |david@davidnind.com |y.org | --- Comment #5 from David Nind <david@davidnind.com> --- Thanks Tom and Andrew! Passed QA - script happy and everything looks good. I amended the commit message slightly to add a test plan, although this one is pretty straight forward (as per the commit message guidelines https://wiki.koha-community.org/wiki/Commit_messages) David -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41516 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |26.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41516 --- Comment #6 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 26.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41516 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|26.05.00 |26.05.00,25.11.05 released in| | Status|Pushed to main |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41516 --- Comment #7 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Thanks all, pushed to 25.11.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org