[Bug 31415] New: Script to automate converting reserves to recalls
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31415 Bug ID: 31415 Summary: Script to automate converting reserves to recalls Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: aleisha@catalyst.net.nz QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com If a record reaches X number of reserves, the library may convert reserves to recalls to prompt patrons to return them sooner. This can be automated with a script. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31415 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |aleisha@catalyst.net.nz |ity.org | Status|NEW |ASSIGNED Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31415 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |19532 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 [Bug 19532] Recalls for Koha -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31415 --- Comment #1 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 139440 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139440&action=edit Issue 1: First pass at script to automate converting to recall (cherry picked from commit d97c04e398b857e39aed4c10406dd9805d419d31) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31415 --- Comment #2 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 139441 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139441&action=edit Issue 1: Scheduling cron to convert recalls to reserves (cherry picked from commit 5af81d5a5adcce07adb93915bf94e76b3066d88c) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31415 --- Comment #3 from Aleisha Amohia <aleisha@catalyst.net.nz> --- This is a work in progress and is not ready for testing. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31415 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|19532 |31391 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 [Bug 19532] Recalls for Koha https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31391 [Bug 31391] Staff-side recalls -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31415 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139440|0 |1 is obsolete| | Attachment #139441|0 |1 is obsolete| | --- Comment #4 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 139646 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139646&action=edit Bug 31415: Script to automate converting reserves to recalls This is a work in progress and not ready for testing. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31415 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31415 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139646|0 |1 is obsolete| | --- Comment #5 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 139737 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139737&action=edit Bug 31415: Script to automate converting reserves to recalls This patch adds a script which can be used to automatically convert the oldest reserve on a record to a recall, if there are a specified minimum number of reserves on the record. To test: 1) Enable UseRecalls and configure circulation rules relevant to recalls. Keep the 'on shelf recalls allowed' setting to 'any' for the sake of testing ('all' would require all items to be checked out for the reserve to be converted to a recall) 2) Check out items from multiple records (at least 2 different records) to Patron A. 3) Place multiple reserves on each record (at least 2 reserves). 4) Place multiple reserves on another record which has no items checked out. 5) We now have multiple records where the oldest reserve is eligible for recall, plus a record where the oldest reserve is NOT eligible for recall (because no items are checked out). 6) In your terminal, get into the shell and run the script. -v means verbose and will print the reserves that are converted into recalls. --min 1 means there must be more than 1 reserve on the record to be considered. sudo koha-shell INSTANCE perl misc/cronjobs/recalls/convert_reserves_to_recalls.pl -v --min 1 7) Confirm that, for the records where items are checked out and there are multiple reserves, the oldest reserve was converted into a recall 8) Confirm that, for the record where no items are checked out, the reserves all remain and not converted into a recall. 9) Confirm documentation for the script looks good perldoc misc/cronjobs/recalls/convert_reserves_to_recalls.pl Sponsored-by: Auckland University of Technology -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31415 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This patch adds a script release notes| |which can be used to | |automatically convert the | |oldest reserve on a record | |to a recall, if there are a | |specified minimum number of | |reserves on the record. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31415 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31415 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139737|0 |1 is obsolete| | --- Comment #6 from David Nind <david@davidnind.com> --- Created attachment 145796 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145796&action=edit Bug 31415: Script to automate converting reserves to recalls This patch adds a script which can be used to automatically convert the oldest reserve on a record to a recall, if there are a specified minimum number of reserves on the record. To test: 1) Enable UseRecalls and configure circulation rules relevant to recalls. Keep the 'on shelf recalls allowed' setting to 'any' for the sake of testing ('all' would require all items to be checked out for the reserve to be converted to a recall) 2) Check out items from multiple records (at least 2 different records) to Patron A. 3) Place multiple reserves on each record (at least 2 reserves). 4) Place multiple reserves on another record which has no items checked out. 5) We now have multiple records where the oldest reserve is eligible for recall, plus a record where the oldest reserve is NOT eligible for recall (because no items are checked out). 6) In your terminal, get into the shell and run the script. -v means verbose and will print the reserves that are converted into recalls. --min 1 means there must be more than 1 reserve on the record to be considered. sudo koha-shell INSTANCE perl misc/cronjobs/recalls/convert_reserves_to_recalls.pl -v --min 1 7) Confirm that, for the records where items are checked out and there are multiple reserves, the oldest reserve was converted into a recall 8) Confirm that, for the record where no items are checked out, the reserves all remain and not converted into a recall. 9) Confirm documentation for the script looks good perldoc misc/cronjobs/recalls/convert_reserves_to_recalls.pl Sponsored-by: Auckland University of Technology Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31415 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |32776 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32776 [Bug 32776] Choose to convert oldest reserve or all possible reserves to recalls -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31415 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |kyle@bywatersolutions.com --- Comment #7 from Kyle M Hall <kyle@bywatersolutions.com> --- Easy to fix issue, can you please change usage of the word "reserve" to "hold" for consistency with Koha standard terminology: https://wiki.koha-community.org/wiki/Terminology#R -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31415 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31415 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145796|0 |1 is obsolete| | --- Comment #8 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 148112 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148112&action=edit Bug 31415: Script to automate converting holds to recalls This patch adds a script which can be used to automatically convert the oldest hold on a record to a recall, if there are a specified minimum number of holds on the record. To test: 1) Enable UseRecalls and configure circulation rules relevant to recalls. Keep the 'on shelf recalls allowed' setting to 'any' for the sake of testing ('all' would require all items to be checked out for the hold to be converted to a recall) 2) Check out items from multiple records (at least 2 different records) to Patron A. 3) Place multiple holds on each record (at least 2 holds). 4) Place multiple holds on another record which has no items checked out. 5) We now have multiple records where the oldest hold is eligible for recall, plus a record where the oldest hold is NOT eligible for recall (because no items are checked out). 6) In your terminal, get into the shell and run the script. -v means verbose and will print the holds that are converted into recalls. --min 1 means there must be more than 1 hold on the record to be considered. sudo koha-shell INSTANCE perl misc/cronjobs/recalls/convert_holds_to_recalls.pl -v --min 1 7) Confirm that, for the records where items are checked out and there are multiple holds, the oldest hold was converted into a recall 8) Confirm that, for the record where no items are checked out, the holds all remain and not converted into a recall. 9) Confirm documentation for the script looks good perldoc misc/cronjobs/recalls/convert_holds_to_recalls.pl Sponsored-by: Auckland University of Technology Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31415 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Script to automate |Script to automate |converting reserves to |converting holds to recalls |recalls | Text to go in the|This patch adds a script |This patch adds a script release notes|which can be used to |which can be used to |automatically convert the |automatically convert the |oldest reserve on a record |oldest hold on a record to |to a recall, if there are a |a recall, if there are a |specified minimum number of |specified minimum number of |reserves on the record. |holds on the record. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31415 Michal Denar <black23@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |black23@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31415 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |emmi.takkinen@koha-suomi.fi -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31415 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Status|Needs Signoff |Failed QA --- Comment #9 from David Nind <david@davidnind.com> --- I'm getting this error when running the script: perl misc/cronjobs/recalls/convert_holds_to_recalls.pl -v --min 1 DBIx::Class::Storage::DBI::_dbh_execute(): DBI Exception: DBD::mysql::st execute failed: Unknown column 'holddate' in 'order clause' at /kohadevbox/koha/Koha/Objects.pm line 394 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31415 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31415 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148112|0 |1 is obsolete| | --- Comment #10 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 157002 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157002&action=edit Bug 31415: Script to automate converting holds to recalls This patch adds a script which can be used to automatically convert the oldest hold on a record to a recall, if there are a specified minimum number of holds on the record. To test: 1) Enable UseRecalls and configure circulation rules relevant to recalls. Keep the 'on shelf recalls allowed' setting to 'any' for the sake of testing ('all' would require all items to be checked out for the hold to be converted to a recall) 2) Check out items from multiple records (at least 2 different records) to Patron A. 3) Place multiple holds on each record (at least 2 holds). 4) Place multiple holds on another record which has no items checked out. 5) We now have multiple records where the oldest hold is eligible for recall, plus a record where the oldest hold is NOT eligible for recall (because no items are checked out). 6) In your terminal, get into the shell and run the script. -v means verbose and will print the holds that are converted into recalls. --min 1 means there must be more than 1 hold on the record to be considered. sudo koha-shell INSTANCE perl misc/cronjobs/recalls/convert_holds_to_recalls.pl -v --min 1 7) Confirm that, for the records where items are checked out and there are multiple holds, the oldest hold was converted into a recall 8) Confirm that, for the record where no items are checked out, the holds all remain and not converted into a recall. 9) Confirm documentation for the script looks good perldoc misc/cronjobs/recalls/convert_holds_to_recalls.pl Sponsored-by: Auckland University of Technology Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31415 --- Comment #11 from David Nind <david@davidnind.com> --- I got this error message when testing again: perl misc/cronjobs/recalls/convert_holds_to_recalls.pl -v --min 1 No reserves HOLD_CANCELLATION letter transported by email at /kohadevbox/koha/C4/Letters.pm line 588. The method Koha::Hold->hold_id is not covered by tests! Trace begun at /kohadevbox/koha/Koha/Object.pm line 931 Koha::Object::AUTOLOAD('Koha::Hold=HASH(0x55b1c879dd50)') called at misc/cronjobs/recalls/convert_holds_to_recalls.pl line 129 Do I need to make sure email is set up and that each of the patrons have an email address? The records and patrons I used were from different libraries, not sure whether that should make a difference. Setup: 1. Recalls: . Recalls allowed (total): 5 . Recalls per record (count): 5 . On shelf recalls allowed: If any unavailable1 . Recall due date interval (day): 5 . Recall overdue fine amount: 5.00 . Recall pickup period (day): 5 2. Checked out 3 items to Mary Burton (Effective Perl (139 - item 296), Perl template toolkit (255 - item 564), Programming Perl (262 - item 578)) 3. Placed holds on these records: - Effective Perl (139): Bobbie Middleton, Henry Acevedo, Lisa Charles - Perl template toolkit (255): Henry Acevedo, Lisa Charles, Bobbie Middleton - Programming Perl (262): Henry Acevedo, Lisa Charles, Bobbie Middleton - The complete novels / Jane Austen (19): Mary Burton, Lisa Charles 4. After running the script, got the error above. One recall was made for: - Effective Perl: requested by Bobbie Middleton -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31415 --- Comment #12 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 159010 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159010&action=edit Bug 31415: Exclude found holds and fix hold ID call -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31415 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31415 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #157002|0 |1 is obsolete| | --- Comment #13 from David Nind <david@davidnind.com> --- Created attachment 159016 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159016&action=edit Bug 31415: Script to automate converting holds to recalls This patch adds a script which can be used to automatically convert the oldest hold on a record to a recall, if there are a specified minimum number of holds on the record. To test: 1) Enable UseRecalls and configure circulation rules relevant to recalls. Keep the 'on shelf recalls allowed' setting to 'any' for the sake of testing ('all' would require all items to be checked out for the hold to be converted to a recall) 2) Check out items from multiple records (at least 2 different records) to Patron A. 3) Place multiple holds on each record (at least 2 holds). 4) Place multiple holds on another record which has no items checked out. 5) We now have multiple records where the oldest hold is eligible for recall, plus a record where the oldest hold is NOT eligible for recall (because no items are checked out). 6) In your terminal, get into the shell and run the script. -v means verbose and will print the holds that are converted into recalls. --min 1 means there must be more than 1 hold on the record to be considered. sudo koha-shell INSTANCE perl misc/cronjobs/recalls/convert_holds_to_recalls.pl -v --min 1 7) Confirm that, for the records where items are checked out and there are multiple holds, the oldest hold was converted into a recall 8) Confirm that, for the record where no items are checked out, the holds all remain and not converted into a recall. 9) Confirm documentation for the script looks good perldoc misc/cronjobs/recalls/convert_holds_to_recalls.pl Sponsored-by: Auckland University of Technology Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31415 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159010|0 |1 is obsolete| | --- Comment #14 from David Nind <david@davidnind.com> --- Created attachment 159017 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159017&action=edit Bug 31415: Exclude found holds and fix hold ID call Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31415 --- Comment #15 from David Nind <david@davidnind.com> --- All looks good and now working as expected. The documentation looks fine to me. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31415 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |BLOCKED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31415 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Circulation| |recalls function| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31415 Danyon Sewell <danyonsewell@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |danyonsewell@catalyst.net.n | |z --- Comment #16 from Danyon Sewell <danyonsewell@catalyst.net.nz> --- Can this be moved to signed off now? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31415 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31415 --- Comment #17 from David Nind <david@davidnind.com> --- Note: dependent bug 31391 no longer applies. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org