[Bug 43536] New: Additional fields added to erm_agreement_periods appear in agreement as well as period
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43536 Bug ID: 43536 Summary: Additional fields added to erm_agreement_periods appear in agreement as well as period Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: ERM Assignee: jonathan.druart@gmail.com Reporter: caroline.cyr-la-rose@inlibro.com QA Contact: testopia@bugs.koha-community.org CC: jonathan.druart@gmail.com, jonathan.field@openfifth.co.uk, martin.renvoize@openfifth.co.uk, matt.blenkinsop@openfifth.co.uk, pedro.amorim@openfifth.co.uk Target Milestone: --- When adding an additional field to erm_agreement_period, it adds it to the agreement period section, but also in the agreement section itself. I'm not sure if this is on purpose or not, but it seems a bit confusing. To recreate : 1. Add an additional field for Agreement periods 1.1. Go to Administration > Additional fields 1.2. Click "Agreement periods (erm_agreement_periods)" 1.3. Click "New field" 1.4. Enter the name "Agreement period additional field" 1.5. Click "Save" 2. Add an additional field for Agreements 2.1. Go to Administration > Additional fields 2.2. Click "Agreements (erm_agreements)" 2.3. Click "New field" 2.4. Enter the name "Agreements additional field" 2.5. Click "Save" 3. Enable the ERM module 3.1. Go to Administration > System preferences 3.2. Search for ERMModule 3.3. Set ERMModule to Enable 3.4. Click Save all E-resource management preferences 4. Add an agreement 4.1. Go to E-resource management > Agreements 4.2. Click "New agreement" --> Note that in the first section, both additional fields are displayed 4.3. Click "Add new period" --> The additional field for agreement periods is displayed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43536 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |39438 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39438 [Bug 39438] Add additional fields to agreements periods -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43536 Bug 43536 depends on bug 39438, which changed state. Bug 39438 Summary: Add additional fields to agreements periods https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39438 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43536 Michaela Sieber <michaela.sieber@kit.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |CONFIRMED CC| |michaela.sieber@kit.edu -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43536 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|jonathan.druart@gmail.com |koha-bugs@lists.koha-commun | |ity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43536 Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|CONFIRMED |Needs Signoff Assignee|koha-bugs@lists.koha-commun |matt.blenkinsop@openfifth.c |ity.org |o.uk -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43536 --- Comment #1 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- Created attachment 206149 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206149&action=edit Bug 43536: Search for the specific resource type when retrieving additional fields Previously all types for the module were retrieved and then filtered using 'CONTAINS' logic. This meant that when retreiving agreement_period fields, any agreement fields would also satisfy that CONTAINS match. Test plan: 1. Add an additional field for Agreement periods 1.1. Go to Administration > Additional fields 1.2. Click "Agreement periods (erm_agreement_periods)" 1.3. Click "New field" 1.4. Enter the name "Agreement period additional field" 1.5. Click "Save" 2. Add an additional field for Agreements 2.1. Go to Administration > Additional fields 2.2. Click "Agreements (erm_agreements)" 2.3. Click "New field" 2.4. Enter the name "Agreements additional field" 2.5. Click "Save" 3. Enable the ERM module 3.1. Go to Administration > System preferences 3.2. Search for ERMModule 3.3. Set ERMModule to Enable 3.4. Click Save all E-resource management preferences 4. Add an agreement 4.1. Go to E-resource management > Agreements 4.2. Click "New agreement" --> Note that in the first section, only agreement additional fields are displayed 4.3. Click "Add new period" --> The additional field for agreement periods is displayed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43536 Hanna Dehlin <hanna.dehlin@hkr.se> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #206149|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43536 --- Comment #2 from Hanna Dehlin <hanna.dehlin@hkr.se> --- Created attachment 208566 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=208566&action=edit Bug 43536: Search for the specific resource type when retrieving additional fields Previously all types for the module were retrieved and then filtered using 'CONTAINS' logic. This meant that when retreiving agreement_period fields, any agreement fields would also satisfy that CONTAINS match. Test plan: 1. Add an additional field for Agreement periods 1.1. Go to Administration > Additional fields 1.2. Click "Agreement periods (erm_agreement_periods)" 1.3. Click "New field" 1.4. Enter the name "Agreement period additional field" 1.5. Click "Save" 2. Add an additional field for Agreements 2.1. Go to Administration > Additional fields 2.2. Click "Agreements (erm_agreements)" 2.3. Click "New field" 2.4. Enter the name "Agreements additional field" 2.5. Click "Save" 3. Enable the ERM module 3.1. Go to Administration > System preferences 3.2. Search for ERMModule 3.3. Set ERMModule to Enable 3.4. Click Save all E-resource management preferences 4. Add an agreement 4.1. Go to E-resource management > Agreements 4.2. Click "New agreement" --> Note that in the first section, only agreement additional fields are displayed 4.3. Click "Add new period" --> The additional field for agreement periods is displayed Signed-off-by: Hanna Dehlin <hanna.dehlin@hkr.se> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43536 Hanna Dehlin <hanna.dehlin@hkr.se> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #3 from Hanna Dehlin <hanna.dehlin@hkr.se> --- Signed off using a sandbox -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43536 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |lucas@bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43536 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #4 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Tests are failing here: ok 26 - 200 OK not ok 27 - exact match for JSON Pointer "" # Failed test 'exact match for JSON Pointer ""' # at /kohadevbox/koha/t/db_dependent/api/v1/extended_attribute_types.t line 253. # Structures begin differing at: # $got->[0]{marc_field} = 'DEbYc1Ao7u0tTLW' # $expected->[0]{marc_field} = 'agwGlZTxJSht89Q' ok 28 - GET //uN8yrBjp6ECRNlMb2mXmlMVPaUrN4KHrstr73kdgNQie:thePassword123@/api/v1/extended_attribute_types ok 29 - 403 Forbidden # Looks like you failed 1 test of 29. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org