[Bug 9064] New: statistics.ccode specified inconsistently
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9064 Priority: P5 - low Change sponsored?: --- Bug ID: 9064 Assignee: kyle@bywatersolutions.com Summary: statistics.ccode specified inconsistently Severity: blocker Classification: Unclassified OS: All Reporter: jcamins@cpbibliography.com Hardware: All Status: NEW Version: master Component: Architecture, internals, and plumbing Product: Koha
From updatedatabase.pl: $dbh->do("ALTER TABLE statistics ADD COLUMN ccode VARCHAR ( 10 ) NULL AFTER associatedborrower");
From kohastructure.sql: `ccode` int(11) default NULL, -- foreign key from the items table, links transaction to a specific collection code
I believe the variant in updatedatabase.pl is probably what was wanted. Also, further testing is needed to confirm that the update works at all, as it seems not to have run at all when I updated my system past 3.09.00.044. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9064 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |paul.poulain@biblibre.com Assignee|kyle@bywatersolutions.com |paul.poulain@biblibre.com --- Comment #1 from Paul Poulain <paul.poulain@biblibre.com> --- I'm on it, patch coming in a few minuts -- You are receiving this mail because: You are watching all bug changes.
From updatedatabase.pl: $dbh->do("ALTER TABLE statistics ADD COLUMN ccode VARCHAR ( 10 ) NULL AFTER associatedborrower"); From kohastructure.sql: `ccode` int(11) default NULL, -- foreign key from the items table, links
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9064 --- Comment #2 from Paul Poulain <paul.poulain@biblibre.com> --- Created attachment 13575 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13575&action=edit Bug 9064: fix statistics.ccode column transaction to a specific collection code The variant in updatedatabase.pl is probably what was wanted. This patch fixes the kohastructure and add another updatedatabase.pl, in case someone has a broken install. This should not happen, because 3.10.0 still not released, but just in case... -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9064 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #3 from Paul Poulain <paul.poulain@biblibre.com> --- I haven't investigated the 2nd part of jared description (Also, further testing is needed to confirm that the update works at all, as it seems not to have run at all when I updated my system past 3.09.00.044.) but this patch at least solves the 1st part ! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9064 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |P1 - high Version|master |3.10 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9064 --- Comment #4 from Paul Poulain <paul.poulain@biblibre.com> --- (In reply to comment #0)
Also, further testing is needed to confirm that the update works at all, as it seems not to have run at all when I updated my system past 3.09.00.044.
In my database there's no ccode. I've filled some manually, run the queries in the updatedatabase, and it worked well. The queries also seems correct & logic. Conclusion = I'm not sure the 2nd part of your description is relevant, more information welcomed if you really think we should investigate more. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9064 --- Comment #5 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- (In reply to comment #4)
(In reply to comment #0)
Also, further testing is needed to confirm that the update works at all, as it seems not to have run at all when I updated my system past 3.09.00.044.
In my database there's no ccode. I've filled some manually, run the queries in the updatedatabase, and it worked well.
The queries also seems correct & logic.
Conclusion = I'm not sure the 2nd part of your description is relevant, more information welcomed if you really think we should investigate more.
If the column was created in your database, we can just chalk it up to a momentary glitch on my system. The problem was not that the ccode column wasn't populated correctly. The problem was that the ccode column wasn't created at all. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9064 --- Comment #6 from Paul Poulain <paul.poulain@biblibre.com> --- (In reply to comment #5)
If the column was created in your database, we can just chalk it up to a momentary glitch on my system. The problem was not that the ccode column wasn't populated correctly. The problem was that the ccode column wasn't created at all.
yes, it was created on my system. Maybe, you already had the 044 revision, from a patch you'd tested previously, so the updatedatabase was skipped ? (thanks the new db update mechanism, that will solve this problem ;-) ) let's signoff the patch for the 1st problem then ! -- You are receiving this mail because: You are watching all bug changes.
From updatedatabase.pl: $dbh->do("ALTER TABLE statistics ADD COLUMN ccode VARCHAR ( 10 ) NULL AFTER associatedborrower"); From kohastructure.sql: `ccode` int(11) default NULL, -- foreign key from the items table, links
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9064 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #13575|0 |1 is obsolete| | --- Comment #7 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 13576 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13576&action=edit Bug 9064: fix statistics.ccode column transaction to a specific collection code The variant in updatedatabase.pl is probably what was wanted. This patch fixes the kohastructure and add another updatedatabase.pl, in case someone has a broken install. This should not happen, because 3.10.0 still not released, but just in case... Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9064 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9064 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@biblibre.co | |m See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=4118 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9064 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA QA Contact| |jonathan.druart@biblibre.co | |m --- Comment #8 from Jonathan Druart <jonathan.druart@biblibre.com> --- Modify a wrong DB structure Passed QA. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9064 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |jcamins@cpbibliography.com --- Comment #9 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This patch has been pushed to master. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9064 --- Comment #10 from Paul Poulain <paul.poulain@biblibre.com> --- Patch pushed to branch 3.10.x -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9064 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED CC| |chris@bigballofwax.co.nz Resolution|--- |FIXED --- Comment #11 from Chris Cormack <chris@bigballofwax.co.nz> --- Released in 3.10.0 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9064 stiv <storme1000@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |storme1000@gmail.com --- Comment #12 from stiv <storme1000@gmail.com> --- Created attachment 40431 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40431&action=edit Add an attachment -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9064 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org