[Bug 10550] New: Fix database typo wthdrawn
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10550 Bug ID: 10550 Summary: Fix database typo wthdrawn Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt@gmail.com Reporter: katrin.fischer@bsz-bw.de Citing Galen's mail from May 22nd: However, now that we're at the very beginning of the 3.14 cycle, the window is now open for the sort of patch that offers cosmetic or textual improvement but which also happens to touch a lot of code. If there are longstanding typos you want to fix (my "favorite" is the wthdrawn column in the items table), now is your chance. I'm not setting a definite end to the window at this point, but suffice it to say that I will be much more likely to merge such patches now as opposed to three months from now. Time is running ;) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10550 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Assignee|gmcharlt@gmail.com |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10550 --- Comment #1 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 19480 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19480&action=edit Bug 10550 - Fix database typo wthdrawn This patch updates the wthdrawn field in items and deleteditems to be withdrawn instead. No functional changes are made. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10550 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10550 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19480|0 |1 is obsolete| | --- Comment #2 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 19481 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19481&action=edit Bug 10550 - Fix database typo wthdrawn This patch updates the wthdrawn field in items and deleteditems to be withdrawn instead. No functional changes are made. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10550 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |9673 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10550 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|9673 | Depends on| |9673 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10550 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |9673 Depends on|9673 | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10550 --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Should we also be nice and update saved reports using wthdrawn? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10550 --- Comment #4 from Kyle M Hall <kyle@bywatersolutions.com> --- I think that's a good and sensible idea! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10550 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19481|0 |1 is obsolete| | --- Comment #5 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 19502 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19502&action=edit Bug 10550 - Fix database typo wthdrawn This patch updates the wthdrawn field in items and deleteditems to be withdrawn instead. No functional changes are made. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10550 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel@gmail.com --- Comment #6 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Kyle, all seems allright, but on loaded frameworks we still have incorrect values, I think we need something like UPDATE marc_subfield_structure SET kohafield = 'items.withdrawn' WHERE kohafield = 'items.wthdrawn'; Regards -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10550 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Thx Bernardo for spotting this! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10550 --- Comment #8 from Kyle M Hall <kyle@bywatersolutions.com> --- Indeed, good catch! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10550 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10550 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19502|0 |1 is obsolete| | --- Comment #9 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 20178 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20178&action=edit Bug 10550 - Fix database typo wthdrawn This patch updates the wthdrawn field in items and deleteditems to be withdrawn instead. No functional changes are made. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10550 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20178|0 |1 is obsolete| | --- Comment #10 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 20179 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20179&action=edit [SIGNED-OFF] Bug 10550 - Fix database typo wthdrawn This patch updates the wthdrawn field in items and deleteditems to be withdrawn instead. No functional changes are made. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Comment: Save for translation files (that will be fixed on next release), only occurrence of wthdrawn is on updatedatabase.pl No koha-qa errors. This touch many files, and I did not test everything, but all seems normal. I think that any problem could be fixed later. Perhaps both entries in updatedatabase.pl could be joined into one, but thats for QA. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10550 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10550 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |jonathan.druart@biblibre.co | |m QA Contact| |jonathan.druart@biblibre.co | |m --- Comment #11 from Jonathan Druart <jonathan.druart@biblibre.com> --- QA comment: All looks good. Note that 1 authorized value named "WTHDRAWN" still exists. Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10550 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20179|0 |1 is obsolete| | --- Comment #12 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 20457 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20457&action=edit Bug 10550 - Fix database typo wthdrawn This patch updates the wthdrawn field in items and deleteditems to be withdrawn instead. No functional changes are made. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Comment: Save for translation files (that will be fixed on next release), only occurrence of wthdrawn is on updatedatabase.pl No koha-qa errors. This touch many files, and I did not test everything, but all seems normal. I think that any problem could be fixed later. Perhaps both entries in updatedatabase.pl could be joined into one, but thats for QA. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10550 --- Comment #13 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 20458 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20458&action=edit Bug 10550: Merge 2 updatedatabase entries into 1 Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10550 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt@gmail.com --- Comment #14 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master, along with a couple follow-ups. Thanks, Kyle! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10550 --- Comment #15 from Jonathan Druart <jonathan.druart@biblibre.com> --- Added to qa tools: commit c90d0c5e5436daec23d2c6e21e5759e8344ad1f5 Author: Jonathan Druart <jonathan.druart@biblibre.com> AuthorDate: Mon Sep 9 09:45:10 2013 +0200 wthdrawn is a typo (see bug 10550). -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10550 --- Comment #16 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Thx Jonathan! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10550 Fridolin SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |12871 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10550 Nicholas van Oudtshoorn <vanoudt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |vanoudt@gmail.com --- Comment #17 from Nicholas van Oudtshoorn <vanoudt@gmail.com> --- Just to note that the MARC frameworks on the wiki ( http://wiki.koha-community.org/wiki/MARC_frameworks ) weren't updated with this bug. It's now done. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10550 --- Comment #18 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Thx Nicholas! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org