[Bug 35138] New: Elastic search - add new facets
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35138 Bug ID: 35138 Summary: Elastic search - add new facets Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching - Elasticsearch Assignee: koha-bugs@lists.koha-community.org Reporter: michaela.sieber@kit.edu We would like to create a new facet for a 9xx-MARC field As Nick mentioned in Bug 18235, Comment 7: -labels shouldn't be hardcoded - staff should be able to set them -we should add more options to what can be faceted- could be out of control but technically any field should be able to be used -ES has better handling for faceting (can provide subsets of existing/current results and allow to step in/out of facets) Problems / Challenges: 1. Translatability: if staff changes or add new labels, they will not be translated 2. same files for elastic and Zebra -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35138 Michaela Sieber <michaela.sieber@kit.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |18235 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235 [Bug 18235] Elastic search - Configurable facets -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35138 Emmanuel Bétemps <e.betemps@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |e.betemps@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35138 Michaela Sieber <michaela.sieber@kit.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |clemens.tubach@kit.edu, | |jonathan.druart@gmail.com, | |lukasz.koszyk@kit.edu Change sponsored?|--- |Seeking developer -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35138 --- Comment #1 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 163133 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163133&action=edit Bug 35138: Make ES facetable fields configurable - POC Move the ES facet fields that are currently hardcoded in the codebase to a new ES_FACETS authorised value category. Librarians can then add/remove facet fields and modify their lib/description. Remaining work: 1. Adjust OPAC templates 2. AV is not ideal here, we should certainly have a dedicated DB table for that. It will bring more flexibility. We can image: * display or not (could be opac/staff/both/none) * define the size per field (number of facet to display) * order: move search_field.facet_order to this new table. In my testing this is not worker, they are displayed alpha (??) 3. Adjust the UI Still no translatability however. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35138 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35138 --- Comment #2 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to Jonathan Druart from comment #1)
Still no translatability however.
Translating using JS should be trivial as there will be an id on the label: facets.inc <span id="facet-[% facets_loo.type_link_value | html %]">[% facets_loo.label | html %]</span> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35138 --- Comment #3 from Michaela Sieber <michaela.sieber@kit.edu> --- Thanks Jonathan for your proof of concept. We testet the patch that uses an authorized value for the configuration of ElasticSearch facets. Everything in the patch worked as expected. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35138 --- Comment #4 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to Jonathan Druart from comment #1)
* order: move search_field.facet_order to this new table. In my testing this is not worker, they are displayed alpha (??)
*not working* It's actually broken in master but is going to be fixed by bug 36190. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35138 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs@lists.koha-commun |jonathan.druart@gmail.com |ity.org | Depends on| |35249 Change sponsored?|Seeking developer |Sponsored Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35249 [Bug 35249] Use DataTables RowReorder extension instead of tableDND jQuery plugin -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35138 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Elastic search - add new |Elasticsearch - manage |facets |facets -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35138 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |36394 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36394 [Bug 36394] Inconsistent behaviour in footers (mappings admin page) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35138 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |20388 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 [Bug 20388] Elasticsearch - Ability to add search fields from UI -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35138 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |36396 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36396 [Bug 36396] Link facet with authorised value category -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35138 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35138 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #163133|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 163680 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163680&action=edit Bug 35138: Add the ability to manage ES facets This new feature allows to manage facets for Elasticsearch from the administration page. Prior to this the facet fields were hardcoded in the codebase. Librarians can then add/remove facet fields and modify their label. Test plan: 1. Create a new search field and set it a label different than its name. 2. Save 3. Go the bibliographic mapping tab 4. Add 1+ mapping for this search field (Searchable and facetable must be "Yes") 5. Add, reorder, remove new facets 6. Save and reindex your records 7. Search and notice the new facet list QA: There are several wrong things in this area (ES + facets code, everything, pm, pl, tt AND on this administration page). I have done my best to clean the code as much as I could and keep the code cleaner after than before. But there are still a lot to do. There are still inconsistencies on this page (like we need to save to see the changes applied to the other tables), but this is clearly out of the scope of this bug report. Another enhancement would be to move the facet list to a different DB table, that could bring more flexibility: * display or not (could be opac/staff/both/none) * define the size per field (number of facet to display) * order: move search_field.facet_order to this new table. But, again, it's a lot more work. More work is done in this area, please see related bug reports. Sponsored-by: The Research University in the Helmholtz Association (KIT) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35138 --- Comment #6 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 163681 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163681&action=edit Bug 35138: Adjust existing data We want the label from the DB displayed on the UI so we are adjusting the yaml and the DB. Sponsored-by: The Research University in the Helmholtz Association (KIT) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35138 --- Comment #7 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 163682 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163682&action=edit Bug 35138: Mark DisplayLibraryFacets as zebra only We can know add/remove homelibrary and holdinglibray from the config page, this syspref is no longer needed for ES Sponsored-by: The Research University in the Helmholtz Association (KIT) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35138 --- Comment #8 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 163683 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163683&action=edit Bug 35138: UI changes to add/remove a facet Sponsored-by: The Research University in the Helmholtz Association (KIT) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35138 --- Comment #9 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 163684 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163684&action=edit Bug 35138: A bit of cleaning - UI This can be moved to its own bug report, it's only a bit of cleaning trying to keep the code cleaner after than before. No behaviour changes expected. Sponsored-by: The Research University in the Helmholtz Association (KIT) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35138 Amaury GAU <amaury.gau@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |amaury.gau@bulac.fr -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35138 Clemens Tubach <clemens.tubach@kit.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35138 Clemens Tubach <clemens.tubach@kit.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #163680|0 |1 is obsolete| | Attachment #163681|0 |1 is obsolete| | Attachment #163682|0 |1 is obsolete| | Attachment #163683|0 |1 is obsolete| | Attachment #163684|0 |1 is obsolete| | --- Comment #10 from Clemens Tubach <clemens.tubach@kit.edu> --- Created attachment 163896 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163896&action=edit Bug 35138: Add the ability to manage ES facets This new feature allows to manage facets for Elasticsearch from the administration page. Prior to this the facet fields were hardcoded in the codebase. Librarians can then add/remove facet fields and modify their label. Test plan: 1. Create a new search field and set it a label different than its name. 2. Save 3. Go the bibliographic mapping tab 4. Add 1+ mapping for this search field (Searchable and facetable must be "Yes") 5. Add, reorder, remove new facets 6. Save and reindex your records 7. Search and notice the new facet list QA: There are several wrong things in this area (ES + facets code, everything, pm, pl, tt AND on this administration page). I have done my best to clean the code as much as I could and keep the code cleaner after than before. But there are still a lot to do. There are still inconsistencies on this page (like we need to save to see the changes applied to the other tables), but this is clearly out of the scope of this bug report. Another enhancement would be to move the facet list to a different DB table, that could bring more flexibility: * display or not (could be opac/staff/both/none) * define the size per field (number of facet to display) * order: move search_field.facet_order to this new table. But, again, it's a lot more work. More work is done in this area, please see related bug reports. Sponsored-by: The Research University in the Helmholtz Association (KIT) Signed-off-by: Clemens Tubach <clemens.tubach@kit.edu> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35138 --- Comment #11 from Clemens Tubach <clemens.tubach@kit.edu> --- Created attachment 163897 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163897&action=edit Bug 35138: Adjust existing data We want the label from the DB displayed on the UI so we are adjusting the yaml and the DB. Sponsored-by: The Research University in the Helmholtz Association (KIT) Signed-off-by: Clemens Tubach <clemens.tubach@kit.edu> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35138 --- Comment #12 from Clemens Tubach <clemens.tubach@kit.edu> --- Created attachment 163898 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163898&action=edit Bug 35138: Mark DisplayLibraryFacets as zebra only We can know add/remove homelibrary and holdinglibray from the config page, this syspref is no longer needed for ES Sponsored-by: The Research University in the Helmholtz Association (KIT) Signed-off-by: Clemens Tubach <clemens.tubach@kit.edu> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35138 --- Comment #13 from Clemens Tubach <clemens.tubach@kit.edu> --- Created attachment 163899 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163899&action=edit Bug 35138: UI changes to add/remove a facet Sponsored-by: The Research University in the Helmholtz Association (KIT) Signed-off-by: Clemens Tubach <clemens.tubach@kit.edu> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35138 --- Comment #14 from Clemens Tubach <clemens.tubach@kit.edu> --- Created attachment 163900 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163900&action=edit Bug 35138: A bit of cleaning - UI This can be moved to its own bug report, it's only a bit of cleaning trying to keep the code cleaner after than before. No behaviour changes expected. Sponsored-by: The Research University in the Helmholtz Association (KIT) Signed-off-by: Clemens Tubach <clemens.tubach@kit.edu> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35138 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=36437 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35138 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35138 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35138 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #163896|0 |1 is obsolete| | Attachment #163897|0 |1 is obsolete| | Attachment #163898|0 |1 is obsolete| | Attachment #163899|0 |1 is obsolete| | Attachment #163900|0 |1 is obsolete| | --- Comment #15 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 164811 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164811&action=edit Bug 35138: Add the ability to manage ES facets This new feature allows to manage facets for Elasticsearch from the administration page. Prior to this the facet fields were hardcoded in the codebase. Librarians can then add/remove facet fields and modify their label. Test plan: 1. Create a new search field and set it a label different than its name. 2. Save 3. Go the bibliographic mapping tab 4. Add 1+ mapping for this search field (Searchable and facetable must be "Yes") 5. Add, reorder, remove new facets 6. Save and reindex your records 7. Search and notice the new facet list QA: There are several wrong things in this area (ES + facets code, everything, pm, pl, tt AND on this administration page). I have done my best to clean the code as much as I could and keep the code cleaner after than before. But there are still a lot to do. There are still inconsistencies on this page (like we need to save to see the changes applied to the other tables), but this is clearly out of the scope of this bug report. Another enhancement would be to move the facet list to a different DB table, that could bring more flexibility: * display or not (could be opac/staff/both/none) * define the size per field (number of facet to display) * order: move search_field.facet_order to this new table. But, again, it's a lot more work. More work is done in this area, please see related bug reports. Sponsored-by: The Research University in the Helmholtz Association (KIT) Signed-off-by: Clemens Tubach <clemens.tubach@kit.edu> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35138 --- Comment #16 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 164812 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164812&action=edit Bug 35138: Adjust existing data We want the label from the DB displayed on the UI so we are adjusting the yaml and the DB. Sponsored-by: The Research University in the Helmholtz Association (KIT) Signed-off-by: Clemens Tubach <clemens.tubach@kit.edu> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35138 --- Comment #17 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 164813 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164813&action=edit Bug 35138: Mark DisplayLibraryFacets as zebra only We can know add/remove homelibrary and holdinglibray from the config page, this syspref is no longer needed for ES Sponsored-by: The Research University in the Helmholtz Association (KIT) Signed-off-by: Clemens Tubach <clemens.tubach@kit.edu> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35138 --- Comment #18 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 164814 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164814&action=edit Bug 35138: UI changes to add/remove a facet Sponsored-by: The Research University in the Helmholtz Association (KIT) Signed-off-by: Clemens Tubach <clemens.tubach@kit.edu> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35138 --- Comment #19 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 164815 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164815&action=edit Bug 35138: A bit of cleaning - UI This can be moved to its own bug report, it's only a bit of cleaning trying to keep the code cleaner after than before. No behaviour changes expected. Sponsored-by: The Research University in the Helmholtz Association (KIT) Signed-off-by: Clemens Tubach <clemens.tubach@kit.edu> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35138 --- Comment #20 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 164816 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164816&action=edit Bug 35138: (QA followup) Tidy update Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35138 --- Comment #21 from Nick Clemens <nick@bywatersolutions.com> --- I think this patch makes the best of a difficult code area, and makes the management of facets in ES for more intuitive, and uses some of the things in the editor as they were intended. The change to DisplayLibraryFacets will need to be highlighted in release notes so that libraries are aware they will need to reconfiugre -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35138 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed Summary|Elasticsearch - manage |Enable configuration of |facets |facets with Elasticsearch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35138 --- Comment #22 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to Nick Clemens from comment #21)
The change to DisplayLibraryFacets will need to be highlighted in release notes so that libraries are aware they will need to reconfiugre
They won't need to reconfigure anything. We are dealing with that in the atomic update. Or are you talking about something else? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35138 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA Keywords| |rel_24_05_candidate --- Comment #23 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I really want this for 24.05, please help me make it happen: 1) Failing unit test (blocker) It looks like you forgot to adjust the t/db_dependent/Koha_Elasticsearch.t to the new name of the method. I tried to fix it, but even after changing the method names the test still keeps failing. I think some more is needed. Please provide a follow-up ASAP. 2) Labels cannot be edited (blocker) The test plan states: "Librarians can then add/remove facet fields and modify their label." But I haven't been able to update the label for my own custom facets. The field remains "locked" and doesn't ever appear as an input field. Tiny things I had fixed on my branch: 3) The database update is missing a success message. I had used: + say $out "Updated DisplayLibraryFacets and search field configuration"; 4) Tiny typo: exist -> exists - alert(__("SearchField '%s' already exist".format(search_field_name))); + alert(__("SearchField '%s' already exists".format(search_field_name))); For a separate bug maybe: ?) Show delete button only after saving? At the moment the delete button shows for a newly added field, but it doesn't work. I think it would make sense to hide it, until the page has been saved. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35138 --- Comment #24 from Michaela Sieber <michaela.sieber@kit.edu> --- (In reply to Katrin Fischer from comment #23)
I really want this for 24.05, please help me make it happen:
2) Labels cannot be edited (blocker)
The test plan states:
"Librarians can then add/remove facet fields and modify their label."
But I haven't been able to update the label for my own custom facets. The field remains "locked" and doesn't ever appear as an input field.
The Labels can be edited on the first tab 'Search fields' as it was before. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35138 --- Comment #25 from Katrin Fischer <katrin.fischer@bsz-bw.de> ---
The Labels can be edited on the first tab 'Search fields' as it was before.
I missed that, thanks! Maybe someone could lend a hand with the test? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35138 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #164811|0 |1 is obsolete| | --- Comment #26 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 165811 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165811&action=edit Bug 35138: Add the ability to manage ES facets This new feature allows to manage facets for Elasticsearch from the administration page. Prior to this the facet fields were hardcoded in the codebase. Librarians can then add/remove facet fields and modify their label. Test plan: 1. Create a new search field and set it a label different than its name. 2. Save 3. Go the bibliographic mapping tab 4. Add 1+ mapping for this search field (Searchable and facetable must be "Yes") 5. Add, reorder, remove new facets 6. Save and reindex your records 7. Search and notice the new facet list QA: There are several wrong things in this area (ES + facets code, everything, pm, pl, tt AND on this administration page). I have done my best to clean the code as much as I could and keep the code cleaner after than before. But there are still a lot to do. There are still inconsistencies on this page (like we need to save to see the changes applied to the other tables), but this is clearly out of the scope of this bug report. Another enhancement would be to move the facet list to a different DB table, that could bring more flexibility: * display or not (could be opac/staff/both/none) * define the size per field (number of facet to display) * order: move search_field.facet_order to this new table. But, again, it's a lot more work. More work is done in this area, please see related bug reports. Sponsored-by: The Research University in the Helmholtz Association (KIT) Signed-off-by: Clemens Tubach <clemens.tubach@kit.edu> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35138 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #164812|0 |1 is obsolete| | --- Comment #27 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 165812 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165812&action=edit Bug 35138: Adjust existing data We want the label from the DB displayed on the UI so we are adjusting the yaml and the DB. Sponsored-by: The Research University in the Helmholtz Association (KIT) Signed-off-by: Clemens Tubach <clemens.tubach@kit.edu> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35138 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #164813|0 |1 is obsolete| | --- Comment #28 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 165813 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165813&action=edit Bug 35138: Mark DisplayLibraryFacets as zebra only We can know add/remove homelibrary and holdinglibray from the config page, this syspref is no longer needed for ES Sponsored-by: The Research University in the Helmholtz Association (KIT) Signed-off-by: Clemens Tubach <clemens.tubach@kit.edu> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35138 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #164814|0 |1 is obsolete| | --- Comment #29 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 165814 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165814&action=edit Bug 35138: UI changes to add/remove a facet Sponsored-by: The Research University in the Helmholtz Association (KIT) Signed-off-by: Clemens Tubach <clemens.tubach@kit.edu> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35138 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #164815|0 |1 is obsolete| | --- Comment #30 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 165815 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165815&action=edit Bug 35138: A bit of cleaning - UI This can be moved to its own bug report, it's only a bit of cleaning trying to keep the code cleaner after than before. No behaviour changes expected. Sponsored-by: The Research University in the Helmholtz Association (KIT) Signed-off-by: Clemens Tubach <clemens.tubach@kit.edu> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35138 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #164816|0 |1 is obsolete| | --- Comment #31 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 165816 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165816&action=edit Bug 35138: (QA followup) Tidy update Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35138 --- Comment #32 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 165817 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165817&action=edit Bug 35138: Fix Koha_Elasticsearch.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35138 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA --- Comment #33 from Jonathan Druart <jonathan.druart@gmail.com> --- Had to rebase because of previous tidy patches. Adjusted the tests: fields are faceted when the facet_order is not null. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35138 --- Comment #34 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 165818 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165818&action=edit Bug 35138: Fix delete button for newly added facet -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35138 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |24.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35138 --- Comment #35 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35138 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_24_05_candidate | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35138 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #36 from David Nind <david@davidnind.com> --- Some facet heading labels are not displayed in the OPAC search results when using Elasticsearch. I'm not sure if this is related to this bug, or is unrelated. I've created bug 36750 for the issue. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35138 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=36750 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35138 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |36750 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36750 [Bug 36750] OPAC - some facet heading labels are not displayed in search results when using Elasticsearch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35138 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |36803 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36803 [Bug 36803] Search facet "languages" should resolve to language name using database definitions -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35138 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35138 --- Comment #37 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 166402 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166402&action=edit Bug 35138: (follow-up) Mark DisplayLibraryFacets as zebra only The tests are no longer relevant -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35138 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com --- Comment #38 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Follow-up pushed as RM Assist. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35138 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35138 Michaela Sieber <michaela.sieber@kit.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|release-notes-needed | Text to go in the| |This new feature allows to release notes| |manage facets for | |Elasticsearch from the | |administration page. Prior | |to this the facet fields | |were hardcoded in the | |codebase. | |Search fields can | |be added as new facets now | |if they are searchable and | |facetable. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35138 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This new feature allows to |This new feature enables release notes|manage facets for |facets for Elasticsearch |Elasticsearch from the |(and Open Search) to be |administration page. Prior |managed from the search |to this the facet fields |engine configuration page. |were hardcoded in the |Prior to this, the facet |codebase. |fields were hard-coded in |Search fields can |the codebase. |be added as new facets now | |if they are searchable and |You can add |facetable. |new facets when the search | |field options for | |'Facetable' and | |'Searchable' are set to | |"Yes". -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35138 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |new feature -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35138 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Status|Pushed to main |Needs documenting --- Comment #39 from Fridolin Somers <fridolin.somers@biblibre.com> --- Great feature Not backported to 23.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35138 Bug 35138 depends on bug 36394, which changed state. Bug 36394 Summary: Inconsistent behaviour in footers (mappings admin page) https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36394 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35138 Lari Taskula <lari.taskula@hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |37446 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37446 [Bug 37446] Home/holding library facets missing user friendly label -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35138 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|martin.renvoize@ptfs-europe | |.com | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35138 Bug 35138 depends on bug 20388, which changed state. Bug 20388 Summary: Ability to add search fields from UI https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35138 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Documentation| |https://gitlab.com/koha-com submission| |munity/koha-manual/-/merge_ | |requests/953 Status|Needs documenting |RESOLVED CC| |caroline.cyr-la-rose@inlibr | |o.com Documentation| |Caroline Cyr La Rose contact| | Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35138 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |37953 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37953 [Bug 37953] Incorrect handling of DisplayLibraryFacets in 231200036 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35138 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |39118 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39118 [Bug 39118] Make facet labels translatable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35138 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=41668 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35138 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |41668 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41668 [Bug 41668] Elasticsearch reset not setting facets correctly -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org