[Bug 18235] New: Elastic search - Configurable facets
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235 Bug ID: 18235 Summary: Elastic search - Configurable facets Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Searching Assignee: jonathan.druart@bugs.koha-community.org Reporter: jonathan.druart@bugs.koha-community.org QA Contact: testopia@bugs.koha-community.org Depends on: 14899, 17169, 18174
From the Elastic mappings configuration page, the librarians should be able to manage facets (display/hide and order).
Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14899 [Bug 14899] Mapping configuration page for Elastic search https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17169 [Bug 17169] Add facets for ccode to elasticsearch https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18174 [Bug 18174] Add the Koha::Object->update method -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235 --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 60931 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60931&action=edit Bug 18235: DBIx::Class schema changes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235 --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 60932 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60932&action=edit Bug 18235: DB changes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235 --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 60933 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60933&action=edit Bug 18235: ES - Facets configurable This patch adds a new section 'Facet order' in the Biblio tab of the 'Search engine configuration' admin page of the Elastic mappings. The idea is to let the librarians define the facet to display and order them as their needs. The ergonomic is not perfect and I am open to any suggestions. Test plan: Move up and down the field list to order the facets Hide/show some facets At the OPAC and the staff interface you should see the changes on the search result page. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18213 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235 Jacek Ablewicz <abl@biblos.pk.edu.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |abl@biblos.pk.edu.pl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60931|0 |1 is obsolete| | Attachment #60932|0 |1 is obsolete| | Attachment #60933|0 |1 is obsolete| | --- Comment #4 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 61528 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61528&action=edit Bug 18235: DBIx::Class schema changes Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235 --- Comment #5 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 61529 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61529&action=edit Bug 18235: DB changes Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235 --- Comment #6 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 61530 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61530&action=edit Bug 18235: ES - Facets configurable This patch adds a new section 'Facet order' in the Biblio tab of the 'Search engine configuration' admin page of the Elastic mappings. The idea is to let the librarians define the facet to display and order them as their needs. The ergonomic is not perfect and I am open to any suggestions. Test plan: Move up and down the field list to order the facets Hide/show some facets At the OPAC and the staff interface you should see the changes on the search result page. Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com --- Comment #7 from Nick Clemens <nick@bywatersolutions.com> --- I like this alot - many libraries want to control the facets a bit more and this is helpful. Still a few tings that would be nice (but I am not suggesting they are needed in this patchset) -labels shouldn't be hardcoded - staff shoul eb able to set them -we should add more options to what can be faceted- could be out of control but technically any field should be able to be used -ES has better handling for faceting (can provide subsets of existing/current results and allow to step in/out of facets) FYI not complaints -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235 --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Nick, yes you are right of course. This is only the first step. However there are two problems: 1. Translatability: if staff changes or add new labels, they will not be translated (we could cover some in the template) 2. Shared includes files: What I said for 2 years now... We are using the same files for elastic and Zebra, so we have to stick to ugly structure the template expects. That's very bad, we need to create separate files to allow more flexibility. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |18322 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18322 [Bug 18322] Add facets for ccode to zebra -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|18322 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18322 [Bug 18322] Add facets for ccode to zebra -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235 Bug 18235 depends on bug 17169, which changed state. Bug 17169 Summary: Add facets for ccode to elasticsearch https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17169 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235 Bug 18235 depends on bug 18174, which changed state. Bug 18174 Summary: Add the Koha::Object->update method https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18174 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron@veron.ch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply CC| |m.de.rooy@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off --- Comment #9 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Marcel, They apply correctly, just skip the first patch and regenerate the schema files. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #10 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- If I select say Author and set them all to Facetable No in the Search fields list on the Biblios tab, I would not expect Author to be still in the Facet order list? Changing status for feedback -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61528|0 |1 is obsolete| | --- Comment #11 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 64747 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64747&action=edit Bug 18235: DBIx schema changes Fresh changes for SearchField, facet_order. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235 --- Comment #12 from Nick Clemens <nick@bywatersolutions.com> --- (In reply to Marcel de Rooy from comment #10)
If I select say Author and set them all to Facetable No in the Search fields list on the Biblios tab, I would not expect Author to be still in the Facet order list?
I agree, this is not ideal, but I think that comes when we stop hardcoding the displayable facets all together - I would say beyond the scope of this bug -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18213 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18213 [Bug 18213] Add language facets to Elasticsearch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |In Discussion --- Comment #13 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Yes indeed you are right, this is not ideal and might be confusing. We should add more JS code to handle that correctly, but I am not willing to write it. However I am still thinking that this feature is needed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Searching |Searching - Elasticsearch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235 David Bourgault <david.bourgault@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david.bourgault@inlibro.com --- Comment #14 from David Bourgault <david.bourgault@inlibro.com> --- Also patch does not apply. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61529|0 |1 is obsolete| | Attachment #61530|0 |1 is obsolete| | Attachment #64747|0 |1 is obsolete| | --- Comment #15 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 69485 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69485&action=edit Bug 18235: DB changes Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235 --- Comment #16 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 69486 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69486&action=edit Bug 18235: ES - Facets configurable This patch adds a new section 'Facet order' in the Biblio tab of the 'Search engine configuration' admin page of the Elastic mappings. The idea is to let the librarians define the facet to display and order them as their needs. The ergonomic is not perfect and I am open to any suggestions. Test plan: Move up and down the field list to order the facets Hide/show some facets At the OPAC and the staff interface you should see the changes on the search result page. Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235 --- Comment #17 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 69487 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69487&action=edit Bug 18235: DBIx schema changes Fresh changes for SearchField, facet_order. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69485|0 |1 is obsolete| | Attachment #69486|0 |1 is obsolete| | Attachment #69487|0 |1 is obsolete| | --- Comment #18 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 72936 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72936&action=edit Bug 18235: DB changes Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Current status: Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235 --- Comment #19 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 72937 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72937&action=edit Bug 18235: ES - Facets configurable This patch adds a new section 'Facet order' in the Biblio tab of the 'Search engine configuration' admin page of the Elastic mappings. The idea is to let the librarians define the facet to display and order them as their needs. The ergonomic is not perfect and I am open to any suggestions. Test plan: Move up and down the field list to order the facets Hide/show some facets At the OPAC and the staff interface you should see the changes on the search result page. Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235 --- Comment #20 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 72938 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72938&action=edit Bug 18235: DBIx schema changes Fresh changes for SearchField, facet_order. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235 Nicolas Legrand <nicolas.legrand@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72936|0 |1 is obsolete| | --- Comment #21 from Nicolas Legrand <nicolas.legrand@bulac.fr> --- Created attachment 72999 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72999&action=edit Bug 18235: DB changes Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Nicolas Legrand <nicolas.legrand@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235 Nicolas Legrand <nicolas.legrand@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72937|0 |1 is obsolete| | --- Comment #22 from Nicolas Legrand <nicolas.legrand@bulac.fr> --- Created attachment 73000 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73000&action=edit Bug 18235: ES - Facets configurable This patch adds a new section 'Facet order' in the Biblio tab of the 'Search engine configuration' admin page of the Elastic mappings. The idea is to let the librarians define the facet to display and order them as their needs. The ergonomic is not perfect and I am open to any suggestions. Test plan: Move up and down the field list to order the facets Hide/show some facets Rebuild index At the OPAC and the staff interface you should see the changes on the search result page. Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Nicolas Legrand <nicolas.legrand@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235 Nicolas Legrand <nicolas.legrand@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72938|0 |1 is obsolete| | --- Comment #23 from Nicolas Legrand <nicolas.legrand@bulac.fr> --- Created attachment 73001 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73001&action=edit Bug 18235: DBIx schema changes Fresh changes for SearchField, facet_order. Signed-off-by: Nicolas Legrand <nicolas.legrand@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235 Nicolas Legrand <nicolas.legrand@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nicolas.legrand@bulac.fr --- Comment #24 from Nicolas Legrand <nicolas.legrand@bulac.fr> --- Added missing curly, removed a <<<<<HEAD thingy, added index rebuild in test plan. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |alex.arnaud@biblibre.com --- Comment #25 from Alex Arnaud <alex.arnaud@biblibre.com> --- Ergonomic suggestion: - move the the facet table in a new tab (discussed with some interested libraries). Currently it is not visible at the first glance. QA suggestion: - rename bug_xxxxx.sql with the appropriate bug number, - add unit test for get_facetable_fields Then, nice feature and i would like this to move forward. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235 Nicolas Legrand <nicolas.legrand@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |severine.queune@bulac.fr -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235 --- Comment #26 from Séverine Queune <severine.queune@bulac.fr> --- +1 for the new 'Facet order' tab ! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235 --- Comment #27 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- I did not create a new tab because we already have 3: Search fields Biblios Authorities and I do not think it makes sense to have a 4th "Facet order" which will refer to biblio search only. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235 --- Comment #28 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 73193 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73193&action=edit Bug 18235 - Add unit tests for get_facetable_fields rename atomic update file -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master Status|Signed Off |BLOCKED --- Comment #29 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- QA: Looking here -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Failed QA --- Comment #30 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- There is a lot of noise from YAML while running qa tools and a git manipulation fail too. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #31 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Marcel de Rooy from comment #30)
There is a lot of noise from YAML while running qa tools and a git manipulation fail too.
Noise appears before and after the patch, so not related. The git manipulation is on the atomic update (it should not have been moved in the last patch), I will fix it on pushing. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |BLOCKED --- Comment #32 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Resuming here -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Failed QA --- Comment #33 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- * Commit title does not start with 'Bug XXXXX: ' - 9400c92 POD is missing for get_facetable_fields -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235 --- Comment #34 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Marcel de Rooy from comment #33)
* Commit title does not start with 'Bug XXXXX: ' - 9400c92 POD is missing for get_facetable_fields
That's all? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73193|0 |1 is obsolete| | --- Comment #35 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 74642 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74642&action=edit Bug 18235: Add unit tests for get_facetable_fields rename atomic update file -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235 --- Comment #36 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 74643 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74643&action=edit Bug 18235: Add missing POD to get_facetable_fields -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235 --- Comment #37 from Alex Arnaud <alex.arnaud@biblibre.com> --- (In reply to Jonathan Druart from comment #35)
Created attachment 74642 [details] [review] Bug 18235: Add unit tests for get_facetable_fields
rename atomic update file
Looks like this patch does not what it was named for. Atomic update file's name is still Bug_xxxxxxx. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72999|0 |1 is obsolete| | --- Comment #38 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 75995 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75995&action=edit Bug 18235: DB changes Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Nicolas Legrand <nicolas.legrand@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #74642|0 |1 is obsolete| | --- Comment #39 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 75996 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75996&action=edit Bug 18235: Add unit tests for get_facetable_fields -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235 --- Comment #40 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- I have amended the last 2 patches: 1. rename atomic update file and 2. remove the line from commit message that was not related to the patch. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235 Marjorie Barry-Vila <marjorie.barry-vila@collecto.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila@collect | |o.ca -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235 e.betemps <e.betemps@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |e.betemps@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply CC| |ere.maijala@helsinki.fi, | |katrin.fischer@bsz-bw.de --- Comment #41 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This patch doesn't apply right now. Might not be a hard fix if you are familiar with the Elasticsearch code. Can we get a rebase please? @Ere - It'd also be great if you could have a look here. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73000|0 |1 is obsolete| | Attachment #73001|0 |1 is obsolete| | Attachment #74643|0 |1 is obsolete| | Attachment #75995|0 |1 is obsolete| | Attachment #75996|0 |1 is obsolete| | --- Comment #42 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 85212 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85212&action=edit Bug 18235: ES - Facets configurable This patch adds a new section 'Facet order' in the Biblio tab of the 'Search engine configuration' admin page of the Elastic mappings. The idea is to let the librarians define the facet to display and order them as their needs. The ergonomic is not perfect and I am open to any suggestions. Test plan: Move up and down the field list to order the facets Hide/show some facets Rebuild index At the OPAC and the staff interface you should see the changes on the search result page. Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Nicolas Legrand <nicolas.legrand@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235 --- Comment #43 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 85213 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85213&action=edit Bug 18235: Add missing POD to get_facetable_fields -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235 --- Comment #44 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 85214 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85214&action=edit Bug 18235: DB changes Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Nicolas Legrand <nicolas.legrand@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235 --- Comment #45 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 85215 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85215&action=edit Bug 18235: Add unit tests for get_facetable_fields -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235 --- Comment #46 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 85216 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85216&action=edit Bug 18235: DBIx schema changes Fresh changes for SearchField, facet_order. Signed-off-by: Nicolas Legrand <nicolas.legrand@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235 --- Comment #47 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Those patches have been waiting for one year, only for a commit message problem. As I do not plan to rebase them endlessly, I think it would be great for libraries using ES to get a green stamp from people involved in the ES development. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235 --- Comment #48 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 85885 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85885&action=edit Bug 18235: (QA follow-up) Fix POD -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235 --- Comment #49 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 85886 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85886&action=edit Bug 18235: (QA follow-up) Add missing filters -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235 --- Comment #50 from Josef Moravec <josef.moravec@gmail.com> --- Comment on attachment 85214 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85214 Bug 18235: DB changes Review of attachment 85214: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=18235&attachment=85214) ----------------------------------------------------------------- ::: installer/data/mysql/atomicupdate/bug_18235-add-search_field-facet_order.sql @@ +1,1 @@
+ALTER TABLE search_field ADD COLUMN facet_order TINYINT(4) DEFAULT '0' AFTER weight;
Here is default 0 ::: installer/data/mysql/kohastructure.sql @@ +1493,4 @@
`label` varchar(255) NOT NULL COMMENT 'the human readable name of the field, for display', `type` ENUM('', 'string', 'date', 'number', 'boolean', 'sum', 'isbn', 'stdno') NOT NULL COMMENT 'what type of data this holds, relevant when storing it in the search engine', `weight` decimal(5,2) DEFAULT NULL, + `facet_order` TINYINT(4) DEFAULT NULL COMMENT 'the order place of the field in facet list if faceted',
And here NULL -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235 --- Comment #51 from Josef Moravec <josef.moravec@gmail.com> --- Comment on attachment 85212 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85212 Bug 18235: ES - Facets configurable Review of attachment 85212: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=18235&attachment=85212) ----------------------------------------------------------------- ::: Koha/SearchEngine/Elasticsearch.pm @@ +971,5 @@
+ my @faceted_fields = Koha::SearchFields->search( + { name => { -in => \@search_field_names }, facet_order => { '!=' => undef } }, { order_by => ['facet_order'] } + ); + my @not_faceted_fields = Koha::SearchFields->search( + { name => { -in => \@search_field_names }, facet_order => undef }, { order_by => ['facet_order'] }
Why do you retrieve fields from database in 2 queries, you always use them all. ::: admin/searchengine/elasticsearch/mappings.pl @@ +215,4 @@
push @all_search_fields, $search_field_unblessed; }
+my @facetable_fields = Koha::SearchEngine::Elasticsearch->get_facetable_fields();
get_facetable_fields is called 3 or 4 times every run of mappings.pl. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |josef.moravec@gmail.com, | |oleonard@myacpl.org --- Comment #52 from Josef Moravec <josef.moravec@gmail.com> --- Hi Jonathan, great job, I have just some small questions (see above) I also adding Owen if he can advice us how to do the UI better, it is not obvious that the facet order could be changed, also the facet table is at the end of page and easy to oversee... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235 --- Comment #53 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Josef Moravec from comment #52)
the facet table is at the end of page and easy to oversee...
I wonder if it should be in a separate tab? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235 --- Comment #54 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- I would support an integration ASAP then we could discuss the ergonomic (patches submitted 2 years ago). Unless somebody else is willing to make the changes ;) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235 --- Comment #55 from Owen Leonard <oleonard@myacpl.org> --- I've got some interface changes in process, but they don't need to hold this up. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235 --- Comment #56 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Josef Moravec from comment #50)
Comment on attachment 85214 [details] [review] Bug 18235: DB changes
Review of attachment 85214 [details] [review]: -----------------------------------------------------------------
::: installer/data/mysql/atomicupdate/bug_18235-add-search_field-facet_order.sql @@ +1,1 @@
+ALTER TABLE search_field ADD COLUMN facet_order TINYINT(4) DEFAULT '0' AFTER weight;
Here is default 0
::: installer/data/mysql/kohastructure.sql @@ +1493,4 @@
`label` varchar(255) NOT NULL COMMENT 'the human readable name of the field, for display', `type` ENUM('', 'string', 'date', 'number', 'boolean', 'sum', 'isbn', 'stdno') NOT NULL COMMENT 'what type of data this holds, relevant when storing it in the search engine', `weight` decimal(5,2) DEFAULT NULL, + `facet_order` TINYINT(4) DEFAULT NULL COMMENT 'the order place of the field in facet list if faceted',
And here NULL
Right, must be NULL in the atomic update file. (In reply to Josef Moravec from comment #51)
Comment on attachment 85212 [details] [review] Bug 18235: ES - Facets configurable
Review of attachment 85212 [details] [review]: -----------------------------------------------------------------
::: Koha/SearchEngine/Elasticsearch.pm @@ +971,5 @@
+ my @faceted_fields = Koha::SearchFields->search( + { name => { -in => \@search_field_names }, facet_order => { '!=' => undef } }, { order_by => ['facet_order'] } + ); + my @not_faceted_fields = Koha::SearchFields->search( + { name => { -in => \@search_field_names }, facet_order => undef }, { order_by => ['facet_order'] }
Why do you retrieve fields from database in 2 queries, you always use them all.
To have the not faceted fields at the end of the array. I agree it's a lazy way to handle that, but it works :)
::: admin/searchengine/elasticsearch/mappings.pl @@ +215,4 @@
push @all_search_fields, $search_field_unblessed; }
+my @facetable_fields = Koha::SearchEngine::Elasticsearch->get_facetable_fields();
get_facetable_fields is called 3 or 4 times every run of mappings.pl.
Yep, could be lowered to 2. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235 --- Comment #57 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 85969 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85969&action=edit Bug 18235: Update facet_order default value in atomic update -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235 --- Comment #58 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 85970 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85970&action=edit Bug 18235: Do not call get_facetable_fields excessively -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235 --- Comment #59 from Josef Moravec <josef.moravec@gmail.com> --- (In reply to Owen Leonard from comment #53)
(In reply to Josef Moravec from comment #52)
the facet table is at the end of page and easy to oversee...
I wonder if it should be in a separate tab?
I think it is good idea. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235 --- Comment #60 from Josef Moravec <josef.moravec@gmail.com> --- (In reply to Jonathan Druart from comment #54)
I would support an integration ASAP then we could discuss the ergonomic (patches submitted 2 years ago).
Unless somebody else is willing to make the changes ;)
(In reply to Owen Leonard from comment #55)
I've got some interface changes in process, but they don't need to hold this up.
I agree, we could pass and push this soon and then work on UI -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85212|0 |1 is obsolete| | Attachment #85213|0 |1 is obsolete| | Attachment #85214|0 |1 is obsolete| | Attachment #85215|0 |1 is obsolete| | Attachment #85216|0 |1 is obsolete| | Attachment #85885|0 |1 is obsolete| | Attachment #85886|0 |1 is obsolete| | Attachment #85969|0 |1 is obsolete| | Attachment #85970|0 |1 is obsolete| | --- Comment #61 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 85983 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85983&action=edit Bug 18235: ES - Facets configurable This patch adds a new section 'Facet order' in the Biblio tab of the 'Search engine configuration' admin page of the Elastic mappings. The idea is to let the librarians define the facet to display and order them as their needs. The ergonomic is not perfect and I am open to any suggestions. Test plan: Move up and down the field list to order the facets Hide/show some facets Rebuild index At the OPAC and the staff interface you should see the changes on the search result page. Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Nicolas Legrand <nicolas.legrand@bulac.fr> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235 --- Comment #62 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 85984 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85984&action=edit Bug 18235: Add missing POD to get_facetable_fields Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235 --- Comment #63 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 85985 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85985&action=edit Bug 18235: DB changes Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Nicolas Legrand <nicolas.legrand@bulac.fr> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235 --- Comment #64 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 85986 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85986&action=edit Bug 18235: Add unit tests for get_facetable_fields Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235 --- Comment #65 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 85987 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85987&action=edit Bug 18235: DBIx schema changes Fresh changes for SearchField, facet_order. Signed-off-by: Nicolas Legrand <nicolas.legrand@bulac.fr> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235 --- Comment #66 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 85988 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85988&action=edit Bug 18235: (QA follow-up) Fix POD Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235 --- Comment #67 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 85989 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85989&action=edit Bug 18235: (QA follow-up) Add missing filters Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235 --- Comment #68 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 85990 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85990&action=edit Bug 18235: Update facet_order default value in atomic update Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235 --- Comment #69 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 85991 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85991&action=edit Bug 18235: Do not call get_facetable_fields excessively Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235 --- Comment #70 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 85992 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85992&action=edit Bug 18235: (QA follow-up) Make db update idempotent Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22449 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22449 [Bug 22449] Improve Elastic search facet setting UI -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Target Milestone|--- |19.05 QA Contact|m.de.rooy@rijksmuseum.nl |josef.moravec@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|22449 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22449 [Bug 22449] Improve Elastic search facet setting UI -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Patch doesn't apply --- Comment #71 from Nick Clemens <nick@bywatersolutions.com> --- Conflict in the mappings file, please rebase -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85983|0 |1 is obsolete| | Attachment #85984|0 |1 is obsolete| | Attachment #85985|0 |1 is obsolete| | Attachment #85986|0 |1 is obsolete| | Attachment #85987|0 |1 is obsolete| | Attachment #85988|0 |1 is obsolete| | Attachment #85989|0 |1 is obsolete| | Attachment #85990|0 |1 is obsolete| | Attachment #85991|0 |1 is obsolete| | Attachment #85992|0 |1 is obsolete| | --- Comment #72 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 86340 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86340&action=edit Bug 18235: ES - Facets configurable This patch adds a new section 'Facet order' in the Biblio tab of the 'Search engine configuration' admin page of the Elastic mappings. The idea is to let the librarians define the facet to display and order them as their needs. The ergonomic is not perfect and I am open to any suggestions. Test plan: Move up and down the field list to order the facets Hide/show some facets Rebuild index At the OPAC and the staff interface you should see the changes on the search result page. Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Nicolas Legrand <nicolas.legrand@bulac.fr> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235 --- Comment #73 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 86341 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86341&action=edit Bug 18235: Add missing POD to get_facetable_fields Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235 --- Comment #74 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 86342 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86342&action=edit Bug 18235: DB changes Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Nicolas Legrand <nicolas.legrand@bulac.fr> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235 --- Comment #75 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 86343 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86343&action=edit Bug 18235: Add unit tests for get_facetable_fields Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235 --- Comment #76 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 86344 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86344&action=edit Bug 18235: DBIx schema changes Fresh changes for SearchField, facet_order. Signed-off-by: Nicolas Legrand <nicolas.legrand@bulac.fr> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235 --- Comment #77 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 86345 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86345&action=edit Bug 18235: (QA follow-up) Fix POD Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235 --- Comment #78 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 86346 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86346&action=edit Bug 18235: (QA follow-up) Add missing filters Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235 --- Comment #79 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 86347 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86347&action=edit Bug 18235: Update facet_order default value in atomic update Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235 --- Comment #80 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 86348 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86348&action=edit Bug 18235: Do not call get_facetable_fields excessively Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235 --- Comment #81 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 86349 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86349&action=edit Bug 18235: (QA follow-up) Make db update idempotent Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235 --- Comment #82 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 86350 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86350&action=edit Bug 18235: (QA follow-up) Series facet name after rebase Bug 19575 changes many field names so "se" facet field became "title-series" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |BLOCKED --- Comment #83 from Josef Moravec <josef.moravec@gmail.com> --- I rebased it and add a follow-up to adapt to 19575, just not sure what to do, with su-geo, look like it was removed in bug 1957... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |22495 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22495 [Bug 22495] Restore su-geo field in Elasticsearch mappings -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235 --- Comment #84 from Josef Moravec <josef.moravec@gmail.com> --- Bug 22495 is going to restore su-geo, so I think we should wait with this again :( -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86340|0 |1 is obsolete| | --- Comment #85 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 86944 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86944&action=edit Bug 18235: ES - Facets configurable This patch adds a new section 'Facet order' in the Biblio tab of the 'Search engine configuration' admin page of the Elastic mappings. The idea is to let the librarians define the facet to display and order them as their needs. The ergonomic is not perfect and I am open to any suggestions. Test plan: Move up and down the field list to order the facets Hide/show some facets Rebuild index At the OPAC and the staff interface you should see the changes on the search result page. Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Nicolas Legrand <nicolas.legrand@bulac.fr> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86341|0 |1 is obsolete| | --- Comment #86 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 86945 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86945&action=edit Bug 18235: Add missing POD to get_facetable_fields Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86342|0 |1 is obsolete| | --- Comment #87 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 86946 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86946&action=edit Bug 18235: DB changes Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Nicolas Legrand <nicolas.legrand@bulac.fr> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86343|0 |1 is obsolete| | --- Comment #88 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 86947 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86947&action=edit Bug 18235: Add unit tests for get_facetable_fields Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86344|0 |1 is obsolete| | --- Comment #89 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 86948 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86948&action=edit Bug 18235: DBIx schema changes Fresh changes for SearchField, facet_order. Signed-off-by: Nicolas Legrand <nicolas.legrand@bulac.fr> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86345|0 |1 is obsolete| | --- Comment #90 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 86949 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86949&action=edit Bug 18235: (QA follow-up) Fix POD Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86346|0 |1 is obsolete| | --- Comment #91 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 86950 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86950&action=edit Bug 18235: (QA follow-up) Add missing filters Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86347|0 |1 is obsolete| | --- Comment #92 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 86951 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86951&action=edit Bug 18235: Update facet_order default value in atomic update Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86348|0 |1 is obsolete| | --- Comment #93 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 86952 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86952&action=edit Bug 18235: Do not call get_facetable_fields excessively Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86349|0 |1 is obsolete| | --- Comment #94 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 86953 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86953&action=edit Bug 18235: (QA follow-up) Make db update idempotent Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86350|0 |1 is obsolete| | --- Comment #95 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 86954 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86954&action=edit Bug 18235: (QA follow-up) Series facet name after rebase Bug 19575 changes many field names so "se" facet field became "title-series" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235 --- Comment #96 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 86955 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86955&action=edit Bug 18253: (QA follow-up) Restore facet_order for su-geo field in mappings file Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235 --- Comment #97 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 86956 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86956&action=edit Bug 18235: (QA follow-up) Restore facet_order for su-geo field in mappings file Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86955|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Passed QA --- Comment #98 from Josef Moravec <josef.moravec@gmail.com> --- Rebased and adapted to bug 22495. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235 --- Comment #99 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 87141 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87141&action=edit Bug 18235: (RM follow-up) fix mappings reset Without this we could not recreate mappings as there are no defaults for the additional fields - this restores behavoiur from before patches -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #100 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235 --- Comment #101 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to Nick Clemens from comment #100)
Awesome work all!
Pushed to master for 19.05
\o/ -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |new feature -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED CC| |martin.renvoize@ptfs-europe | |.com Resolution|--- |FIXED --- Comment #102 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- New feature will not be backported to 18.11.x series. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Manual, | |release-notes-needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22636 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22636 [Bug 22636] Elasticsearch admin page design enhancement -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This new feature allows release notes| |librarians with appropriate | |permissions to configure | |(show/hide/re-order) the | |search facets provided by | |elasticsearch. Keywords|release-notes-needed | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235 Michaela Sieber <michaela.sieber@kit.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |michaela.sieber@kit.edu -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235 Michaela Sieber <michaela.sieber@kit.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |35138 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35138 [Bug 35138] Elastic search - add new facets -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=41668 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org