[Bug 7732] New: Restoring "More lists" in the Add-to combo of OPAC Search Results
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7732 Priority: P3 Change sponsored?: --- Bug ID: 7732 Assignee: m.de.rooy@rijksmuseum.nl Summary: Restoring "More lists" in the Add-to combo of OPAC Search Results QA Contact: koha.sekjal@gmail.com Severity: enhancement Classification: Unclassified OS: All Reporter: m.de.rooy@rijksmuseum.nl Hardware: All Status: ASSIGNED Version: master Component: Virtual Shelves Product: Koha This is a followup of report 7310 handling this QA comment: One small thing: C4/Auth.pm removed the export of template param "bartotal", but this is still used in one template, opac/opac-results.tt, to display a More Lists option in the dropdown menu. It doesn't appear that this param gets exported anywhere else, so I believe it will fail to display the More Lists option at any time. I don't know if this is particularly relevant, and I'm not sure how best to deal with it, but any fix for this can be handled with a followup patch. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7732 --- Comment #1 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Patch does the following: 1) More lists -> More Lists in order to be consistent with context 2) More Lists is put just before New List at the end of the combo list. (More logical place than between your and public lists.) 3) More Lists is only shown when the number of private or public lists exceeds 9; this is a pragmatic and hard-coded approach for now. Only if there are exactly 10 lists, this does not really add a list. But who cares about that? 4) Resolves a potential bug with an [% END %] at the wrong place. Moved it after the finishing optgroup tag. So much in only eight lines :-) Test plan: After 7310 has been applied, you did not see More lists anymore. If the number of private and public lists <10, you will not see More lists. As soon as the number of private or public lists >=10, More Lists comes up. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7732 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |7310 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7732 --- Comment #2 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 8278 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8278&action=edit Patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7732 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #8278|0 |1 is patch| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7732 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7732 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #8278|0 |1 is obsolete| | --- Comment #3 from Nicole C. Engard <nengard@gmail.com> --- Created attachment 8298 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8298&action=edit [SIGNED-OFF] Bug 7732: Restoring "More lists" in the Add-to combo of OPAC Search Results 1) More lists -> More Lists in order to be consistent with context. 2) More Lists is put just before New List at the end of the combo list. (More logical place than between your and public lists.) 3) More Lists is only shown when the number of private or public lists exceeds 9; this is a pragmatic and hard-coded approach for now. Only if there are exactly 10 lists, this does not really add a list. But who cares about that? 4) Resolves a potential bug with an [% END %] at the wrong place. Moved it after the finishing optgroup tag. Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> Performed a search in the OPAC without the patch and More Lists does not appear. Applied patch and perfomred OPAC search again and the More Lists option reappears. Signed off. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7732 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |nengard@gmail.com --- Comment #4 from Nicole C. Engard <nengard@gmail.com> --- Signing off on patch for OPAC. Note that the More Lists option does not appear in the staff client still. Nicole -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7732 --- Comment #5 from Nicole C. Engard <nengard@gmail.com> --- Question: Should more lists show in the staff client? I have 11 lists and they all show in the pull down in the staff client - making the More option not necessary. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7732 Ian Walls <koha.sekjal@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #6 from Ian Walls <koha.sekjal@gmail.com> --- Nicole, If the 'more lists' isn't working on the staff client, it's for different reasons than the OPAC... the OPAC side had lost a template param with 7310 that resulted in that option never displaying. This patch fixes that, but doesn't address the staff side at all. That could be a separate bug, but perhaps having them all show up is a feature... Template only change, easy to read, marking as Passed QA. Please note this depends on bug 7310, and must be pushed after. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7732 --- Comment #7 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Nicole: I will send a followup for staff too (after 7310). -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7732 --- Comment #8 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- The complementing patch for staff is found under bug 7786. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7732 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |paul.poulain@biblibre.com Version|master |rel_3_8 --- Comment #9 from Paul Poulain <paul.poulain@biblibre.com> --- tiny patch, pushed -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7732 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org