[Bug 7783] New: Show private shelves in opac when deleting non-empty list from shelf view
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7783 Priority: P5 - low Change sponsored?: --- Bug ID: 7783 Assignee: m.de.rooy@rijksmuseum.nl Summary: Show private shelves in opac when deleting non-empty list from shelf view QA Contact: koha.sekjal@gmail.com Severity: enhancement Classification: Unclassified OS: All Reporter: m.de.rooy@rijksmuseum.nl Hardware: All Status: ASSIGNED Version: master Component: Virtual Shelves Depends on: 7310 Product: Koha This patch builds on top of 7310, but the problem is in master already. If you delete a non-empty list from shelf view (looking at the biblio records of the list), the confirm message is shown but listing public lists instead of private lists. Report 7310 resolved this for staff. This patch adds it for OPAC. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7783 --- Comment #1 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 8440 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8440&action=edit Patch One-line-fix: easy to test (after 7310 is through) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7783 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #8440|0 |1 is patch| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7783 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Show private shelves in |Show private shelves in |opac when deleting |opac when deleting |non-empty list from shelf |non-empty private list from |view |shelf view -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7783 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7783 MathildeF <mathilde.formery@ville-nimes.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |mathilde.formery@ville-nime | |s.fr --- Comment #2 from MathildeF <mathilde.formery@ville-nimes.fr> --- Tested on sandbox. it works correct. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7783 Ian Walls <koha.sekjal@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #3 from Ian Walls <koha.sekjal@gmail.com> --- Template only change, adding a new template parameter to the submit to opac-shelves.pl if showprivateshelves is set. Marking Passed QA. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7783 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |paul.poulain@biblibre.com --- Comment #4 from Paul Poulain <paul.poulain@biblibre.com> --- tiny comment: it would have been more clear to write the patch on 2 lines: + [% IF ( showprivateshelves ) %]<input type="hidden" name="display" value="privateshelves"/>[% END %] alone, but will push the patch as it is ;-) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7783 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|master |rel_3_8 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7783 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org