[Bug 8523] New: Authority hierarchies only support UNIMARC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8523 Priority: P5 - low Change sponsored?: Sponsored Bug ID: 8523 Assignee: jcamins@cpbibliography.com Summary: Authority hierarchies only support UNIMARC Severity: enhancement Classification: Unclassified OS: All Reporter: jcamins@cpbibliography.com Hardware: All Status: NEW Version: master Component: MARC Authority data support Depends on: 8207 Product: Koha As of right now, the authority hierarchy code works only with UNIMARC. There is, however, no reason why it should not also work with MARC21, and we propose to add support for MARC21 to the authority hierarchy code. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8523 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8523 --- Comment #1 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- Created attachment 11360 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11360&action=edit Bug 8523: Display auth hierarchies w/all marcflavours This commit adds support for displaying authority hierarchies for all flavours of MARC, not just UNIMARC. Display now uses the jQuery jstree plugin, selected with the help of Owen Leonard, resulting in a much faster experience for users. Be aware that the jstree file uses tabs rather than 4-space indentation, which I left as-is so as to make it easier to integrate upstream releases in the future. To test: 1) Enable the AuthDisplayHierarchy syspref 2) Create authority records with a hierarchy of see also fields (in MARC21/NORMARC, you'll be using 5xx fields for this, with a subfield $w=g for broader terms and subfield $w=h for narrower terms) 3) View the authorities in the OPAC, noting the hierarchical view at the top of the page. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8523 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic@tamil.fr --- Comment #2 from Frédéric Demians <frederic@tamil.fr> --- I can't sign-off before the end of August. But I have 2 libraries using the authority hierarchy display with UNIMARC. So I really want to confirm that this patch doesn't imply any regression before it is pushed. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8523 --- Comment #3 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- (In reply to comment #2)
I can't sign-off before the end of August. But I have 2 libraries using the authority hierarchy display with UNIMARC. So I really want to confirm that this patch doesn't imply any regression before it is pushed.
This was one of my major concerns when writing the code, and I believe there are not any. However, I had limited UNIMARC authority data to test with. If you would be willing to send me more examples of hierarchical UNIMARC authorities, I would love to test the code against those, and fix any problems I find. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8523 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |katrin.fischer@bsz-bw.de --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Jared, I really like the new hiearchy view! I found 2 smaller problems testing this: 1) There is a doubled up )) in the database update message. 2) I created a topical subject B with a wider term A. The hierarchy shows nicely when I am on the lowest level. When I click on the higher level term A the lower hierarchies vanish from the tree view. Hope that is an understandable description :) 3) Suggestion: It took me a moment to figure out that the tree had clickable links, maybe a hover effect like we have on other links would make it clearer. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8523 --- Comment #5 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- (In reply to comment #4)
Hi Jared, I really like the new hiearchy view! I found 2 smaller problems testing this:
1) There is a doubled up )) in the database update message.
Fixed.
2) I created a topical subject B with a wider term A. The hierarchy shows nicely when I am on the lowest level. When I click on the higher level term A the lower hierarchies vanish from the tree view. Hope that is an understandable description :)
It is. However, this is the way the feature currently works with UNIMARC (which requires bidirectional links). Rather than make too large a change at once, I propose starting with my revised patch, which will still have this problem, and then, once it's working I'll do a follow-up adding a cron job to generate bidirectional links from the unidirectional links that are endemic to MARC21. Does this sound fair?
3) Suggestion: It took me a moment to figure out that the tree had clickable links, maybe a hover effect like we have on other links would make it clearer.
I changed the way links appear. Let me know what you think. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8523 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8523 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11360|0 |1 is obsolete| | --- Comment #6 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- Created attachment 11885 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11885&action=edit Bug 8523: Display auth hierarchies w/all marcflavours This commit adds support for displaying authority hierarchies for all flavours of MARC, not just UNIMARC. Display now uses the jQuery jstree plugin, selected with the help of Owen Leonard, resulting in a much faster experience for users. Be aware that the jstree file uses tabs rather than 4-space indentation, which I left as-is so as to make it easier to integrate upstream releases in the future. To test: 1) Enable the AuthDisplayHierarchy syspref 2) Create authority records with a hierarchy of see also fields (in MARC21/NORMARC, you'll be using 5xx fields for this, with a subfield $w=g for broader terms and subfield $w=h for narrower terms) 3) View the authorities in the OPAC, noting the hierarchical view at the top of the page. This initial patch does not create bidirection linkages from unidirectional links in MARC21 authorities. This means that when moving up the authority hierarchy, lower levels will disappear. This is intentional, as the first patch is intended merely to ensure that AuthDisplayHierarchy functions the same for all marcflavours. A future patch will add a cron job to generate the bidirectional linkages, once we are sure that the hierarchy functionality for UNIMARC and MARC21/NORMARC coexists peaceably. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8523 --- Comment #7 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- Created attachment 12083 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12083&action=edit Bug 8523 follow-up: support NORMARC, too Thanks to Katrin for pointing out that the original patch left NORMARC a second-class citizen. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8523 --- Comment #8 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- Created attachment 12084 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12084&action=edit Bug 8523: fix translatability The translator script was unable to handle arrayrefs in TT, so this patch modifies the way the hierarchy generator recurses to avoid the need for them. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8523 --- Comment #9 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- Created attachment 12086 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12086&action=edit Bug 8523 follow-up: always regenerate non-UNIMARC hierarchies -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8523 --- Comment #10 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- Created attachment 12089 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12089&action=edit Bug 8523 follow-up: sanitize HTML in template -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8523 --- Comment #11 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- Created attachment 12092 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12092&action=edit Bug 8523 follow-up: correctly handle leaves -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8523 --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Jared, this works almost perfectly now - one small issue: should the tree show me the authority I am currently looking at? For me the tree always shows the highest level when I open an authority from the result list 'details' link and after a refresh of the page. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8523 --- Comment #13 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 12097 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12097&action=edit screenshot For better illustration on how this works and looks like, I am adding a screenshot. It looks nice! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8523 --- Comment #14 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Frederic and Paul: I am testing this feature and I have created a UNIMARC installation using the sample database from the sandboxes. If you can give me some hints about how to catalogue the authorities correctly, I can try repeating my tests for UNIMARC. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8523 --- Comment #15 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- Created attachment 12100 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12100&action=edit Bug 8523 follow-up: quiet warning -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8523 --- Comment #16 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- (In reply to comment #12)
Jared, this works almost perfectly now - one small issue: should the tree show me the authority I am currently looking at? For me the tree always shows the highest level when I open an authority from the result list 'details' link and after a refresh of the page.
Could you take a screenshot of what you see right when you refresh? When I refresh, the hierarchy is automatically open to the current node. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8523 --- Comment #17 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- (In reply to comment #16)
Could you take a screenshot of what you see right when you refresh? When I refresh, the hierarchy is automatically open to the current node.
Never mind. Additional information over IRC has clarified the problem. Patch forthcoming. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8523 --- Comment #18 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- Created attachment 12101 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12101&action=edit Bug 8523 follow-up: always open tree to current node -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8523 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11885|0 |1 is obsolete| | Attachment #12083|0 |1 is obsolete| | Attachment #12084|0 |1 is obsolete| | Attachment #12086|0 |1 is obsolete| | Attachment #12089|0 |1 is obsolete| | Attachment #12092|0 |1 is obsolete| | Attachment #12100|0 |1 is obsolete| | Attachment #12101|0 |1 is obsolete| | --- Comment #19 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 12125 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12125&action=edit [SIGNED-OFF] Bug 8523: Display auth hierarchies w/all marcflavours This commit adds support for displaying authority hierarchies for all flavours of MARC, not just UNIMARC. Display now uses the jQuery jstree plugin, selected with the help of Owen Leonard, resulting in a much faster experience for users. Be aware that the jstree file uses tabs rather than 4-space indentation, which I left as-is so as to make it easier to integrate upstream releases in the future. To test: 1) Enable the AuthDisplayHierarchy syspref 2) Create authority records with a hierarchy of see also fields (in MARC21/NORMARC, you'll be using 5xx fields for this, with a subfield $w=g for broader terms and subfield $w=h for narrower terms) 3) View the authorities in the OPAC, noting the hierarchical view at the top of the page. This initial patch does not create bidirection linkages from unidirectional links in MARC21 authorities. This means that when moving up the authority hierarchy, lower levels will disappear. This is intentional, as the first patch is intended merely to ensure that AuthDisplayHierarchy functions the same for all marcflavours. A future patch will add a cron job to generate the bidirectional linkages, once we are sure that the hierarchy functionality for UNIMARC and MARC21/NORMARC coexists peaceably. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Resolved conflicts in updatedatabase.pl, sysprefs.sql and in one of the CSS files. Test plan: 1) Run t/AuthoritiesMarc.t New tests complete without any errors. 2) Make sure updatedatabase works correctly. Update works nicely, new system preference is also added to syspref.sql 3) Make sure new terms are translatable. Created new po files for de-DE and checked for new terms. All translations appear correctly. 4) Make sure everything works with AuthDisplayHieararchy OFF - Add authority - Edit authority - Delete authority 5) Test feature with AuthDisplayHieararchy ON - Add authority - Edit authority - Delete authority 6) Add a couple of hierarchically linked authorities Note: links have to be created in both directions Example: 151 $aGermany 551 $a Baden-Württemberg $w h 151 $aBaden-Württemberg 551 $a Konstanz $w h 551 $a Germany $w g 151 $aKonstanz 551 $a Baden-Württemberg $w g 551 $a Fürstenberg $w h 551 $a Paradies $w h 151 $a Fürstenberg 551 $a Konstanz $w g 151 $a Paradies 551 $a Konstanz $w g Tree shows up nicely above the authority record - in staff - in OPAC - on the normal view tab - on the MARC view tab 7) Checking the logs for warnings - no Javascript errors or warnings - no warnings or errors in log files -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8523 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8523 --- Comment #20 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This is a very cool feature *nudge* -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8523 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |paul.poulain@biblibre.com Version|master |rel_3_10 --- Comment #21 from Paul Poulain <paul.poulain@biblibre.com> --- QA comment: * passes koha-qa.pl * switch from something UNIMARC specific to MARC agnostic, plus introduce a more modern (& probably robust) way to handle/display hierarchies 2 small glitches, that are not worth failing QA but should be improved later: my authorities where 250$a Jardinage 250 $aJardinage$xLégumes 550$5b$aJardinage 550$5h$aJardinage bio The hierarchy is: Jardinage + Jardinage légumes + Jardinage bio BUT, as the "Legumes" is in $x and we display only the $a in the hierarchy, we see: Jardinage + Jardinage + Jardinage bio It's not the most common case in UNIMARC, but it happens. * the authority-detail still show Broader term & Narrower term when the hierarchy is ON. Maybe we could remove them ? (see screenshot) Overall = passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8523 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #22 from Paul Poulain <paul.poulain@biblibre.com> --- Patch pushed to master with some followup: * one for perlcritic C4/AuthoritiesMarc.pm * one for adding needed css for ccsr theme -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8523 --- Comment #23 from Nicole C. Engard <nengard@gmail.com> --- Created attachment 12565 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12565&action=edit looks different I'm trying to document this feature and have an authority with 500s on it (and I have the authorities for those 500s) but I'm not seeing anything but the one heading. Can you please give me an example of what to enter (a link to a LOC authority is fine) to see this in action on my system in Marc21? Nicole -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8523 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |8870 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8523 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal --- Comment #24 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- After conversation with Frédéric, it sounds like this patch really is more of a bugfix than an enhancement, since auth hierarchy support is definitely missing from MARC21/NORMARC, and this also improves the situation for UNIMARC installs (particularly in terms of performance). As such, this could be a candidate for 3.8.x. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8523 --- Comment #25 from Paul Poulain <paul.poulain@biblibre.com> --- I'm not against pushing this patch in 3.8, but just want to point that it changes some things in the display. This may trouble some users. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8523 --- Comment #26 from Frédéric Demians <frederic@tamil.fr> --- (En réponse au commentaire 25)
I'm not against pushing this patch in 3.8, but just want to point that it changes some things in the display. This may trouble some users.
It won't change that much for libraries using non-hierarchical authorities. For libraries having a thesaurus (authorities with semantic relations), the authorities are broken in 3.8 (bug 8870), and this bug (8523) is required to fix 8870. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8523 Bug 8523 depends on bug 8207, which changed state. Bug 8207 Summary: Modify authority type frameworks to allow see also fields to link to thesauri http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8207 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8523 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED CC| |chris@bigballofwax.co.nz Resolution|--- |FIXED --- Comment #27 from Chris Cormack <chris@bigballofwax.co.nz> --- Released in 3.10.0 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org