[Bug 15037] New: Batch checkout tab should be hidden for patrons not satisfying policy
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15037 Bug ID: 15037 Summary: Batch checkout tab should be hidden for patrons not satisfying policy Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: tomascohen@gmail.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com There's no use for the Batch checkout tab when the patron belongs to a category that is not listed in BatchCheckoutsValidCategories. I belive the tab should be hidden in that case. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15037 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |11759 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11759 [Bug 11759] Batch checkout -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15037 Heather Braum <hbraum@nekls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hbraum@nekls.org -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15037 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Could you please detail? The tab is hidden for me. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15037 --- Comment #2 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Steps to reproduce: - Set BatchCheckouts to "allow" - Set BatchCheckoutsValidCategories to ST - Have a patron in another category (for example S) - Go to that patron details => FAIL: You can see the "Batch checkouts" tab, if you choose it, Koh correctly says that patron category cannot be used for batch checkouts. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15037 --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- That's how I have tested, and it works here, weird. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15037 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15037 --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 43692 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43692&action=edit Bug 15037: Correctly check the patron categories on displaying the Batch checkout tab When checking for the patron categories allowed to use the batch checkout, the comparison should be strict (eq). Test plan: 0/ Do not apply this patch 1/ Create 2 patron categories ST and S 2/ Enable BatchCheckouts and define BatchCheckoutsValidCategories = S 3/ Create 2 patrons, 1 in the ST category and the other one in S 4/ On the patron detail page, you should see the "batch checkout" tab for both patron 5/ Apply this patch 6/ The tab should only be displayed for the patron S -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15037 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |jonathan.druart@bugs.koha-c |ity.org |ommunity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15037 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15037 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43692|0 |1 is obsolete| | --- Comment #5 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 43702 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43702&action=edit Bug 15037: Correctly check the patron categories on displaying the Batch checkout tab When checking for the patron categories allowed to use the batch checkout, the comparison should be strict (eq). Test plan: 0/ Do not apply this patch 1/ Create 2 patron categories ST and S 2/ Enable BatchCheckouts and define BatchCheckoutsValidCategories = S 3/ Create 2 patrons, 1 in the ST category and the other one in S 4/ On the patron detail page, you should see the "batch checkout" tab for both patron 5/ Apply this patch 6/ The tab should only be displayed for the patron S Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Tested using an 'S' patron and allowing 'ST' patrons only, worked as expected. Also tried setting &batch=1 to force it to show the batch page, and it says I'm not allowed to do batch checkouts for that patron. Great! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15037 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15037 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43702|0 |1 is obsolete| | --- Comment #6 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 43815 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43815&action=edit [PASSED QA] Bug 15037: Correctly check the patron categories on displaying the Batch checkout tab When checking for the patron categories allowed to use the batch checkout, the comparison should be strict (eq). Test plan: 0/ Do not apply this patch 1/ Create 2 patron categories ST and S 2/ Enable BatchCheckouts and define BatchCheckoutsValidCategories = S 3/ Create 2 patrons, 1 in the ST category and the other one in S 4/ On the patron detail page, you should see the "batch checkout" tab for both patron 5/ Apply this patch 6/ The tab should only be displayed for the patron S Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Tested using an 'S' patron and allowing 'ST' patrons only, worked as expected. Also tried setting &batch=1 to force it to show the batch page, and it says I'm not allowed to do batch checkouts for that patron. Great! Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15037 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43815|0 |1 is obsolete| | --- Comment #7 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 43816 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43816&action=edit [PASSED QA] Bug 15037: Correctly check the patron categories on displaying the Batch checkout tab When checking for the patron categories allowed to use the batch checkout, the comparison should be strict (eq). Test plan: 0/ Do not apply this patch 1/ Create 2 patron categories ST and S 2/ Enable BatchCheckouts and define BatchCheckoutsValidCategories = S 3/ Create 2 patrons, 1 in the ST category and the other one in S 4/ On the patron detail page, you should see the "batch checkout" tab for both patron 5/ Apply this patch 6/ The tab should only be displayed for the patron S Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Tested using an 'S' patron and allowing 'ST' patrons only, worked as expected. Also tried setting &batch=1 to force it to show the batch page, and it says I'm not allowed to do batch checkouts for that patron. Great! Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15037 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com Status|Passed QA |Pushed to Master --- Comment #8 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org