[Bug 14776] New: SCO/shelfcheck 'log out' option redirects to OPAC, not back to SCO
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14776 Bug ID: 14776 Summary: SCO/shelfcheck 'log out' option redirects to OPAC, not back to SCO Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Self checkout Assignee: koha-bugs@lists.koha-community.org Reporter: mtj@kohaaloha.com QA Contact: testopia@bugs.koha-community.org Created attachment 42311 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42311&action=edit pic SCO 'log out' option redirects to OPAC, not back to SCO pic attached -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14776 --- Comment #1 from Mason James <mtj@kohaaloha.com> --- 3 urls redirect to the OPAC, in... koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead-sco.inc thus, it is possible for a user to accidentally 'log out' of the SCO completely, requiring staff to fix the SCO -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14776 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=10598 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14776 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron@veron.ch --- Comment #2 from Marc Véron <veron@veron.ch> --- Additionally, there is a link to the "selfcheck" user's account ("Welcome, selfcheck"), as defined in syspref AutoSelfCheckID. It makes no sense that the user can access this information. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14776 --- Comment #3 from Marc Véron <veron@veron.ch> --- ...and the language menu is missing if syspref OpacLangSelectorMode is set to 'top' or to 'both' -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14776 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |veron@veron.ch |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14776 --- Comment #4 from Marc Véron <veron@veron.ch> --- Created attachment 42423 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42423&action=edit Bug 14776 - Remove 'selfcheck' patron related links from and add language selector to SCO header The SCO screen displays patron related menu items in it's header (Link to the account and "Logout"). This makes no sense since the patron that is logged in is the 'selfcheck' user as defined in syspref AutoSelfCheckId. Additionally, the language menue is missing when the syspref OpacLangSelectorMode is set to 'top' or to 'both'. To test: - Set AutoSelfCheck sysprefs as appropriate - Set OpacLangSelectorMode to 'top' or 'both' - Go to SCO page - Verify that the language menue does not display in the header - Enter a card number to check out (this logs in the SCO user) - Verify that you get text similar to "Welcome, checkout" with a link to the sco user's account in the OPAC and a 'Logout' link - Apply patch - Verify that the language menu appears and the SCO user's information disappears. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14776 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14776 Chris Kirby <christopherlawrencekirby@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |christopherlawrencekirby@gm | |ail.com Status|Needs Signoff |Signed Off --- Comment #5 from Chris Kirby <christopherlawrencekirby@gmail.com> --- Tested on sandboxes as follows: - Set OpacLangSelectorMode to 'both' - Went to SCO page - Verified that the language menu did not display in the header - Entered a card number to check out (this logs in the SCO user) - Verified that you get text similar to "Welcome, checkout" with a link to the sco user's account in the OPAC and a 'Logout' link - Requested that that patch be applied to a separate sandbox - Verified that the language menu appears and the SCO user's information disappears. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14776 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Marc, It looks like this code comes from includes/masthead.inc and/or includes/opac-bottom.inc. Could you confirm (I have not compared the diff line by line)? In this case, it's certainly the good time to refactor it :) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14776 --- Comment #7 from Marc Véron <veron@veron.ch> --- Jonathan, Good idea. Are you thinking about an extra include for the language menue that would be inserted into koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead.inc and koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead-sco.inc ? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14776 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |15039 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15039 [Bug 15039] Move top language menu to include and streamline logic -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14776 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14776 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42423|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14776 --- Comment #8 from Marc Véron <veron@veron.ch> --- Created attachment 43659 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43659&action=edit Bug 14776 - Remove 'selfcheck' patron related links from and add language selector to SCO header The SCO screen displays patron related menu items in it's header (Link to the account and "Logout"). This makes no sense since the patron that is logged in is the 'selfcheck' user as defined in syspref AutoSelfCheckId. Additionally, the language menue is missing when the syspref OpacLangSelectorMode is set to 'top' or to 'both'. To test: - Apply on top of Bug 15039 - Set AutoSelfCheck sysprefs as appropriate - Set OpacLangSelectorMode to 'top' or 'both' - Go to SCO page - Verify that the language menue does not display in the header - Enter a card number to check out (this logs in the SCO user) - Verify that you get text similar to "Welcome, checkout" with a link to the sco user's account in the OPAC and a 'Logout' link - Apply patch - Verify that the language menu appears and the SCO user's information disappears. - Verify, that the language menu displays / does not display with combinations of: - opaclanguagedisplay (Allow) - opaclanguages ( > 1 language selected) - OpacLangSelectorMode (top or both) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14776 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|Small patch |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14776 --- Comment #9 from Chris Kirby <christopherlawrencekirby@gmail.com> --- Hi Marc, I am testing here on Sandbox 8, and here is what I am finding: testing with AutoSelfCheckAllowed DISABLED: when one visits /cgi-bin/koha/sco/sco-main.pl there is an option to login. However, once logged in, you are redirected to /cgi-bin/koha/opac-user.pl If one has already logged into Koha with staff credentials, and then visits /cgi-bin/koha/sco/sco-main.pl, the patch is successful. testing with AutoSelfCheckAllowed ENABLED: Your patch works when the AutoSelfCheckAllowed preference is enabled and login credentials have been stored. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14776 --- Comment #10 from Marc Véron <veron@veron.ch> --- Hi Chris, Thanks for testing. Questions: - How is the behaviour without patch? It seems to me that it behaves the same (redirect to a login page). - What would you expect to happen if AutoSelfCheckAllowed is DISABLED? - Maybe your finding is something for a separate bug? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14776 Chris Kirby <christopherlawrencekirby@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #11 from Chris Kirby <christopherlawrencekirby@gmail.com> --- Hi Marc,
How is the behaviour without patch? It seems to me that it behaves the same (redirect to a login page). Without the patch, the behavior is the same.
What would you expect to happen if AutoSelfCheckAllowed is DISABLED? I was expect to have a login page for the selfcheck and then the SCO user's information is hidden, just as your patch achieves.
Maybe your finding is something for a separate bug? Yes, this might make sense if there is a desire to use the selfcheck when AutoSelfCheckAllowed is DISABLED.
Signed off on patch: Applied on top of Bug 15039 - Set AutoSelfCheckAllowed to ENABLED, and provided values for AutoSelfCheckID, AutoSelfCheckPass - Set OpacLangSelectorMode to 'top' or 'both' - Went to SCO page - Verified that the language menu does not display in the header - Entered a card number to check out (this logs in the SCO user) - Verified that you get text similar to "Welcome, checkout" with a link to the sco user's account in the OPAC and a 'Logout' link - Applied patch for 14776 - Verified that the language menu appears and the SCO user's information disappears. - Verified, that the language menu displays / does not display with combinations of: - opaclanguagedisplay (Allow) - opaclanguages ( > 1 language selected) - OpacLangSelectorMode (top or both) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14776 --- Comment #12 from Marc Véron <veron@veron.ch> --- Hi Chris, Thanks for your comments. I propose that you file a new bug that describes the behaviour you would like to see when AutoSelfCheckAllowed is DISABLED. Regarding your sign-off: Did you just switch the status? Ot did you forget to attach the patch with your sign-off? It seems that the patch itself did not change. See http://wiki.koha-community.org/wiki/Sign_off_on_patches and http://wiki.koha-community.org/wiki/Git_bz_configuration (I use the git bz method). -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14776 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14776 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43659|0 |1 is obsolete| | --- Comment #13 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 43804 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43804&action=edit Bug 14776 - Remove 'selfcheck' patron related links from and add language selector to SCO header The SCO screen displays patron related menu items in it's header (Link to the account and "Logout"). This makes no sense since the patron that is logged in is the 'selfcheck' user as defined in syspref AutoSelfCheckId. Additionally, the language menue is missing when the syspref OpacLangSelectorMode is set to 'top' or to 'both'. To test: - Apply on top of Bug 15039 - Set AutoSelfCheck sysprefs as appropriate - Set OpacLangSelectorMode to 'top' or 'both' - Go to SCO page - Verify that the language menue does not display in the header - Enter a card number to check out (this logs in the SCO user) - Verify that you get text similar to "Welcome, checkout" with a link to the sco user's account in the OPAC and a 'Logout' link - Apply patch - Verify that the language menu appears and the SCO user's information disappears. - Verify, that the language menu displays / does not display with combinations of: - opaclanguagedisplay (Allow) - opaclanguages ( > 1 language selected) - OpacLangSelectorMode (top or both) Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14776 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen@gmail.com --- Comment #14 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patches pushed to master. Thanks Jonathan and Marc! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14776 --- Comment #15 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Sorry Johathan, no credit for you on this one :-P -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org