http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6018 --- Comment #2 from Chris Cormack <chris@bigballofwax.co.nz> 2011-03-31 02:14:43 UTC --- Created attachment 3562 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=3562 Followup patch -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6018 --- Comment #3 from Chris Cormack <chris@bigballofwax.co.nz> 2011-03-31 02:34:15 UTC --- MT3269 : BatchMod Feature blanking subfields there is now a checkbox after each label that you can check in order to wipe out the corresponding subfield in all the items MT3269 Fixing tools/batchMod.pl tags/subfields display display all the subfields used in framework no matter if they are hidden or shown -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6018 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard@gmail.com Patch Status|Needs Signoff |Failed QA --- Comment #4 from Nicole C. Engard <nengard@gmail.com> 2011-03-31 14:27:38 UTC --- On testing the first patch I find that only the first item has it's value changed. I had 2 items and chose a shelving location value and it only applied to the first item - not both of them. I also chose to remove that shelving location using the checkbox and nothing happened ... when I applied the follow up I got the following on the batch item mod page: Software error: syntax error at /home/nengard/kohaclone/tools/batchMod.pl line 326, near "elsif" Global symbol "@authorised_values" requires explicit package name at /home/nengard/kohaclone/tools/batchMod.pl line 327. Global symbol "$tag" requires explicit package name at /home/nengard/kohaclone/tools/batchMod.pl line 327. Global symbol "$subfield" requires explicit package name at /home/nengard/kohaclone/tools/batchMod.pl line 327. Global symbol "@authorised_values" requires explicit package name at /home/nengard/kohaclone/tools/batchMod.pl line 331. Global symbol "%authorised_lib" requires explicit package name at /home/nengard/kohaclone/tools/batchMod.pl line 332. syntax error at /home/nengard/kohaclone/tools/batchMod.pl line 336, near "}" Global symbol "$tag" requires explicit package name at /home/nengard/kohaclone/tools/batchMod.pl line 337. Global symbol "$subfield" requires explicit package name at /home/nengard/kohaclone/tools/batchMod.pl line 337. Global symbol "@authorised_values" requires explicit package name at /home/nengard/kohaclone/tools/batchMod.pl line 338. Global symbol "$tag" requires explicit package name at /home/nengard/kohaclone/tools/batchMod.pl line 338. Global symbol "$subfield" requires explicit package name at /home/nengard/kohaclone/tools/batchMod.pl line 338. Global symbol "$value" requires explicit package name at /home/nengard/kohaclone/tools/batchMod.pl line 345. Global symbol "$value" requires explicit package name at /home/nengard/kohaclone/tools/batchMod.pl line 345. Global symbol "@authorised_values" requires explicit package name at /home/nengard/kohaclone/tools/batchMod.pl line 347. Global symbol "%authorised_lib" requires explicit package name at /home/nengard/kohaclone/tools/batchMod.pl line 348. Global symbol "$value" requires explicit package name at /home/nengard/kohaclone/tools/batchMod.pl line 350. Global symbol "$value" requires explicit package name at /home/nengard/kohaclone/tools/batchMod.pl line 350. syntax error at /home/nengard/kohaclone/tools/batchMod.pl line 353, near "}" /home/nengard/kohaclone/tools/batchMod.pl has too many errors. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6018 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |6068 -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6018 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Failed QA |Does not apply --- Comment #8 from Julian Maurice <julian.maurice@biblibre.com> 2011-12-02 14:07:34 UTC --- It seems that the first patch is already in master (see bug 6068). But the second patch does not apply on master. Applying: Bug 6018 : MT3269 Fixing tools/batchMod.pl tags/subfields display /home/julian/koha/versions/community-master/.git/rebase-apply/patch:14: trailing whitespace. use C4::Branch; /home/julian/koha/versions/community-master/.git/rebase-apply/patch:50: space before tab in indent. next if ($tag ne $itemtagfield); /home/julian/koha/versions/community-master/.git/rebase-apply/patch:56: space before tab in indent. next if (!defined ($tagslib->{$tag}->{$subfield}->{'tab'}) || $tagslib->{$tag}->{$subfield}->{'tab'} eq -1); /home/julian/koha/versions/community-master/.git/rebase-apply/patch:89: trailing whitespace. $attributes_no_value = qq(disabled="disabled"); /home/julian/koha/versions/community-master/.git/rebase-apply/patch:162: trailing whitespace. error: patch failed: tools/batchMod.pl:27 error: tools/batchMod.pl: patch does not apply Patch failed at 0001 Bug 6018 : MT3269 Fixing tools/batchMod.pl tags/subfields display -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6018 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|rel_3_4 |master -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6018 --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Second patch does not apply and can't fix the conflict. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6018 --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I think it might be good to show all subfields, because you can have items from different frameworks on your list easily. Not sure which framework is used in this case currently? There are also fields like onloan you don't want people to batch edit. I am not sure, what the best solution here is. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.