http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8028 Kyle M Hall <kyle.m.hall@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Make table collapsing on |Make table collapsing on |parel.pl sticky |parcel.pl sticky -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8028 Kyle M Hall <kyle.m.hall@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8028 --- Comment #3 from Kyle M Hall <kyle.m.hall@gmail.com> --- (In reply to comment #2)

Hi Kyle, wouldn't it work to pass around the setting instead of using cookies?

That would work for refreshing the page, but not for moving from say parcel.pl to the item details page and back. It could be done, but would require far more code and I don't see any advantage to that. The alternative would be a system preference, but then the librarians would be in the opposite situation, where if they wanted it collapsed, they'd have to click the link every time. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8028 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9372|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 10797 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10797&action=edit Bug 8028 - Make table collapsing on parcel.pl sticky The tables on parcel.pl default to show only the first five items in the table, and librarians must click the a link to display all the items. Every time the page is reloaded, the table gets re-collapsed, and the librarian must again click the link. Parcel.pl should remember which way the table is set and keep it that way until it is changed again. This is accomplished by adding two cookies for this page, one for each table. This cookie stores the state of the table ( collapsed, or uncollapsed ) and sets each table to the correct state on each page load. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Works as expected. But a "funny" behaviour, if I have only 1 item (or < 6): All 1 items are displayed. Click here to show only the first 5 items. and Only the first 5 items are displayed. Click here to show all 1 items. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8028 kyle.m.hall@gmail.com <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com --- Comment #5 from kyle.m.hall@gmail.com <kyle@bywatersolutions.com> --- If anyone has a suggestion for a good way to word this, I will write a patch to update the language. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8028 --- Comment #7 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 10878 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10878&action=edit Bug 8028 - Make table collapsing on parcel.pl sticky - Hide link for 5 or fewer items. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8028 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.poulain@biblibre.com --- Comment #9 from Paul Poulain <paul.poulain@biblibre.com> --- QA comment: I'm unable to understand & reproduce the problem and the solution. Could you give me more explanations ? A screenshot ? 2 comments (that will maybe be removed when I understand & reproduce): * is using a cookie the best way to do that ? * isn't DataTable jquery plugin what we should use ? -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8028 Ian Walls <koha.sekjal@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |koha.sekjal@gmail.com --- Comment #11 from Ian Walls <koha.sekjal@gmail.com> --- Adds a couple small cookies for stickiness, and some logic to handle them. Followup patch fixes conditional nesting. Marking Passed QA. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8028 --- Comment #13 from Paul Poulain <paul.poulain@biblibre.com> --- Kyle, ping on my comment 12. I need to test that before pushing ! -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8028 --- Comment #15 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to comment #12)

mmm... I made a basket with 6 lines, and had another one with 2 lines pending. When I reach the parcel.pl page, I see the 8 pending lines directly, and no link to collapse/expand. Am I missing something ?

(I recieved 4 of them, and saw no change)

Good catch. I've attach a small followup to fix the issue. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8028 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=9130 -- You are receiving this mail because: You are watching all bug changes.