[Bug 33412] New: Problem importing records (bug 15869 follow-up) wrong use of assignment
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33412 Bug ID: 33412 Summary: Problem importing records (bug 15869 follow-up) wrong use of assignment Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: koha-bugs@lists.koha-community.org Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org $overlay_framework = undef if $overlay_framework = '_USE_ORIG'; should clearly be: $overlay_framework = undef if $overlay_framework eq '_USE_ORIG'; -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33412 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |15869 Patch complexity|--- |Trivial patch Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15869 [Bug 15869] Change framework on overlay -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33412 --- Comment #1 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 149201 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149201&action=edit Bug 33412: Fix comparison -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33412 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal Assignee|koha-bugs@lists.koha-commun |nick@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33412 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33412 --- Comment #2 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 150191 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150191&action=edit Bug 33412: Fix comparison when checking for overlay framework TO test: 1 - Cataloging -> Export catalog data 2 - Export a record fom your catalog 3 - Cataloging -> Stage record for import 4 - Import the record, use Record matchign rule: KohaBiblio (999c) 5 - Stage, view batch 6 - Record should match the one that was exported 7 - When replacing record use this framework, choose a different value than current framework of record 8 - Import this batch 9 - View and edit record - note framework did not change 10 - Apply patch 11 - Restart all 12 - Repeat 4-8 13 - View and edit record, confirm framework has changed 14 - Sign off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33412 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149201|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33412 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33412 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150191|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 150622 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150622&action=edit Bug 33412: Fix comparison when checking for overlay framework TO test: 1 - Cataloging -> Export catalog data 2 - Export a record fom your catalog 3 - Cataloging -> Stage record for import 4 - Import the record, use Record matchign rule: KohaBiblio (999c) 5 - Stage, view batch 6 - Record should match the one that was exported 7 - When replacing record use this framework, choose a different value than current framework of record 8 - Import this batch 9 - View and edit record - note framework did not change 10 - Apply patch 11 - Restart all 12 - Repeat 4-8 13 - View and edit record, confirm framework has changed 14 - Sign off Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33412 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- As the feature is already in stable releases it might be nice to rephrase the bug description a little to be more descriptive of how the problem manifests. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33412 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Problem importing records |(bug 15869 follow-up) |(bug 15869 follow-up) wrong |Overlay record framework is |use of assignment |always setting records to | |original framework -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33412 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |glasklas@gmail.com --- Comment #5 from Phil Ringnalda <phil@chetcolibrary.org> --- *** Bug 33342 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33412 Mengu Yazicioglu <mengu@devinim.com.tr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mengu@devinim.com.tr --- Comment #6 from Mengu Yazicioglu <mengu@devinim.com.tr> --- (In reply to Katrin Fischer from comment #4)
As the feature is already in stable releases it might be nice to rephrase the bug description a little to be more descriptive of how the problem manifests.
Strongly agree. What about adding stage marc import and manage-marc-import.pl keywords in the title? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33412 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |phil@chetcolibrary.org Status|Signed Off |Failed QA --- Comment #7 from Phil Ringnalda <phil@chetcolibrary.org> --- Test plan was missing a step where you import with Keep original framework and verify that the job succeeds. Since the option value is _USE_ORIG_ with a trailing underscore, it doesn't get undeffed by checking for eq to _USE_ORIG without a trailing underscore, and the job fails. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33412 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #8 from David Nind <david@davidnind.com> --- Some discussion on this issue on the mailing list over the last couple of days: - Development list: https://lists.koha-community.org/pipermail/koha-devel/2023-May/048136.html - Main list: https://lists.katipo.co.nz/pipermail/koha/2023-May/059402.html -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33412 Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |emily.lamancusa@montgomeryc | |ountymd.gov -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33412 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33412 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150622|0 |1 is obsolete| | --- Comment #9 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 150804 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150804&action=edit Bug 33412: Fix comparison when checking for overlay framework TO test: 1 - Cataloging -> Export catalog data 2 - Export a record fom your catalog 3 - Cataloging -> Stage record for import 4 - Import the record, use Record matchign rule: KohaBiblio (999c) 5 - Stage, view batch 6 - Record should match the one that was exported 7 - When replacing record use this framework, choose a different value than current framework of record 8 - Import this batch 9 - View and edit record - note framework did not change 10 - Apply patch 11 - Restart all 12 - Repeat 4-8 13 - View and edit record, confirm framework has changed 14 - Sign off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33412 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33412 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150804|0 |1 is obsolete| | --- Comment #10 from David Nind <david@davidnind.com> --- Created attachment 150809 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150809&action=edit Bug 33412: Fix comparison when checking for overlay framework TO test: 1 - Cataloging -> Export catalog data 2 - Export a record fom your catalog 3 - Cataloging -> Stage record for import 4 - Import the record, use Record matchign rule: KohaBiblio (999c) 5 - Stage, view batch 6 - Record should match the one that was exported 7 - When replacing record use this framework, choose a different value than current framework of record 8 - Import this batch 9 - View and edit record - note framework did not change 10 - Apply patch 11 - Restart all 12 - Repeat 4-8 13 - View and edit record, confirm framework has changed 14 - Sign off Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33412 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I've now repeated the steps several times, but this doesn't seem to work right for me: 1) Exported Perl best practices (biblionumber 5) 2) Staged for import, match on biblionumber, replace, don't process items 3) The record matched on biblionumber 4) When replacing records use this framework: Kit 5) Imported the record 6) Framework remains Books, Booklets, ... Patch was applied, restarted all multiple times. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33412 --- Comment #12 from David Nind <david@davidnind.com> --- Created attachment 150817 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150817&action=edit Screenshots - settings and results after patch applied I tested again, using the record you used, and it still worked for me. So I'm not sure why it isn't working for you 8-(. I also tested with settings changed about not checking for embedded data and not importing items (even though there isn't in this case), but it still worked. Also, I normally go flushed_memcached and restart_all after applying a patch, as well as using a fresh browser (with a cleared cache). This time I just did a restart_all and then used the same browser windows. It still worked OK. In addition, I re-staged the file for import, rather than using the previously staged batch. I've attached some screenshots of the settings I used and the results, if this helps. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33412 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #13 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi David, thx for taking the time! I'll reset to Signed off, I won't have time right now to dig deeper on this one and another set of eyes might help. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33412 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33412 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150809|0 |1 is obsolete| | --- Comment #14 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 150822 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150822&action=edit Bug 33412: Fix comparison when checking for overlay framework TO test: 1 - Cataloging -> Export catalog data 2 - Export a record fom your catalog 3 - Cataloging -> Stage record for import 4 - Import the record, use Record matchign rule: KohaBiblio (999c) 5 - Stage, view batch 6 - Record should match the one that was exported 7 - When replacing record use this framework, choose a different value than current framework of record 8 - Import this batch 9 - View and edit record - note framework did not change 10 - Apply patch 11 - Restart all 12 - Repeat 4-8 13 - View and edit record, confirm framework has changed 14 - Sign off Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33412 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com Severity|normal |major Keywords| |rel_22_11_candidate -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33412 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33412 --- Comment #15 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33412 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.05.00 |23.05.00,22.11.06 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33412 --- Comment #16 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Nice work everyone! Pushed to stable for 22.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33412 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33412 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Status|Pushed to stable |RESOLVED Resolution|--- |FIXED --- Comment #17 from Lucas Gass <lucas@bywatersolutions.com> --- Missing dependencies for 22.05.x, no backport. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org