[Bug 33613] New: Claim return doesn't charge when "Ask if a lost fee should be charged" is selected and marked to charge
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33613 Bug ID: 33613 Summary: Claim return doesn't charge when "Ask if a lost fee should be charged" is selected and marked to charge Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: lisette.scheer@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com To recreate: 1. Have an item with a replacement cost checked out to a patron 2. Set the ClaimReturnedChargeFee sys pref to "Ask if a lost fee should be charged" 3. Make a claim and check the box for charging. 4. Claim happens but no charge occurs. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33613 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #1 from Lucas Gass <lucas@bywatersolutions.com> --- In modal-claims.inc: let fee = $('#claims-returned-charge-lost-fee').attr('checked') ? true : false; attr() won't always evaluate to true and I think prop() is a much better choice in this circumstance. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33613 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33613 --- Comment #2 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 150237 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150237&action=edit Bug 33613: Use prop() to evaluate checkbox To test: 1. Have an item with a replacement cost checked out to a patron 2. Set the ClaimReturnedChargeFee sys pref to "Ask if a lost fee should be charged" 3. Make a claim and check the box for charging. 4. Claim happens but no charge occurs. 5. Apply patch and try again. 6. A charge should now occur. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33613 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |lucas@bywatersolutions.com |ity.org | Severity|enhancement |normal Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33613 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33613 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #3 from David Nind <david@davidnind.com> --- Hi Lucas. While this works, I'm getting this behavour: 1. When clicking on 'Claim returned' button, I get a spinning icon in place of the button and an error in the web developer console: Uncaught TypeError: value.match is not a function. 2. Even though the button is pressed just once, there are two entries in the Details section under the claims tab - in the Check out section claims tab it only appears once. This was tested using Firefox. David Testing notes (using KTD): 1. To set up claims to work: set system preference ClaimReturnedLostValue to 1 2. From a patron's checkout list, Check out > Checkouts tab - click on the Claim returned button in the return claims column: - Get spinning icon in place of the button - In the web developer tools console: Uncaught TypeError: value.match is not a function -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33613 --- Comment #4 from Lucas Gass <lucas@bywatersolutions.com> --- David, I see that too! It looks like it is happening with or without this patch. I filed a seperate bug for it: Bug 33616 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33613 --- Comment #5 from David Nind <david@davidnind.com> --- (In reply to Lucas Gass from comment #4)
David,
I see that too! It looks like it is happening with or without this patch. I filed a seperate bug for it:
Bug 33616
Thanks Lucas, Sign off for this one coming. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33613 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33613 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150237|0 |1 is obsolete| | --- Comment #6 from David Nind <david@davidnind.com> --- Created attachment 150252 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150252&action=edit Bug 33613: Use prop() to evaluate checkbox To test: 1. Have an item with a replacement cost checked out to a patron 2. Set the ClaimReturnedChargeFee sys pref to "Ask if a lost fee should be charged" 3. Make a claim and check the box for charging. 4. Claim happens but no charge occurs. 5. Apply patch and try again. 6. A charge should now occur. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33613 Hinemoea Viault <hinemoea.viault@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150252|0 |1 is obsolete| | --- Comment #7 from Hinemoea Viault <hinemoea.viault@inlibro.com> --- Created attachment 150802 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150802&action=edit Bug 33613: Use prop() to evaluate checkbox To test: 1. Have an item with a replacement cost checked out to a patron 2. Set the ClaimReturnedChargeFee sys pref to "Ask if a lost fee should be charged" 3. Make a claim and check the box for charging. 4. Claim happens but no charge occurs. 5. Apply patch and try again. 6. A charge should now occur. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Hinemoea Viault <hinemoea.viault@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33613 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33613 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150802|0 |1 is obsolete| | --- Comment #8 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 150829 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150829&action=edit Bug 33613: Use prop() to evaluate checkbox To test: 1. Have an item with a replacement cost checked out to a patron 2. Set the ClaimReturnedChargeFee sys pref to "Ask if a lost fee should be charged" 3. Make a claim and check the box for charging. 4. Claim happens but no charge occurs. 5. Apply patch and try again. 6. A charge should now occur. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Hinemoea Viault <hinemoea.viault@inlibro.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33613 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |29983 CC| |jonathan.druart+koha@gmail. | |com Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29983 [Bug 29983] Display the return claims column in the circulation overdues page (overdue.tt) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33613 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33613 --- Comment #9 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33613 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.05.00 |23.05.00,22.11.06 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33613 --- Comment #10 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Nice work everyone! Pushed to stable for 22.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33613 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to stable |RESOLVED --- Comment #11 from Lucas Gass <lucas@bywatersolutions.com> --- Missing dependencies for 22.05.x, no backport. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org