[Bug 24417] New: Charges/Fees.t is failing randomly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24417 Bug ID: 24417 Summary: Charges/Fees.t is failing randomly Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Test Suite Assignee: chris@bigballofwax.co.nz Reporter: jonathan.druart@bugs.koha-community.org QA Contact: testopia@bugs.koha-community.org I cannot recreate locally, but Jenkins has a failing test on Koha_19.11_U18, run 29: koha_1 | # Failed test 'Daily rental charge calculated correctly with finesCalendar = noFinesWhenClosed and closed Monday' koha_1 | # at t/db_dependent/Koha/Charges/Fees.t line 362. koha_1 | # got: '6' koha_1 | # expected: '5' koha_1 | koha_1 | # Failed test 'Hourly rental charge calculated correctly with finesCalendar = noFinesWhenClosed and closed Monday (96h - 24h * 0.25u)' koha_1 | # at t/db_dependent/Koha/Charges/Fees.t line 396. koha_1 | # got: '24' koha_1 | # expected: '18' koha_1 | # Looks like you failed 2 tests of 7. koha_1 | koha_1 | # Failed test 'accumulate_rentalcharge tests' koha_1 | # at t/db_dependent/Koha/Charges/Fees.t line 403. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24417 Joy Nelson <joy@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joy@bywatersolutions.com --- Comment #1 from Joy Nelson <joy@bywatersolutions.com> --- Let me know if something needs doing on 19.11.x branch. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24417 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |25551 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25551 [Bug 25551] [OMNIBUS] Some tests are failing randomly -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24417 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor@tuxayo.net --- Comment #2 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Same failure, Koha_19.05_U18 https://jenkins.koha-community.org/view/19.05/job/Koha_19.05_U18/234/console... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24417 --- Comment #3 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Was able to get a failure locally with koha-testing-docker with KOHA_IMAGE=19.05-stretch. Not sure if it's the same issue though. t/db_dependent/Koha/Charges/Fees.t .. 1/8 # Failed test 'from_date default set correctly to today' # at t/db_dependent/Koha/Charges/Fees.t line 199. # got: '2020-06-12T05:05:16' # expected: '2020-06-12T05:05:17' # Looks like you failed 1 test of 9. t/db_dependent/Koha/Charges/Fees.t .. 2/8 # Failed test 'new' # at t/db_dependent/Koha/Charges/Fees.t line 201. # Looks like you failed 1 test of 8. t/db_dependent/Koha/Charges/Fees.t .. Dubious, test returned 1 (wstat 256, 0x100) Failed 1/8 subtests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24417 --- Comment #4 from Victor Grousset/tuxayo <victor@tuxayo.net> --- (after 3100 runs) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24417 --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Victor Grousset/tuxayo from comment #3)
Was able to get a failure locally with koha-testing-docker with KOHA_IMAGE=19.05-stretch. Not sure if it's the same issue though.
t/db_dependent/Koha/Charges/Fees.t .. 1/8 # Failed test 'from_date default set correctly to today' # at t/db_dependent/Koha/Charges/Fees.t line 199. # got: '2020-06-12T05:05:16' # expected: '2020-06-12T05:05:17' # Looks like you failed 1 test of 9. t/db_dependent/Koha/Charges/Fees.t .. 2/8 # Failed test 'new' # at t/db_dependent/Koha/Charges/Fees.t line 201. # Looks like you failed 1 test of 8. t/db_dependent/Koha/Charges/Fees.t .. Dubious, test returned 1 (wstat 256, 0x100) Failed 1/8 subtests
This is something different. 201 is( $fees->from_date, dt_from_string(), 202 'from_date default set correctly to today' ); It can be fixed using t::lib::Dates::compare -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24417 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=25729 --- Comment #6 from Victor Grousset/tuxayo <victor@tuxayo.net> --- bug has been opened 25729 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24417 --- Comment #7 from Victor Grousset/tuxayo <victor@tuxayo.net> --- comments related to bug 25729 were marked as obsolete (In reply to Victor Grousset/tuxayo from comment #2)
Same failure, Koha_19.05_U18 https://jenkins.koha-community.org/view/19.05/job/Koha_19.05_U18/234/ consoleText
This is still valid even if I couldn't reproduce locally. koha_1 | # Failed test 'Daily rental charge calculated correctly with finesCalendar = noFinesWhenClosed and closed Thursday' koha_1 | # at t/db_dependent/Koha/Charges/Fees.t line 362. koha_1 | # got: '6' koha_1 | # expected: '5' koha_1 | koha_1 | # Failed test 'Hourly rental charge calculated correctly with finesCalendar = noFinesWhenClosed and closed Thursday (96h - 24h * 0.25u)' koha_1 | # at t/db_dependent/Koha/Charges/Fees.t line 396. koha_1 | # got: '24' koha_1 | # expected: '18' koha_1 | # Looks like you failed 2 tests of 7. koha_1 | koha_1 | # Failed test 'accumulate_rentalcharge tests' koha_1 | # at t/db_dependent/Koha/Charges/Fees.t line 403. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24417 --- Comment #8 from Victor Grousset/tuxayo <victor@tuxayo.net> --- https://jenkins.koha-community.org/view/19.05/job/Koha_19.05_U18/256/console... -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org