[Bug 24353] New: privacy_guarantor_checkouts incorrectly shows No on moremember.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24353 Bug ID: 24353 Summary: privacy_guarantor_checkouts incorrectly shows No on moremember.pl Change sponsored?: --- Product: Koha Version: 19.05 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: andrew@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com To Test: - find/create a patron with a guarantor - Set AllowStaffToSetCheckoutsVisibilityForGuarantor and AllowPatronToSetCheckoutsVisibilityForGuarantor to Allow - Edit patron to set Show Checkouts to Guarantor to Yes - Confirm patron incorrectly shows "No" on moremember.pl - Confirm patron correctly shows "Yes" on memberentry.pl and opac-privacy.pl - Confirm patron correctly shows privacy_guarantor_checkouts=1 in database -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24353 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- This is ok on master. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24353 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |katrin.fischer@bsz-bw.de |ity.org | Summary|privacy_guarantor_checkouts |[19.05] |incorrectly shows No on |privacy_guarantor_checkouts |moremember.pl |incorrectly shows No on | |moremember.pl --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- 19.05: [% IF privacy_guarantor_checkouts %] master: [% IF patron.privacy_guarantor_checkouts %] 19.11: [% IF patron.privacy_guarantor_checkouts %] I'll provide a patch. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24353 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24353 --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 105301 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105301&action=edit Bug 24353: [19.05] Correct display of privacy_guarantor_checkouts on moremember.pl The variable for 'Show checkouts to guarantor' was incorrect so it would always show as 'No' on the Details tab in the patron account in staff. To test: - find/create a patron with a guarantor - Set AllowStaffToSetCheckoutsVisibilityForGuarantor and AllowPatronToSetCheckoutsVisibilityForGuarantor to Allow - Edit patron to set Show Checkouts to Guarantor to Yes - Confirm patron incorrectly shows "No" on moremember.pl (Details tab) - Apply patch - Confirm the display changes to "Yes" - Change the value to "No" in the patron record - Verify that the display changed accordingly -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24353 Michal Denar <black23@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |black23@gmail.com Status|Needs Signoff |Patch doesn't apply --- Comment #4 from Michal Denar <black23@gmail.com> --- Please, rebase this bug on master. Thank you. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24353 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Michal Denar from comment #4)
Please, rebase this bug on master.
Thank you.
This patch is for 19.05 only. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24353 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor@tuxayo.net -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24353 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105301|0 |1 is obsolete| | --- Comment #6 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 106422 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106422&action=edit Bug 24353: [19.05] Correct display of privacy_guarantor_checkouts on moremember.pl The variable for 'Show checkouts to guarantor' was incorrect so it would always show as 'No' on the Details tab in the patron account in staff. To test: - find/create a patron with a guarantor - Set AllowStaffToSetCheckoutsVisibilityForGuarantor and AllowPatronToSetCheckoutsVisibilityForGuarantor to Allow - Edit patron to set Show Checkouts to Guarantor to Yes - Confirm patron incorrectly shows "No" on moremember.pl (Details tab) - Apply patch - Confirm the display changes to "Yes" - Change the value to "No" in the patron record - Verify that the display changed accordingly Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24353 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #7 from Victor Grousset/tuxayo <victor@tuxayo.net> --- It works! :) A guess of the continuation of the process would be: - QA as usual - instead of the RM to push to master, it would be the RMaint of 19.05.x (turns out to be me) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24353 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |alex.arnaud@biblibre.com |y.org | CC| |alex.arnaud@biblibre.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24353 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #106422|0 |1 is obsolete| | --- Comment #8 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 106502 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106502&action=edit Bug 24353: [19.05] Correct display of privacy_guarantor_checkouts on moremember.pl The variable for 'Show checkouts to guarantor' was incorrect so it would always show as 'No' on the Details tab in the patron account in staff. To test: - find/create a patron with a guarantor - Set AllowStaffToSetCheckoutsVisibilityForGuarantor and AllowPatronToSetCheckoutsVisibilityForGuarantor to Allow - Edit patron to set Show Checkouts to Guarantor to Yes - Confirm patron incorrectly shows "No" on moremember.pl (Details tab) - Apply patch - Confirm the display changes to "Yes" - Change the value to "No" in the patron record - Verify that the display changed accordingly Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: Alex Arnaud <alex.arnaud@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24353 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24353 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.05.13 released in| | Status|Passed QA |Pushed to oldoldstable --- Comment #9 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Pushed to 19.05.x branch for 19.05.13, thanks to everyone involved! :D -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org