[Bug 15794] New: Allow the use of emojis as tags on records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15794 Bug ID: 15794 Summary: Allow the use of emojis as tags on records Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org A library requested the ability to add emojis in the tag field on the opac. Entering an emoji now seems to scrub it clear and leave no value in the db but still enter a new tag. Subsequent attempts warn of repeated tags. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15794 rhilliker@hotchkiss.org changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rhilliker@hotchkiss.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15794 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron@veron.ch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15794 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset@hotmail.com --- Comment #1 from M. Tompsett <mtompset@hotmail.com> --- mysql> show variables like '%char%'; +--------------------------+----------------------------+ | Variable_name | Value | +--------------------------+----------------------------+ | character_set_client | utf8 | | character_set_connection | utf8 | | character_set_database | latin1 | | character_set_filesystem | binary | | character_set_results | utf8 | | character_set_server | latin1 | | character_set_system | utf8 | | character_sets_dir | /usr/share/mysql/charsets/ | +--------------------------+----------------------------+ 8 rows in set (0.00 sec) mysql> set character_set_database=utf8mb4; Query OK, 0 rows affected (0.00 sec) mysql> set character_set_connection=utf8mb4; Query OK, 0 rows affected (0.00 sec) mysql> set character_set_client=utf8mb4; Query OK, 0 rows affected (0.00 sec) mysql> set character_set_results=utf8mb4; Query OK, 0 rows affected (0.00 sec) mysql> show variables like '%char%'; +--------------------------+----------------------------+ | Variable_name | Value | +--------------------------+----------------------------+ | character_set_client | utf8mb4 | | character_set_connection | utf8mb4 | | character_set_database | utf8mb4 | | character_set_filesystem | binary | | character_set_results | utf8mb4 | | character_set_server | latin1 | | character_set_system | utf8 | | character_sets_dir | /usr/share/mysql/charsets/ | +--------------------------+----------------------------+ 8 rows in set (0.00 sec) mysql> drop database test_unicode; Query OK, 1 row affected (0.01 sec) mysql> CREATE DATABASE test_unicode DEFAULT CHARACTER SET utf8 DEFAULT COLLATE utf8_general_ci; Query OK, 1 row affected (0.00 sec) mysql> use test_unicode; Database changed mysql> create table simple_table (text varchar(100)) collate utf8_unicode_ci; Query OK, 0 rows affected (0.01 sec) mysql> INSERT INTO simple_table VALUES ('💩'); Query OK, 1 row affected, 1 warning (0.00 sec) mysql> show warnings; +---------+------+-----------------------------------------------------------------------+ | Level | Code | Message | +---------+------+-----------------------------------------------------------------------+ | Warning | 1366 | Incorrect string value: '\xF0\x9F\x92\xA9' for column 'text' at row 1 | +---------+------+-----------------------------------------------------------------------+ 1 row in set (0.00 sec) mysql> delete from simple_table; Query OK, 1 row affected (0.00 sec) mysql> drop table simple_table; Query OK, 0 rows affected (0.00 sec) mysql> create table simple_table (text varchar(100)) collate utf8mb4_unicode_ci; Query OK, 0 rows affected (0.02 sec) mysql> INSERT INTO simple_table VALUES ('💩'); Query OK, 1 row affected (0.01 sec) mysql> select * from simple_table; +------+ | text | +------+ | 💩 | +------+ 1 row in set (0.00 sec) mysql> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15794 --- Comment #2 from M. Tompsett <mtompset@hotmail.com> --- https://dev.mysql.com/doc/refman/5.7/en/charset-unicode-utf8mb4.html Hope these point in a useful direction. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15794 --- Comment #3 from M. Tompsett <mtompset@hotmail.com> --- P.S. DataTables may not be as unicode friend as we would like for this. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15794 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=11944 --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- See bug 11944 comment 247 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15794 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|NEW |RESOLVED CC| |nengard@gmail.com --- Comment #5 from Nicole C. Engard <nengard@gmail.com> --- *** This bug has been marked as a duplicate of bug 15885 *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15794 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED CC| |katrin.fischer@bsz-bw.de Resolution|DUPLICATE |--- -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15794 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- *** Bug 15885 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15794 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- URL| |http://devs.bywatersolution | |s.com/projects/enable-emoji | |-support-tags/ -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15794 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |nick@bywatersolutions.com Status|REOPENED |NEW -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15794 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored --- Comment #7 from Nicole C. Engard <nengard@gmail.com> --- Work to be done: * Fix storage of Emoji characters in the database ** Emoji characters are supported in Unicode: http://www.unicode.org/emoji/charts/full-emoji-list.html * Research and implement tools to display Emojis properly in the Staff and OPAC Seeking co-sponsors: http://devs.bywatersolutions.com/projects/enable-emoji-support-tags/ -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15794 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|Sponsored |Seeking cosponsors -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15794 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard@gmail.com | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15794 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18336 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15794 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj@kohaaloha.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15794 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|nick@bywatersolutions.com |tomascohen@gmail.com CC| |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15794 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18336 | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15794 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |18336 Status|NEW |ASSIGNED Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18336 [Bug 18336] Use utf8mb4 instead of utf8 for MySQL tables, columns, and connections -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15794 --- Comment #8 from Tomás Cohen Arazi <tomascohen@gmail.com> --- I made this bug dependent on 18336, because (as Mark correctly pointed out) the big problem for this is the DB handling this 4-byte characters (emojis, some japanese chars, etc). Changing the DB like this is important for other areas, not just tags. Luckily, I've submitted the patches to implement the change (on bug 18336). It will need to be broadly tested, so start now :-D I will leave this bug open, for the specific task of integrating an emoji picker for the tags adding form in the OPAC :-D -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15794 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Allow the use of emojis as |Add emoji picker to tag |tags on records |entry in OPAC -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15794 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15794 --- Comment #9 from Tomás Cohen Arazi <tomascohen@gmail.com> --- I've had trouble posting the patches here. Please use this branch to get the patches: https://github.com/tomascohen/koha/tree/bug_15794_emoji_tags -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15794 --- Comment #10 from M. Tompsett <mtompset@hotmail.com> --- I would recommend posting just the non-emoji picker parts, and then having people do the following on a kohadevbox: cd ~ git clone https://github.com/OneSignal/emoji-picker.git cd emoji-picker/lib mkdir ~/kohaclone/koha-tmpl/opac-tmpl/lib/emoji-picker cp -r -v . ~/kohaclone/koha-tmpl/opac-tmpl/lib/emoji-picker cd ~/kohaclone git add `find ~/kohaclone/koha-tmpl/opac-tmpl/lib/emoji-picker` git commit -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15794 --- Comment #11 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 71053 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71053&action=edit Bug 15794: Add Emoji Picker TEST PLAN --------- 1) apply this patch 2) Run the commands in comment #10 3) Attempt to add emoji tags in OPAC -- some system preferences may need setting 4) run koha qa test tools NOTE: The failure resulting from the click will be a different bug. Also, do not include the emoji picker library, as the PNG files are too large to attach. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15794 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #12 from M. Tompsett <mtompset@hotmail.com> --- Remember to apply the dependency first, and run an update, and perhaps even a reset_all just to make sure your data in prepared for this. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15794 --- Comment #13 from M. Tompsett <mtompset@hotmail.com> --- Additionally follow up bug that needs creating, updating the about area with the list of One Signal emoji-picker under the MIT and Apache licenses. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15794 --- Comment #14 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to M. Tompsett from comment #13)
Additionally follow up bug that needs creating, updating the about area with the list of One Signal emoji-picker under the MIT and Apache licenses.
Mark, I will add your signature to the version in my github. BTW, I've just updated the patch so the emoji picker works on the results page too! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15794 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71053|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15794 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15794 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com --- Comment #15 from Kyle M Hall <kyle@bywatersolutions.com> --- https://github.com/bywatersolutions/bywater-koha-devel/commit/c30f482d798b54... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15794 --- Comment #16 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 71860 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71860&action=edit Bug 15794: Add [% KOHA_VERSION to .css and .js -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15794 --- Comment #17 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 71861 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71861&action=edit Bug 15794: Add emojiarea to the license area of the about page -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15794 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #18 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15794 Bug 15794 depends on bug 18336, which changed state. Bug 18336 Summary: Add support for Unicode supplementary characters https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18336 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15794 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au --- Comment #19 from David Cook <dcook@prosentient.com.au> --- The emoji picker is causing script errors when using Koha in Endnote X9. I think Endnote X9 uses an (old) embedded version of Internet Explorer, and I think that's why it's happening. Investigating ways of fixing it, but I think I might just send a follow-up about using a system preference to disable the emoji picker. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15794 --- Comment #20 from Owen Leonard <oleonard@myacpl.org> --- (In reply to David Cook from comment #19)
I think Endnote X9 uses an (old) embedded version of Internet Explorer
A scary Halloween short story as told by David. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15794 --- Comment #21 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to David Cook from comment #19)
The emoji picker is causing script errors when using Koha in Endnote X9.
I think Endnote X9 uses an (old) embedded version of Internet Explorer, and I think that's why it's happening.
Investigating ways of fixing it, but I think I might just send a follow-up about using a system preference to disable the emoji picker.
+1 for a syspref. Or better find a more compatible emoji picker. Anyways, please default to enabled to keep the current behavior. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15794 --- Comment #22 from David Cook <dcook@prosentient.com.au> --- (In reply to Owen Leonard from comment #20)
(In reply to David Cook from comment #19)
I think Endnote X9 uses an (old) embedded version of Internet Explorer
A scary Halloween short story as told by David.
🤣 I love you, Owen. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15794 --- Comment #23 from David Cook <dcook@prosentient.com.au> --- (In reply to Tomás Cohen Arazi from comment #21)
+1 for a syspref. Or better find a more compatible emoji picker.
Anyways, please default to enabled to keep the current behavior.
Sounds good to me. For now, we've just hacked it away, but I'll keep this in the back of my mind. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15794 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |25350 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25350 [Bug 25350] Load Emoji picker assets more efficiently -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org