[Bug 25262] New: [19.05.x] Cash register report truncates manual_inv values
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25262 Bug ID: 25262 Summary: [19.05.x] Cash register report truncates manual_inv values Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Reports Assignee: koha-bugs@lists.koha-community.org Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org In 19.05 we have an odd situation. Accountlines accounttype is now VARCHAR(80) In the past it was 5, so in the "Cash register" report we truncated that MANUAL_INV values in our dropdown. At the moment the DB will save a long value, but only provide the truncated values for searching, and so transactions will not show up -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25262 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25262 --- Comment #1 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 103561 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103561&action=edit Bug 25262: [19.05.x] Do not truncate MANUAL_INV in dropdown There is an issue in that historic values will still be truncated, but recent values are not. I feel the cash register report should reflect recent transactions over historic, and the historic are a data cleanup issue To test: 1 - Add a MANUAL_INV value with more than 5 characters 'INCREDIBLE_HULK' 2 - Add a manual invoice to a patron's acccount using this value 3 - Note the full code displays in patrons account 4 - Browse to Reports->Cash register 5 - Search for today's date, the value you createed, and all libraries 6 - No results returned 7 - Apply patch 8 - Repeat 5 9 - The transaction shows -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25262 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #2 from Lucas Gass <lucas@bywatersolutions.com> --- When I apply this patch and create a manual invoice called 'INCREDIBLE_HULK' it will not show up in the Cash Register report when I narrow the search to Transaction Type = "INCREDIBLE_HULK". If I pay it and then do the search I see the Payment transaction. Also, after I run cash_register_stats.pl the dropdown defaults back to 'All payments to the library'. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25262 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #103561|0 |1 is obsolete| | --- Comment #3 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 104082 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104082&action=edit Bug 25262: [19.05.x] Do not truncate MANUAL_INV in dropdown There is an issue in that historic values will still be truncated, but recent values are not. I feel the cash register report should reflect recent transactions over historic, and the historic are a data cleanup issue To test: 1 - Add a MANUAL_INV value with more than 5 characters 'INCREDIBLE_HULK' 2 - Add a manual invoice to a patron's acccount using this value 3 - Note the full code displays in patrons account 4 - Browse to Reports->Cash register 5 - Search for today's date, the value you createed, and all libraries 6 - No results returned 7 - Apply patch 8 - Repeat 5 9 - The transaction shows -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25262 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25262 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104082|0 |1 is obsolete| | --- Comment #4 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 104115 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104115&action=edit Bug 25262: [19.05.x] Do not truncate MANUAL_INV in dropdown There is an issue in that historic values will still be truncated, but recent values are not. I feel the cash register report should reflect recent transactions over historic, and the historic are a data cleanup issue To test: 1 - Add a MANUAL_INV value with more than 5 characters 'INCREDIBLE_HULK' 2 - Add a manual invoice to a patron's acccount using this value 3 - Note the full code displays in patrons account 4 - Browse to Reports->Cash register 5 - Search for today's date, the value you createed, and all libraries 6 - No results returned 7 - Apply patch 8 - Repeat 5 9 - The transaction shows Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25262 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25262 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104115|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 104137 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104137&action=edit Bug 25262: [19.05.x] Do not truncate MANUAL_INV in dropdown There is an issue in that historic values will still be truncated, but recent values are not. I feel the cash register report should reflect recent transactions over historic, and the historic are a data cleanup issue To test: 1 - Add a MANUAL_INV value with more than 5 characters 'INCREDIBLE_HULK' 2 - Add a manual invoice to a patron's acccount using this value 3 - Note the full code displays in patrons account 4 - Browse to Reports->Cash register 5 - Search for today's date, the value you createed, and all libraries 6 - No results returned 7 - Apply patch 8 - Repeat 5 9 - The transaction shows Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25262 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to oldstable Version(s)| |19.05.11 released in| | --- Comment #6 from Lucas Gass <lucas@bywatersolutions.com> --- backported to 19.05.x for 19.05.11 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org