[Bug 17657] New: Item type' s images could not be displayed correctly on the item types admin page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17657 Bug ID: 17657 Summary: Item type's images could not be displayed correctly on the item types admin page Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: System Administration Assignee: jonathan.druart@bugs.koha-community.org Reporter: jonathan.druart@bugs.koha-community.org QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com
From the ML https://lists.katipo.co.nz/pipermail/koha/2016-November/046616.html
When trying to configure an icon for an item type, the chosen icon won't show in the Koha menu "Administration > Item types". I used to see the icon in the first column entitled "Image" - now this column is empty. Also the icon won't show in staff interface or OPAC.
-- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17657 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17657 --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 57617 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57617&action=edit Bug 17657: Fix locations of item types images Koha::ItemType->image_location takes the interface in parameter or default to OPAC.
From the item types admin page, we need to specify the intranet interface to retrieve the correct image's url
Test plan: Go on the item types admin page, see the source of the page and find the image' urls. => Without this patch, they point to the OPAC => With this patch, the location is correct -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17657 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |14828 --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- This is caused by bug 14828. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14828 [Bug 14828] Move the item types related code to Koha::ItemTypes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17657 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17657 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57617|0 |1 is obsolete| | --- Comment #3 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 57618 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57618&action=edit [SIGNED-OFF] Bug 17657: Fix locations of item types images Koha::ItemType->image_location takes the interface in parameter or default to OPAC.
From the item types admin page, we need to specify the intranet interface to retrieve the correct image's url
Test plan: Go on the item types admin page, see the source of the page and find the image' urls. => Without this patch, they point to the OPAC => With this patch, the location is correct Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17657 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17657 --- Comment #4 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 57645 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57645&action=edit Bug 17657: Fix locations of item types images Koha::ItemType->image_location takes the interface in parameter or default to OPAC.
From the item types admin page, we need to specify the intranet interface to retrieve the correct image's url
Test plan: Go on the item types admin page, see the source of the page and find the image' urls. => Without this patch, they point to the OPAC => With this patch, the location is correct Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17657 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57618|0 |1 is obsolete| | Attachment #57645|0 |1 is obsolete| | --- Comment #5 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 57646 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57646&action=edit Bug 17657: Fix locations of item types images Koha::ItemType->image_location takes the interface in parameter or default to OPAC.
From the item types admin page, we need to specify the intranet interface to retrieve the correct image's url
Test plan: Go on the item types admin page, see the source of the page and find the image' urls. => Without this patch, they point to the OPAC => With this patch, the location is correct Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17657 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | Version|unspecified |master CC| |m.de.rooy@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17657 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #6 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master for 16.11, thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17657 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj@kohaaloha.com --- Comment #7 from Mason James <mtj@kohaaloha.com> --- Pushed to 16.05.x, for 16.05.06 release -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17657 Bug 17657 depends on bug 14828, which changed state. Bug 14828 Summary: Move the item types related code to Koha::ItemTypes https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14828 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org