[Bug 43495] New: Use the new opening hours facade in circulation due date calculations
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43495 Bug ID: 43495 Summary: Use the new opening hours facade in circulation due date calculations Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: martin.renvoize@openfifth.co.uk QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle@bywatersolutions.com Depends on: 43492, 43493 Target Milestone: --- C4::Circulation::CalcDateDue is currently the only functional consumer of library_hours: for hourly loan periods it looks up Koha::Library::Hours rows directly and snaps the due time to open_time/close_time depending on the ConsiderLibraryHoursInCirculation preference, with close to 140 lines of hand-rolled logic duplicated across the Days/Calendar branches, and no handling for slots that cross midnight or the multi-slot/typed hours introduced in Bug 43492. This bug replaces that direct table access with calls onto the Koha::Library::OpeningHours facade from Bug 43492 and Bug 43493 (for its Calendar-aware availability checks), removing Koha::Library::Hour(s) and the old library_hours table reference, and extending due date handling to correctly account for overnight and multi-day opening hours. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43492 [Bug 43492] Normalize library opening hours into a dedicated library_opening_hours table https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43493 [Bug 43493] Link Koha::Library opening hours with the library Calendar -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43495 --- Comment #1 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Merging into Bug 43493 - this bug's scope (switching C4::Circulation::CalcDateDue onto the new facade) is being landed together with the Calendar linkage there, so the combined patch is testable via an actual due date calculation rather than as internal-only wiring with no separately visible behaviour. Please mark this as RESOLVED DUPLICATE of Bug 43493 (my Bugzilla tooling can add comments and change some fields, but not set a resolution). -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43495 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #2 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- *** This bug has been marked as a duplicate of bug 43493 *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43495 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|43493 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43493 [Bug 43493] Link Koha::Library opening hours with the library Calendar -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43495 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|43492 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43492 [Bug 43492] Normalize library opening hours into a dedicated library_opening_hours table -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org