[Bug 10249] New: Untranslatable strings in Javascript on OPAC detail page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10249 Bug ID: 10249 Summary: Untranslatable strings in Javascript on OPAC detail page Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: katrin.fischer@bsz-bw.de http://git.koha-community.org/gitweb/?p=koha.git;a=blob;f=koha-tmpl/opac-tmp... Untranslatable strings are: 178 Your rating 343,354 Go to detail 328 Click to forward the list to 306 Click to rewind the list to Also some CSS is hardcoded, as a background color on line 347 if (highlIndex && i == index) li.css("backgroundColor", "#DDDDDD"); I think one possible solution would be to use variables in those places and then have something like var sth = _("Go to detail") -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10249 --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Also 'by' in a few lines. Everything that builds HTML-Tags with Javascript is a bit suspicious. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10249 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10249 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10249 --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 18235 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18235&action=edit Bug 10249: Fix untranslatable strings in OPAC detail page Star ratings feature: - Your CGI session cookie is not current. Please refresh the page and try again. - average rating: - your rating: Browse results feature: - Click to rewind the list to - See biblio - with biblionumber - by (between title and author) - Click to forward the list to - Go to detail To test: - Update the po file using 'perl translate update <langcode>' - Translate all new strings, maybe mark them with XX to make it easier to find them - Install the updated translation file using 'perl translate install <langcode>' - Test the ratings and browse results features in the OPAC detail page - Verify everything is still working/displaying like it should - Check that you don't find any unstranslated strings/terms Some hints where the changes are: - Change an existing rating - the average and your rating will change - Browse result list and check mouse over tooltips for all links -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10249 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10249 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18235|0 |1 is obsolete| | --- Comment #3 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- Created attachment 18646 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18646&action=edit Bug 10249: Fix untranslatable strings in OPAC detail page Star ratings feature: - Your CGI session cookie is not current. Please refresh the page and try again. - average rating: - your rating: Browse results feature: - Click to rewind the list to - See biblio - with biblionumber - by (between title and author) - Click to forward the list to - Go to detail To test: - Update the po file using 'perl translate update <langcode>' - Translate all new strings, maybe mark them with XX to make it easier to find them - Install the updated translation file using 'perl translate install <langcode>' - Test the ratings and browse results features in the OPAC detail page - Verify everything is still working/displaying like it should - Check that you don't find any unstranslated strings/terms Some hints where the changes are: - Change an existing rating - the average and your rating will change - Browse result list and check mouse over tooltips for all links Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> Strings are now translated, and no emergent JS errors have revealed themselves. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10249 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10249 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18646|0 |1 is obsolete| | --- Comment #4 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 18665 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18665&action=edit Bug 10249: Fix untranslatable strings in OPAC detail page Star ratings feature: - Your CGI session cookie is not current. Please refresh the page and try again. - average rating: - your rating: Browse results feature: - Click to rewind the list to - See biblio - with biblionumber - by (between title and author) - Click to forward the list to - Go to detail To test: - Update the po file using 'perl translate update <langcode>' - Translate all new strings, maybe mark them with XX to make it easier to find them - Install the updated translation file using 'perl translate install <langcode>' - Test the ratings and browse results features in the OPAC detail page - Verify everything is still working/displaying like it should - Check that you don't find any unstranslated strings/terms Some hints where the changes are: - Change an existing rating - the average and your rating will change - Browse result list and check mouse over tooltips for all links Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> Strings are now translated, and no emergent JS errors have revealed themselves. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10249 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gmcharlt@gmail.com --- Comment #5 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master. Thanks, Katrin! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10249 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10249 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |tomascohen@gmail.com --- Comment #6 from Tomás Cohen Arazi <tomascohen@gmail.com> --- This patch has been pushed to 3.12.x, will be in 3.12.1. Thanks Katrin!. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10249 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel@gmail.com --- Comment #7 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Pushed to 3.10.x, will be in 3.10.7 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10249 Chris Hall <chrish@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chrish@catalyst.net.nz --- Comment #8 from Chris Hall <chrish@catalyst.net.nz> --- Pushed to 3.8.x, will be in 3.8.14 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10249 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org