[Bug 7368] New: Staff typo
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7368 Bug #: 7368 Summary: Staff typo Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Platform: All OS/Version: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client AssignedTo: paul.poulain@biblibre.com ReportedBy: m.de.rooy@rijksmuseum.nl QAContact: ian.walls@bywatersolutions.com CC: gmcharlt@gmail.com This is meant for submitting trivial staff client typo fixes, complementing bug 7367. If they are really trivial, and you tested the fix yourself (of course ;), please add your own signoff. The QA team will most probably not mind. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7368 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |PATCH-Sent Summary|Staff typo |General staff client typo | |omnibus Severity|enhancement |trivial -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7368 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|paul.poulain@biblibre.com |m.de.rooy@rijksmuseum.nl -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7368 --- Comment #1 from M. de Rooy <m.de.rooy@rijksmuseum.nl> 2011-12-19 12:52:16 UTC --- Created attachment 6867 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6867 Signed patch Correct spelling of merge authorities job in pref file. At the same time serving as an example of the above.. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7368 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Patch Status|--- |Signed Off -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7368 Ian Walls <ian.walls@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Signed Off |Passed QA --- Comment #2 from Ian Walls <ian.walls@bywatersolutions.com> 2012-01-09 20:36:35 UTC --- Corrects name of script; trivial fix, marking Passed QA -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7368 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.poulain@biblibre.com Version|master |rel_3_6 Patch Status|Passed QA |Patch Pushed --- Comment #3 from Paul Poulain <paul.poulain@biblibre.com> 2012-01-13 10:38:23 UTC --- Patch pushed, please test -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7368 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|PATCH-Sent (DO NOT USE) |P5 - low Status|Pushed to Master |ASSIGNED --- Comment #4 from M. de Rooy <m.de.rooy@rijksmuseum.nl> 2012-01-23 10:54:49 UTC --- Attachment 6867 has been pushed to master and stable. Obsoleting the patch and resetting the status to NEW. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7368 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #6867|0 |1 is obsolete| | -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7368 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEW -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7368 --- Comment #5 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 8179 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8179&action=edit Typo in cart_to_shelf Changing usage print statement only. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7368 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7368 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7368 Ian Walls <koha.sekjal@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #6 from Ian Walls <koha.sekjal@gmail.com> --- Corrects cut/paste error in usage. Trivial change, clearly correct, passed QA. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7368 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7368 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #8179|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7368 --- Comment #7 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 8925 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8925&action=edit [PATCH] 7368 Followup for indentation in VirtualShelves.pm Corrects some further indentation issues, removes last tab from file. Related to report 7310. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- C4/VirtualShelves.pm | 112 ++++++++++++++++++++++++-------------------------- 1 files changed, 54 insertions(+), 58 deletions(-) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7368 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7368 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7368 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7368 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #8925|0 |1 is obsolete| | --- Comment #8 from Paul Poulain <paul.poulain@biblibre.com> --- Comment on attachment 8925 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8925 [PATCH] 7368 Followup for indentation in VirtualShelves.pm QA comment: this patch is indenting only, passed QA Patch pushed in branch new/bug_7310 (and master, of course) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7368 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7368 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Version|rel_3_6 |master -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7368 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron@veron.ch --- Comment #9 from Marc Véron <veron@veron.ch> --- intranet-tmpl/prog/en/modules/help/tools/letter.tt:154 The transfer sliip is printed when you confirm a transfer from one branch to another in your system (double ii in sliip) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7368 --- Comment #10 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 9496 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9496&action=edit Patch for Card title Changing label for Card to Card in acqui/z3950 search. Goes on top of patch in report 5345 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7368 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7368 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9496|0 |1 is obsolete| | --- Comment #11 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 9497 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9497&action=edit Signed patch Includes self signoff for trivial change -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7368 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7368 Ian Walls <koha.sekjal@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #12 from Ian Walls <koha.sekjal@gmail.com> --- Trivial string change for consistency. Signing off and passing QA. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7368 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Patch doesn't apply --- Comment #13 from Paul Poulain <paul.poulain@biblibre.com> --- For an unknown reason, I get a nasty fatal: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/en/modules/acqui/z3950_search.tt). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0001 7368 typo: MARC -> Card When you have resolved this problem run "git am --resolved". Can you resubmit ? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7368 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9497|0 |1 is obsolete| | --- Comment #14 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 9564 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9564&action=edit Patch Retry.. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7368 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7368 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7368 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #15 from Paul Poulain <paul.poulain@biblibre.com> --- trivial patch, pushed. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7368 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris@bigballofwax.co.nz --- Comment #16 from Chris Cormack <chris@bigballofwax.co.nz> --- Typo fix but not involving translatable strings, will be in 3.8.1 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7368 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9564|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7368 --- Comment #17 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 10191 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10191&action=edit Patch for history.txt Very trivial fix of whitespace. Restores correct display in about (tabs for spaces). -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7368 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7368 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7368 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7368 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=8237 --- Comment #18 from Marc Véron <veron@veron.ch> --- *** Bug 8237 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7368 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |jonathan.druart@biblibre.co | |m --- Comment #19 from Jonathan Druart <jonathan.druart@biblibre.com> --- Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7368 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10191|0 |1 is obsolete| | --- Comment #20 from Paul Poulain <paul.poulain@biblibre.com> --- Comment on attachment 10191 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10191 Patch for history.txt this patch pushed -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7368 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7368 --- Comment #21 from Marc Véron <veron@veron.ch> --- intranet-tmpl/prog/en/modules/help/admin/auth_subfields_structure.tt:18 To edit the subfields, click 'Edit Subfields.' ->... Edit Subfields'. intranet-tmpl/prog/en/modules/help/acqui/basketheader.tt:9 When finished, click 'Save.' ->...'Save'. intranet-tmpl/prog/en/modules/help/admin/aqbudgets.tt:26 li>Planning categories are used for statistical purposes. To learn more about planning categories, check out the Planning Category FAQ. ->Error with <li>? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7368 --- Comment #22 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to comment #21)
intranet-tmpl/prog/en/modules/help/admin/auth_subfields_structure.tt:18 To edit the subfields, click 'Edit Subfields.' ->... Edit Subfields'.
intranet-tmpl/prog/en/modules/help/acqui/basketheader.tt:9 When finished, click 'Save.' ->...'Save'.
intranet-tmpl/prog/en/modules/help/admin/aqbudgets.tt:26 li>Planning categories are used for statistical purposes. To learn more about planning categories, check out the Planning Category FAQ. ->Error with <li>?
Marc, Please send a patch for comment9 and the above typos. You can click take over on the assignee, if you do so. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7368 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|m.de.rooy@rijksmuseum.nl |veron@veron.ch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7368 --- Comment #23 from Marc Véron <veron@veron.ch> --- Created attachment 10457 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10457&action=edit Corrects 2 typos see comment #9 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7368 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10457|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7368 --- Comment #24 from Marc Véron <veron@veron.ch> --- Created attachment 10458 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10458&action=edit Bug 7368 - General staff client typo omnibus Corrects 2 typos, see comment #9 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7368 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7368 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #25 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Attachment 10458: Passed QA. Very trivial typo fix. Marc: In this kind of case you could have attached your own sign-off. See comment1. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7368 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7368 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10458|0 |1 is obsolete| | --- Comment #26 from Paul Poulain <paul.poulain@biblibre.com> --- Comment on attachment 10458 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10458 Bug 7368 - General staff client typo omnibus This patch has been pushed -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7368 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |ASSIGNED --- Comment #27 from Paul Poulain <paul.poulain@biblibre.com> --- all patches pushed, back to assigned -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7368 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|veron@veron.ch |m.de.rooy@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7368 --- Comment #28 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 10937 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10937&action=edit Patch for adding perl dependency Html::FormatText is used in opac-sendbasket.pl and may be part of default Debian. But it is not a default Perl 5.10 module. I had to install it additionally on a test server. So I am adding it to PerlDependencies. Corrected a typo too in comments. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7368 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10937|0 |1 is obsolete| | --- Comment #29 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 10939 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10939&action=edit Patch for cataloging HTML::FormatText HTML::FormatText is used in opac-sendbasket.pl and may be part of default Debian. But it is not a default Perl 5.10 module. I had to install it additionally on a test server. So I am adding it to PerlDependencies. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Corrected a typo too in comments. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7368 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7368 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7368 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |ASSIGNED --- Comment #30 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Forget the latest patch please. I think we should remove this use statement after all; it seems not to be used anyhow.. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7368 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10939|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7368 --- Comment #31 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to comment #30)
Forget the latest patch please. I think we should remove this use statement after all; it seems not to be used anyhow.. Well, not that fast. We need it, but somewhere deeper. opac-sendbasket does not need to call [read: use] it. But via Template::Plugin::HtmlToText it is required via the template of sendbasket. So it should be there after all.
-- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7368 --- Comment #32 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 10956 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10956&action=edit Patch for cataloging dependency So, the third time is always the best :) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7368 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7368 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7368 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #33 from Jonathan Druart <jonathan.druart@biblibre.com> --- This patch displays a warning with the following command: perl koha_perl_deps.pl -i koha_perl_deps.pl: Use of uninitialized value in formline at koha_perl_deps.pl line 65, <DATA> line 522. I think it is caused by the missing 'min_ver' information. However, I don't understand what is the value '2' for required. Can you shed some light on this please ? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7368 --- Comment #34 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to comment #33)
This patch displays a warning with the following command: perl koha_perl_deps.pl -i
koha_perl_deps.pl: Use of uninitialized value in formline at koha_perl_deps.pl line 65, <DATA> line 522.
I think it is caused by the missing 'min_ver' information. However, I don't understand what is the value '2' for required. Can you shed some light on this please ?
Good catch. I saw somewhere else that min_ver was not added too, will correct that now also. I tested about page, but should have run this script too. Thanks. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7368 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10956|0 |1 is obsolete| | --- Comment #35 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 11048 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11048&action=edit Adjusted patch for perl deps Jonathan: Could you please add a signoff too? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7368 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7368 --- Comment #36 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Still wondering about this error: [Fri Jul 20 16:37:07 2012] koha_perl_deps.pl: Use of uninitialized value $version in numeric lt (<) at /usr/local/share/perl5/Modern/Perl.pm line 25. [Fri Jul 20 16:37:07 2012] koha_perl_deps.pl: Use of uninitialized value $version in numeric lt (<) at /usr/local/share/perl5/Modern/Perl.pm line 25. This is separate from the last patch and comes up in current master already. Any idea? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7368 --- Comment #37 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to comment #35)
Created attachment 11048 [details] Adjusted patch for perl deps
Jonathan: Could you please add a signoff too?
Probably, usage=> Core could be amended to Unit tests.. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7368 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset@hotmail.com --- Comment #38 from M. Tompsett <mtompset@hotmail.com> --- *** Bug 8487 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7368 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11048|0 |1 is obsolete| | --- Comment #39 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 11069 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11069&action=edit [SIGNED-OFF] Adjusted patch for perl deps hum... strange, I have no error on current master. And your last patch fixes my previous problem :-) Then I switch to signed-off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7368 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7368 --- Comment #40 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to comment #39)
Created attachment 11069 [details] [SIGNED-OFF] Adjusted patch for perl deps
hum... strange, I have no error on current master.
And your last patch fixes my previous problem :-)
Then I switch to signed-off
Thanks. What perl version are you using BTW ? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7368 --- Comment #41 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to comment #40)
Thanks. What perl version are you using BTW ? $ perl -v This is perl 5, version 14, subversion 2 (v5.14.2)
-- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7368 --- Comment #42 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to comment #41)
(In reply to comment #40)
Thanks. What perl version are you using BTW ? $ perl -v This is perl 5, version 14, subversion 2 (v5.14.2)
Hmm. I have the same. If I run on master perl koha-perl-deps -a I have the error referred above.. Looks like some module does not contain a version, but could not find it? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7368 --- Comment #43 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to comment #42)
Hmm. I have the same. If I run on master perl koha-perl-deps -a I have the error referred above.. Looks like some module does not contain a version, but could not find it?
Note that the error comes first, before the long listing of module names. You could easily miss it. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7368 --- Comment #44 from Jonathan Druart <jonathan.druart@biblibre.com> --- It seems it is caused by the version of Modern::Perl: $pmvers Modern::Perl 1.03 My Modern/Perl.pm contains our $VERSION = '1.03'; Whereas a new version of this module contains: Modern::Perl::VERSION { my ($self, $version) = @_; return $VERSION if $version < 2009; $wanted_date = $version if (caller(1))[3] =~ /::BEGIN/; return 2012; } Actually, I don't know how we can fix that. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7368 --- Comment #45 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to comment #44)
It seems it is caused by the version of Modern::Perl:
Good, you found that. Interesting! I have this version: $Modern::Perl::VERSION = '1.20120130' and the same routine. But I still do not understand it completely. It seems like an error in Modern::Perl although its docs state that it is not necessary to pass a version or a year to Modern::Perl. AFAIK we are not passing numbers to Modern::Perl in our Koha use statements. But when I test that in a simple script, I do not even raise this warning. What makes koha_perl_deps do raise that warning? Since this is not very important, I will copy the last comments on this error in a separate report. To be resolved one day :) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7368 --- Comment #46 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to comment #45)
Since this is not very important, I will copy the last comments on this error in a separate report. To be resolved one day :)
See further bug 8491. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7368 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11069|0 |1 is obsolete| | --- Comment #47 from Paul Poulain <paul.poulain@biblibre.com> --- Comment on attachment 11069 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11069 [SIGNED-OFF] Adjusted patch for perl deps trivial patch, passed QA and pushed in one go -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7368 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7368 --- Comment #48 from Chris Cormack <chris@bigballofwax.co.nz> --- The latest patch doesn't apply on 3.8.x please resubmit if you think it should be there too. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7368 --- Comment #49 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 11189 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11189&action=edit [3.8.X] 7368 Adjustments for Perl dependencies Fixed conflict for 3.8.X -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7368 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7368 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Version|master |rel_3_8 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7368 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7368 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7368 --- Comment #50 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Changed status to Pushed to master for inclusion of rebased 3.8.x patch. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7368 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #51 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.8.x will be in 3.8.4 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7368 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11189|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7368 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7368 --- Comment #52 from Kathryn Tyree <kathryn@catalyst.net.nz> --- Created attachment 11760 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11760&action=edit Patch to fix typo subsribe --> subscribe -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7368 Kathryn Tyree <kathryn@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff CC| |kathryn@catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7368 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11760|0 |1 is obsolete| | --- Comment #53 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 11761 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11761&action=edit [SIGNED-OFF] Bug 7368: fixed subsribe typo Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Corrects typo. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7368 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Version|rel_3_8 |master -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7368 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #54 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Thanks, Kathryn and Katrin! Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7368 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11761|0 |1 is obsolete| | --- Comment #55 from Paul Poulain <paul.poulain@biblibre.com> --- Comment on attachment 11761 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11761 [SIGNED-OFF] Bug 7368: fixed subsribe typo This patch has been pushed -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7368 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7368 --- Comment #56 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 13395 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13395&action=edit Patch for dependant= occurrences Should be dependent= Note: ignored feature in most browsers! But dependant is ignored everywhere :) Covers: koha-tmpl/intranet-tmpl/prog/en/js/basket.js koha-tmpl/intranet-tmpl/prog/en/includes/virtualshelves-toolbar.inc koha-tmpl/opac-tmpl/ccsr/en/js/basket.js koha-tmpl/opac-tmpl/prog/en/js/basket.js one occurrence already covered by bug 9059 koha-tmpl/opac-tmpl/prog/en/modules/opac-shelves.tt -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7368 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7368 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion --- Comment #57 from Owen Leonard <oleonard@myacpl.org> --- (In reply to comment #56)
Note: ignored feature in most browsers! But dependant is ignored everywhere
Ignored by most browsers? Is it followed by *any* browsers? I suggest we remove rather than correct references to it. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7368 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|koha.sekjal@gmail.com | --- Comment #58 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to comment #57)
Ignored by most browsers? Is it followed by *any* browsers? I suggest we remove rather than correct references to it.
Removing them in adjusted patch. Could you sign off? Thx. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7368 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #13395|0 |1 is obsolete| | --- Comment #59 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 13443 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13443&action=edit Patch for dependant Adjusted patch removing dependant= -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7368 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7368 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7368 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #13443|0 |1 is obsolete| | --- Comment #60 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 13446 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13446&action=edit [SIGNED-OFF] 7368 Removing occurrences of dependant= feature in javascript open calls The window feature dependant= should have been written as dependent= Note that this feature is ignored in most/current browsers. Since the feature was misspelled, removing it will not change any behavior or hurt anybody. Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7368 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Version|master |3.10 QA Contact| |paul.poulain@biblibre.com --- Comment #61 from Paul Poulain <paul.poulain@biblibre.com> --- QA comment: * small patch, cleaning code. * no change in strings passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7368 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |jcamins@cpbibliography.com --- Comment #62 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This patch has been pushed to master. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7368 --- Comment #63 from Paul Poulain <paul.poulain@biblibre.com> --- Patch pushed to branch 3.10.x -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7368 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7368 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #13446|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7368 --- Comment #64 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 13971 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13971&action=edit Patch for GetXmlBiblio documentation Only changing some documentation about GetXmlBiblio in Biblio.pm, ImportBatch.pm and export.pl. IMO further references to GetXmlBiblio (from grepping) were not interesting enough to include. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7368 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |String patch Version|3.10 |master -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7368 Mirko Tietgen <mirko@abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mirko@abunchofthings.net --- Comment #65 from Mirko Tietgen <mirko@abunchofthings.net> --- Hey Marcel, I think you have missed the word 'contain' somewhere here? "The XML should only biblio information" I am hesitating to bloat this with a followup, maybe you would like to just update your patch? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7368 --- Comment #66 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to comment #65)
Hey Marcel,
I think you have missed the word 'contain' somewhere here? "The XML should only biblio information"
I am hesitating to bloat this with a followup, maybe you would like to just update your patch?
Hi Mirko, If you signoff, I do not mind that you amend the commit for such things. Thx. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7368 Mirko Tietgen <mirko@abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #13971|0 |1 is obsolete| | --- Comment #67 from Mirko Tietgen <mirko@abunchofthings.net> --- Created attachment 14114 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14114&action=edit 7368 GetXmlBiblio Only changing some documentation about GetXmlBiblio Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7368 Mirko Tietgen <mirko@abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14114|0 |1 is obsolete| | --- Comment #68 from Mirko Tietgen <mirko@abunchofthings.net> --- Created attachment 14115 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14115&action=edit 7368 GetXmlBiblio Only changing some documentation about GetXmlBiblio Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net> Added the word 'contain' -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7368 Mirko Tietgen <mirko@abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7368 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #69 from Jonathan Druart <jonathan.druart@biblibre.com> --- QA Comments: Last patch changes some lines of documentation. Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7368 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14115|0 |1 is obsolete| | --- Comment #70 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 14263 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14263&action=edit 7368 GetXmlBiblio Only changing some documentation about GetXmlBiblio Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net> Added the word 'contain' Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7368 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Stable --- Comment #71 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to master and 3.10.x -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7368 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14263|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7368 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |ASSIGNED QA Contact|paul.poulain@biblibre.com | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7368 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=7367 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7368 --- Comment #72 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 16095 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16095&action=edit Bug 7368: POD doc in VirtualShelves.pm Only moving/adding some documentation in VirtualShelves.pm. Related to earlier changes in connection with report 7310. Adding my own signoff, nothing to test here. Does Koha still work? :) Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7368 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7368 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7368 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #73 from Paul Poulain <paul.poulain@biblibre.com> --- QA comment for http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16095 : trivial patch, koha-qa OK, passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7368 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #74 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This patch has been pushed to master. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7368 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16095|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7368 --- Comment #75 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 17182 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17182&action=edit Bug 7368: Typo in kohastructure.sql documentation line Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7368 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7368 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7368 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7368 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7368 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17182|0 |1 is obsolete| | --- Comment #76 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 17183 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17183&action=edit Bug 7368: Typo in kohastructure.sql documentation line Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7368 --- Comment #77 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 17452 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17452&action=edit 7368 Typo in edithelp.pl warning Typo: able save => able to save. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7368 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #78 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This patch has been pushed to master and 3.12.x. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7368 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7368 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7368 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17452|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7368 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17183|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7368 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7368 --- Comment #79 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 17785 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17785&action=edit Bug 7368: Small typo in history.txt beomes becomes becomes :) Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7368 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7368 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17785|0 |1 is obsolete| | --- Comment #80 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 17817 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17817&action=edit [PASSED QA] Bug 7368: Small typo in history.txt beomes becomes becomes :) Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Fixes a typo in a text file, no problems found. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7368 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #81 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This patch has been pushed to master and 3.12.x. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7368 --- Comment #82 from Connor <connor.fraser13@yahoo.com> --- Created attachment 18400 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18400&action=edit 3 typos in history.txt fixed 3 more typos fixed. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7368 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17817|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7368 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18400|0 |1 is obsolete| | --- Comment #83 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 18401 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18401&action=edit Bug 7368: Correct three typos in history.txt Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7368 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7368 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7368 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7368 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7368 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18401|0 |1 is obsolete| | --- Comment #84 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 18407 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18407&action=edit Bug 7368: Correct three typos in history.txt Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7368 --- Comment #85 from Galen Charlton <gmcharlt@gmail.com> --- Latest pushed to master. Thanks, Connor! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7368 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18407|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7368 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7368 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com --- Comment #86 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Last patch has been pushed to 3.12.x, will be in 3.12.1. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7368 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel@gmail.com --- Comment #87 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Pushed to 3.10.x, will be in 3.10.7 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7368 Chris Hall <chrish@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chrish@catalyst.net.nz --- Comment #88 from Chris Hall <chrish@catalyst.net.nz> --- Pushed to 3.8.x, will be in 3.8.14 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7368 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7368 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7368 --- Comment #89 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 19206 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19206&action=edit Bug 7368: Followup for columns names in userflags.sql An insert statement should contain the column names to avoid confusion and future problems with table definition changes. I have updated the English default file. Will send updates for the other languages in connection with replacing inserts by updates for the additional languages (where possible). For userflags this will be the case. Test plan: Do an install (English). Or run this file from command line. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7368 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7368 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19206|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7368 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7368 --- Comment #90 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 19208 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19208&action=edit Bug 7368: Followup for columns names in userflags.sql An insert statement should contain the column names to avoid confusion and future problems with table definition changes. I have updated the English default file. Will send updates for the other languages in connection with replacing inserts by updates for the additional languages (where possible). For userflags this will be possible. Test plan: Do an install (English). Or -- as a dangerous(!) alternative--: Do this ONLY on a restorable database. Delete all records in userflags. (Note: This cascades to permissions a.o.) Run this file from command line. Check if you have records again in userflags. (You also messed up your Koha.) Restore your database. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Tested both ways myself :) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7368 --- Comment #91 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 19230 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19230&action=edit SIGNED-OFF-Bug-7368-Followup-for-columns-names-in-us Manual upload, git bz is playing tricks with me. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7368 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19208|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7368 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #92 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Comment: Work as described. No errors. Tested using second alternative Just a note: if you update other lang files replacing INSERTs for UPDATEs then you must install using EN and later apply lang files by hand. If you do a translate first before webinstaller, and finish your install in your lang, then that kind of file will fail. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7368 --- Comment #93 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Thanks, Bernardo.
Just a note: if you update other lang files replacing INSERTs for UPDATEs then you must install using EN and later apply lang files by hand. If you do a translate first before webinstaller, and finish your install in your lang, then that kind of file will fail.
No, I am not suggesting a manual procedure. It will be done automatically in the web installer. Will open a new report for it soon. (I started a discussion about this on dev list recently..) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7368 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |10509 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7368 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7368 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19230|0 |1 is obsolete| | --- Comment #94 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 19258 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19258&action=edit Bug 7368: Followup for columns names in userflags.sql An insert statement should contain the column names to avoid confusion and future problems with table definition changes. I have updated the English default file. Will send updates for the other languages in connection with replacing inserts by updates for the additional languages (where possible). For userflags this will be possible. Test plan: Do an install (English). Or -- as a dangerous(!) alternative--: Do this ONLY on a restorable database. Delete all records in userflags. (Note: This cascades to permissions a.o.) Run this file from command line. Check if you have records again in userflags. (You also messed up your Koha.) Restore your database. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Tested both ways myself :) Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Comment: Work as described. No errors. Tested using second alternative Just a note: if you update other lang files replacing INSERTs for UPDATEs then you must install using EN and later apply lang files by hand. If you do a translate first before webinstaller, and finish your install in your lang, then that kind of file will fail. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> mysql> create database test; Query OK, 1 row affected (0.00 sec) % mysql -u koha -p test < installer/data/mysql/kohastructure.sql % mysql -u koha -p test < installer/data/mysql/en/mandatory/userflags.sql mysql> select count(*) from userflags; +----------+ | count(*) | +----------+ | 19 | +----------+ 1 row in set (0.00 sec) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7368 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19258|0 |1 is obsolete| | --- Comment #95 from Galen Charlton <gmcharlt@gmail.com> --- Comment on attachment 19258 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19258 Bug 7368: Followup for columns names in userflags.sql Pushed latest to master. Thanks, Marcel! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7368 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7368 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|10509 | -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org