[Bug 39569] New: When cancelling a hold waiting past expiration date triggers a transfer the libraries name is not in alert
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39569 Bug ID: 39569 Summary: When cancelling a hold waiting past expiration date triggers a transfer the libraries name is not in alert Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: blawlor@clamsnet.org QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com To recreate: - Use a bib with a single item to make this easier - Place two holds on a bib with pickup at one library - Place some more holds for pickup at a different library - Check the item in to the first library - Set the expiration date back in time, using ktd --dbshell can help update reserves set expirationdate = DATE('2024-01-01') where branchcode='CPL'; - On Holds awaiting pickup > Holds waiting past their expiration date use the button in the actions tab to 'Cancel hold' the alert says: This item is on hold for pick-up at your library' - click OK - Check the item in again and set expiration date to expired again - On Holds awaiting pickup > Holds waiting past their expiration date use the button in the actions tab to 'Cancel hold and transfer to: [libraryname]' - Notice the alert says 'This item is on hold for pick-up at' with no library name -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39569 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39569 --- Comment #1 from Brendan Lawlor <blawlor@clamsnet.org> --- Created attachment 180670 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180670&action=edit Bug 39569: Fix branch name in alert when cancelling holds over x To test: 1. On a bib with one item place a hold for pickup at library A and Library B 2. Check the item into library A 3. Set the first hold's expiration date to the past 4. On Holds awaiting pickup > Holds waiting past their expiration date In the actions column click the 'Cancel hold' button 5. Notice the alert says 'This item is on hold for pick-up at' with no library name 6. Apply patch and redo steps 1-4 7. Confirm the alert include's Library B's name This item is on hold for pick-up at Library B -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39569 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39569 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180670|0 |1 is obsolete| | --- Comment #2 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 181503 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181503&action=edit Bug 39569: Fix branch name in alert when cancelling holds over x To test: 1. On a bib with one item place a hold for pickup at library A and Library B 2. Check the item into library A 3. Set the first hold's expiration date to the past 4. On Holds awaiting pickup > Holds waiting past their expiration date In the actions column click the 'Cancel hold' button 5. Notice the alert says 'This item is on hold for pick-up at' with no library name 6. Apply patch and redo steps 1-4 7. Confirm the alert include's Library B's name This item is on hold for pick-up at Library B Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39569 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com Status|Signed Off |Passed QA --- Comment #3 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Trivial fix, PQA -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39569 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |nick@bywatersolutions.com |y.org | Assignee|koha-bugs@lists.koha-commun |blawlor@clamsnet.org |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39569 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |25.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39569 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 25.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39569 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |trivial -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39569 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable CC| |fridolin.somers@biblibre.co | |m Version(s)|25.05.00 |25.05.00,24.11.10 released in| | --- Comment #5 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 24.11.x for 24.11.10 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39569 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Needs documenting --- Comment #6 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 22.11.x as it wasn't backported to 24.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39569 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Needs documenting |RESOLVED --- Comment #7 from Brendan Lawlor <blawlor@clamsnet.org> --- Just a bug fix. No functional changes, no documentation needed. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org