[Bug 39597] New: When cancelling multiple holds on a bib record cancel_hold_alert has very low contrast
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39597 Bug ID: 39597 Summary: When cancelling multiple holds on a bib record cancel_hold_alert has very low contrast Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Accessibility Assignee: koha-bugs@lists.koha-community.org Reporter: blawlor@clamsnet.org QA Contact: testopia@bugs.koha-community.org CC: martin.renvoize@openfifth.co.uk, matt.blenkinsop@openfifth.co.uk, oleonard@myacpl.org Created attachment 180747 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180747&action=edit screnshot To recreate: - Go to a bib record and place multiple holds on it - Select multiple holds and click 'Cancel selected (4)' - The Alert says 'This action will cancel 4 hold(s).' - Note that the contrast on the number of holds is very low -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39597 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |blawlor@clamsnet.org |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39597 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39597 --- Comment #1 from Brendan Lawlor <blawlor@clamsnet.org> --- Created attachment 180748 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180748&action=edit Bug 39597: Fix cancel_hold_alert badge color contrast for accesibilty This patch updates the classes on the badge element to fix color contrast To test: 1. Go to a bib record and place multiple holds on it 2. Select multiple holds and click 'Cancel selected (4)' 3. The Alert says 'This action will cancel 4 hold(s).' 4. Note that the contrast on the number of holds is very low 5. Click 'Cancel' apply patch and restart_all 6. Repeat steps 2-3 7. Note that the contrast on the number of holds is good -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39597 --- Comment #2 from Brendan Lawlor <blawlor@clamsnet.org> --- Created attachment 180749 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180749&action=edit contrast with patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39597 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- I think this is correct, but for the full fix it needs to be on top of Bug 39274, but drop the 'text-dark' part: <span class='badge bg-danger'> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39597 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |39274 Status|Failed QA |Needs Signoff Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39274 [Bug 39274] Non public notes are low contrast in the issues table - Previous checkouts -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39597 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180748|0 |1 is obsolete| | --- Comment #4 from Brendan Lawlor <blawlor@clamsnet.org> --- Created attachment 180776 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180776&action=edit Bug 39597: Fix cancel_hold_alert badge color contrast for accesibilty This patch add a class for the background on the badge element to fix color contrast To test: 1. Go to a bib record and place multiple holds on it 2. Select multiple holds and click 'Cancel selected (4)' 3. The Alert says 'This action will cancel 4 hold(s).' 4. Note that the contrast on the number of holds is very low 5. Click 'Cancel' apply patch and restart_all 6. Repeat steps 2-3 7. Note that the contrast on the number of holds is good -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39597 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180749|0 |1 is obsolete| | --- Comment #5 from Brendan Lawlor <blawlor@clamsnet.org> --- Created attachment 180777 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180777&action=edit screenshot with patch Thanks Owen! With bug 39274 applied this looks good -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39597 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39597 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180776|0 |1 is obsolete| | --- Comment #6 from Phil Ringnalda <phil@chetcolibrary.org> --- Created attachment 180885 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180885&action=edit Bug 39597: Fix cancel_hold_alert badge color contrast for accesibilty This patch add a class for the background on the badge element to fix color contrast To test: 1. Go to a bib record and place multiple holds on it 2. Select multiple holds and click 'Cancel selected (4)' 3. The Alert says 'This action will cancel 4 hold(s).' 4. Note that the contrast on the number of holds is very low 5. Click 'Cancel' apply patch and restart_all 6. Repeat steps 2-3 7. Note that the contrast on the number of holds is good Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39597 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |phil@chetcolibrary.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39597 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com QA Contact|testopia@bugs.koha-communit |lucas@bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39597 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39597 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180885|0 |1 is obsolete| | --- Comment #7 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 181670 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181670&action=edit Bug 39597: Fix cancel_hold_alert badge color contrast for accesibilty This patch add a class for the background on the badge element to fix color contrast To test: 1. Go to a bib record and place multiple holds on it 2. Select multiple holds and click 'Cancel selected (4)' 3. The Alert says 'This action will cancel 4 hold(s).' 4. Note that the contrast on the number of holds is very low 5. Click 'Cancel' apply patch and restart_all 6. Repeat steps 2-3 7. Note that the contrast on the number of holds is good Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39597 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |25.05.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39597 --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 25.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39597 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable CC| |fridolin.somers@biblibre.co | |m Version(s)|25.05.00 |25.05.00,24.11.10 released in| | --- Comment #9 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 24.11.x for 24.11.10 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39597 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Needs documenting --- Comment #10 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 22.11.x as it wasn't backported to 24.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39597 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED --- Comment #11 from Brendan Lawlor <blawlor@clamsnet.org> --- This was just a bug fix for accessibility. No functional changes, no documentation needed. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org