http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8705 Fridolyn SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|gmcharlt@gmail.com |fridolyn.somers@biblibre.co | |m --- Comment #1 from Fridolyn SOMERS <fridolyn.somers@biblibre.com> --- Created attachment 11898 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11898&action=edit Proposed patch Very small patch. When help page is not found from URL, display mainpage help. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8705 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11898|0 |1 is obsolete| | --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 11899 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11899&action=edit [SIGNED-OFF] Bug 8705: Software error on help of main page Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8705 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@biblibre.co | |m --- Comment #4 from Jonathan Druart <jonathan.druart@biblibre.com> --- Hum... Ok it is a simple patch and currently, it works. But if someone adds a test before, this one will not save. I can't explain that... an example will be more meaningful: my $s = "aaa"; $s =~ m/a(.)a/; say $1; => display "a" But! my $s = "aaa"; $s =~ m/a(.)a/; say $1; $s =~ m/b(.)b/; say $1 => display "a" x 2 $1 is defined in the second case. We have to test with a if when we want used $1 I don't mark it as Failed QA because this patch does not introduce this, but a followup is highly welcomed :) -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8705 Fridolyn SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff --- Comment #6 from Fridolyn SOMERS <fridolyn.somers@biblibre.com> --- (In reply to comment #4) I understand, $1 should only be used if pattern matches. I revised patch to wrap help template from URL behavior into a sub. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8705 Fridolyn SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11921|0 |1 is obsolete| | --- Comment #8 from Fridolyn SOMERS <fridolyn.somers@biblibre.com> --- Created attachment 11924 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11924&action=edit Proposed patch (revised 2) Is this better ? Can you say more about it ? -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8705 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #10 from Jonathan Druart <jonathan.druart@biblibre.com> --- It's ok for me. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8705 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |paul.poulain@biblibre.com Version|master |rel_3_8 --- Comment #12 from Paul Poulain <paul.poulain@biblibre.com> --- Patch pushed to master -- You are receiving this mail because: You are watching all bug changes.